Comment 2 for bug 1234898

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

One thing I did noticed when looking at the code is that the 'socket_reader' function seems to expect the input buffer to be one-line only, and not a block (buf could be a block when reading data from the socket).

As a result upstart_emit_event can emit 'buf' containing more than one event at the same time (including "\n"), which might cause issues later on.

As I'm not that familiar with the code, will let James to comment on the subject.