Messaging menu does not change icon when a new message appears
Bug #1215644 reported by
Omer Akram
This bug affects 8 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Messaging Menu |
Fix Released
|
Undecided
|
Lars Karlitski | ||
indicator-messages (Ubuntu) |
Fix Released
|
High
|
Lars Karlitski | ||
Saucy |
Fix Released
|
High
|
Lars Karlitski | ||
unity8 (Ubuntu) |
Fix Released
|
High
|
Nick Dedekind | ||
Saucy |
Fix Released
|
High
|
Nick Dedekind |
Bug Description
I just pulled indicator-messages from trunk (bzr360) and installed it on the phone and rebooted. Now when a new message appears, I get the OSD notification and when I open the messaging menu there is indeed a pending sms there but The color of the messaging menu did not change. See the attached screenshot.
Related branches
lp:~larsu/indicator-messages/lp1215644
- Ted Gould (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 20 lines (+2/-1)1 file modifiedlibmessaging-menu/messaging-menu-message.c (+2/-1)
lp:~nick-dedekind/unity8/unitymenumodel.messages
- PS Jenkins bot (community): Approve (continuous-integration)
- Michael Zanetti (community): Approve
-
Diff: 1100 lines (+336/-214)25 files modifiedPanel/IndicatorsDataModel.qml (+2/-2)
debian/unity8.install (+0/-1)
plugins/Unity/Indicators/CMakeLists.txt (+1/-0)
plugins/Unity/Indicators/Messaging/qml/ActionTextField.qml (+10/-7)
plugins/Unity/Indicators/Messaging/qml/CMakeLists.txt (+1/-1)
plugins/Unity/Indicators/Messaging/qml/GroupedMessage.qml (+14/-19)
plugins/Unity/Indicators/Messaging/qml/HeroMessage.qml (+25/-22)
plugins/Unity/Indicators/Messaging/qml/MessageMenuItemFactory.qml (+117/-33)
plugins/Unity/Indicators/Messaging/qml/QuickReply.qml (+10/-5)
plugins/Unity/Indicators/Messaging/qml/SimpleTextMessage.qml (+7/-4)
plugins/Unity/Indicators/Messaging/qml/SnapDecision.qml (+33/-14)
plugins/Unity/Indicators/Messaging/qml/TextMessage.qml (+13/-5)
plugins/Unity/Indicators/Messaging/qml/qmldir (+2/-2)
plugins/Unity/Indicators/plugin.cpp (+2/-0)
plugins/Unity/Indicators/qml/BaseMenuItem.qml (+1/-1)
plugins/Unity/Indicators/qml/IndicatorPage.qml (+33/-6)
plugins/Unity/Indicators/qml/MenuItemFactory.qml (+62/-12)
plugins/Unity/Indicators/resources/indicators.qrc (+3/-0)
plugins/Unity/IndicatorsLegacy/CMakeLists.txt (+0/-1)
plugins/Unity/IndicatorsLegacy/Messaging/qml/ActionButton.qml (+0/-43)
plugins/Unity/IndicatorsLegacy/qml/MenuItemFactory.qml (+0/-8)
plugins/Unity/IndicatorsLegacy/resources/indicators.qrc (+0/-3)
src/Panel/Indicators/CMakeLists.txt (+0/-1)
src/Panel/Indicators/servicefiles/CMakeLists.txt (+0/-14)
src/Panel/Indicators/servicefiles/com.canonical.indicator.messages (+0/-10)
lp:~larsu/indicator-messages/blue
- Ted Gould (community): Approve
- PS Jenkins bot (community): Approve (continuous-integration)
-
Diff: 215 lines (+55/-40)2 files modifiedsrc/im-application-list.c (+52/-39)
src/im-desktop-menu.c (+3/-1)
Changed in indicator-messages: | |
status: | Fix Committed → Fix Released |
Changed in unity8 (Ubuntu Saucy): | |
assignee: | nobody → Nick Dedekind (nick-dedekind) |
tags: | added: avengers qa-touch |
Changed in indicator-messages (Ubuntu Saucy): | |
assignee: | nobody → Lars Uebernickel (larsu) |
Changed in indicator-messages (Ubuntu Saucy): | |
status: | Confirmed → Fix Released |
To post a comment you must log in.
This is really a bug in telephony-service, which didn't call messaging_ menu_message_ set_draws_ attention( ). We probably didn't notice this bug before because chewie-client turned the messaging menu icon blue by itself.
However, I'm attaching a fix for libmessaging-menu anyway: "draws-attention" should really default to TRUE. The phone app doesn't need any updates.