Comment 51 for bug 1506744

Revision history for this message
Allison Karlitskaya (desrt) wrote :

The latest patch looks good to me, but with a couple of notes (no need to fix these):

 - using the _full() version of the timeout call is not necessary here

 - now that this patch is simplified it becomes easy to see how all of this is just putting values into one structure and then later moving them into another structure. It seems like we could have just used the first structure type, or even just fixed the other queue mechanism to add the delay. Oh well. No real gain from making that change at this point.