Keyboard shortcut - Add keyboard shortcut hint overlay that is displayed when a user presses and holds the Super key
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ayatana Design |
Fix Released
|
High
|
John Lea | ||
Unity |
Fix Released
|
High
|
Andrea Azzarone | ||
unity-2d |
Invalid
|
High
|
Unassigned | ||
unity (Ubuntu) |
Fix Released
|
High
|
Andrea Azzarone |
Bug Description
Add keyboard shortcut hint overlay that is displayed when a user presses and holds the Super key.
See the attached design "Super_
This should be displayed every time the user presses and holds the Super key, at the same time the Launcher keyboard shortcut hints are displayed. Releasing the Super key should hide this overlay, again at the same time the Launcher keyboard shortcust hints are hidden. If screen size is smaller than 1024*768, the shortcut window should not be displayed.
Also not that the design of the Launcher keyboard shortcust hints has been updated.
The design is attached to this bug, see "keyboard_
-------
Accessibility notes:
- For users of screen readers, as soon as the Alt key is held down, a reading of the text should be piped directly through to the speech dispatcher. The reading should stop as soon as the Alt key is released.
- This overlay should be automatically disabled if sticky keys are turned on
Related branches
- Marco Trevisan (Treviño): Approve
- John Lea (community): Approve (design)
- Tim Penhey (community): Approve
-
Diff: 2326 lines (+2055/-7)25 files modifiedplugins/unityshell/src/AbstractSeparator.cpp (+68/-0)
plugins/unityshell/src/AbstractSeparator.h (+49/-0)
plugins/unityshell/src/AbstractShortcutHint.h (+102/-0)
plugins/unityshell/src/BackgroundEffectHelper.cpp (+1/-1)
plugins/unityshell/src/LineSeparator.cpp (+73/-0)
plugins/unityshell/src/LineSeparator.h (+44/-0)
plugins/unityshell/src/MockShortcutHint.h (+72/-0)
plugins/unityshell/src/ShortcutController.cpp (+194/-0)
plugins/unityshell/src/ShortcutController.h (+87/-0)
plugins/unityshell/src/ShortcutHint.cpp (+137/-0)
plugins/unityshell/src/ShortcutHint.h (+53/-0)
plugins/unityshell/src/ShortcutHintPrivate.cpp (+79/-0)
plugins/unityshell/src/ShortcutHintPrivate.h (+39/-0)
plugins/unityshell/src/ShortcutModel.cpp (+60/-0)
plugins/unityshell/src/ShortcutModel.h (+64/-0)
plugins/unityshell/src/ShortcutView.cpp (+424/-0)
plugins/unityshell/src/ShortcutView.h (+93/-0)
plugins/unityshell/src/unityshell.cpp (+99/-1)
plugins/unityshell/src/unityshell.h (+9/-1)
plugins/unityshell/unityshell.xml.in (+6/-0)
standalone-clients/CMakeLists.txt (+26/-3)
standalone-clients/TestShortcut.cpp (+109/-0)
tests/CMakeLists.txt (+9/-1)
tests/test_shortcut_model.cpp (+84/-0)
tests/test_shortcut_private.cpp (+74/-0)
- Albert Astals Cid (community): Needs Fixing
- Michał Sawicz: Needs Information
- Florian Boucault (community): Needs Fixing
- Gerry Boland: Pending requested
-
Diff: 657 lines (+572/-0)8 files modifieddebian/unity-2d-shell.install.in (+1/-0)
shell/Shell.qml (+34/-0)
shell/app/shellmanager.cpp (+11/-0)
shell/app/shellmanager.h (+3/-0)
shell/shortcutoverlay/ModelElement.qml (+26/-0)
shell/shortcutoverlay/ShortcutHint.qml (+243/-0)
shell/shortcutoverlay/ShortcutHintSection.qml (+165/-0)
tests/shell/shortcut-hint-overlay-tests.rb (+89/-0)
- Florian Boucault (community): Needs Fixing
- Gerry Boland (community): Needs Fixing
- Michał Sawicz: Needs Fixing
- Albert Astals Cid (community): Needs Fixing
-
Diff: 1259 lines (+723/-148)18 files modifiedlibunity-2d-private/Unity2d/plugin.cpp (+4/-0)
libunity-2d-private/src/lens.cpp (+15/-3)
libunity-2d-private/src/lenses.cpp (+8/-5)
libunity-2d-private/src/lenses.h (+2/-0)
shell/Shell.qml (+6/-1)
shell/app/shelldeclarativeview.cpp (+7/-0)
shell/app/shelldeclarativeview.h (+2/-0)
shell/common/Background.qml (+109/-0)
shell/common/SearchEntry.qml (+25/-33)
shell/dash/Dash.qml (+43/-64)
shell/dash/Home.qml (+1/-1)
shell/dash/LensBar.qml (+20/-19)
shell/dash/LensView.qml (+7/-6)
shell/dash/RendererGrid.qml (+6/-14)
shell/launcher/LauncherLoader.qml (+12/-2)
shell/shortcutoverlay/ShortcutHint.qml (+207/-0)
shell/shortcutoverlay/ShortcutHintSection.qml (+160/-0)
tests/shell/shortcut-hint-overlay-tests.rb (+89/-0)
Changed in ayatana-design: | |
assignee: | nobody → John Lea (johnlea) |
importance: | Undecided → High |
status: | New → Fix Committed |
tags: | added: onew udo |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
tags: | added: udp |
Changed in unity: | |
milestone: | none → backlog |
Changed in ayatana-design: | |
status: | Fix Released → Fix Committed |
Changed in ayatana-design: | |
status: | Fix Committed → Triaged |
Changed in unity: | |
assignee: | nobody → Didier Roche (didrocks) |
Changed in ayatana-design: | |
status: | Triaged → Fix Committed |
Changed in unity: | |
assignee: | Didier Roche (didrocks) → Jason Smith (jassmith) |
description: | updated |
Changed in unity-2d: | |
status: | New → Confirmed |
importance: | Undecided → High |
Changed in unity-2d (Ubuntu): | |
status: | New → Confirmed |
importance: | Undecided → High |
Changed in unity: | |
assignee: | Jason Smith (jassmith) → Andrea Azzarone (andyrock) |
Changed in unity (Ubuntu): | |
assignee: | nobody → Andrea Azzarone (andyrock) |
Changed in unity: | |
status: | Confirmed → In Progress |
Changed in unity (Ubuntu): | |
status: | Confirmed → In Progress |
description: | updated |
description: | updated |
Changed in unity: | |
milestone: | backlog → 5.2.0 |
tags: | added: a11y |
summary: |
- Add keyboard shortcut hint overlay that is displayed when a user presses - and holds the Super key + Keyboard shotcut - Add keyboard shortcut hint overlay that is displayed + when a user presses and holds the Super key |
description: | updated |
tags: | added: keybinding |
description: | updated |
summary: |
- Keyboard shotcut - Add keyboard shortcut hint overlay that is displayed + Keyboard shortcut - Add keyboard shortcut hint overlay that is displayed when a user presses and holds the Super key |
Changed in unity: | |
milestone: | 5.2.0 → 5.0.0 |
Changed in unity: | |
milestone: | 5.0.0 → 5.2.0 |
Changed in unity: | |
status: | In Progress → Fix Committed |
Changed in unity (Ubuntu): | |
status: | In Progress → Fix Committed |
Changed in unity-2d: | |
assignee: | nobody → Lohith D Shivamurthy (dyams) |
Changed in unity: | |
status: | Fix Committed → Fix Released |
Changed in unity-2d: | |
milestone: | none → 5.4 |
Changed in unity-2d: | |
status: | Confirmed → In Progress |
Changed in unity-2d: | |
milestone: | 5.4 → 5.6 |
Changed in unity-2d: | |
milestone: | 5.6 → 5.8 |
Changed in unity-2d: | |
assignee: | Lohith D Shivamurthy (dyams) → Tiago Salem Herrmann (tiagosh) |
Changed in unity-2d: | |
milestone: | 5.8 → 5.10.0 |
Changed in unity-2d: | |
milestone: | 5.10.0 → 5.12 |
Changed in unity-2d: | |
assignee: | Tiago Salem Herrmann (tiagosh) → nobody |
Changed in unity-2d: | |
status: | In Progress → Triaged |
Changed in unity-2d: | |
milestone: | 5.12 → 5.14 |
Changed in ayatana-design: | |
status: | Fix Committed → Fix Released |
tags: |
added: reviewedbydesignp removed: onew udo udp |
no longer affects: | unity-2d (Ubuntu) |
Changed in unity-2d: | |
status: | Triaged → Invalid |
Confirmed as I am not sure whose plate this will fall into.