Comment 2 for bug 1664229

Revision history for this message
Jeremy BĂ­cha (jbicha) wrote :

1. The Maintainer in debian/control should probably be set to an ubuntu.com email address. If you run update-maintainer, it will set the default Ubuntu Developers email address there.

2. Depends: libwnck-dev is probably wrong.

3. Why does this depend on synaptic? I believe Kylin 17.04 already includes both Ubuntu Software and Ubuntu Kylin Software Center.

4. Please drop Suggests: software-center.

5. This package should not conflict with mate-menu because it prevents a user from being able to install both packages. At a quick look, these files should not use the mate-menu ID and name but should use their own name.

data/org.mate.panel.MateMenuApplet.mate-panel-applet
data/org.mate.panel.applet.MateMenuAppletFactory.service

https://www.debian.org/doc/debian-policy/ch-relationships.html#s-conflicts

6. You should not leave the Summary and Description fields blank in
data/org.mate.ukui-menu.gschema.xml

That will help people using the command line or dconf-editor to tweak settings.

7. You should convert to python3.

8. As was mentioned in bug 1664232, it would be better if you would do proper upstream releases and switch to 3.0 (quilt) in debian/source/format. This will allow other distros to make ukui-menu available.

9. This bug needs to be mentioned in debian/changelog

10. You can replace lines 6-55 of your debian/copyright with Files: *