[FFe] ukui-menu

Bug #1664229 reported by handsome_feng on 2017-02-13
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Kylin
Critical
Unassigned
ukui-menu (Ubuntu)
Wishlist
Unassigned

Bug Description

The UKUI Menu is a new style startup menu for UKUI desktop, supports filtering, favorites, easy-uninstallation, autosession, and many other features. It forks from mate-menu, But we almost rewrote all the codes.
It is part of UKUI desktop environment: Bug #1663477.
And It also runs well on Ubuntu Mate.

PPA: https://launchpad.net/~ubuntukylin-members/+archive/ubuntu/ukui

URL: https://github.com/ukui/ukui-menu
License: GPL-2+, GPL-3+, Expat

Changed in ubuntukylin:
importance: Undecided → Critical
milestone: none → zesty-beta1
Brian Murray (brian-murray) wrote :

*** This is an automated message ***

This bug is tagged needs-packaging which identifies it as a request for a new package in Ubuntu. As a part of the managing needs-packaging bug reports specification, https://wiki.ubuntu.com/QATeam/Specs/NeedsPackagingBugs, all needs-packaging bug reports have Wishlist importance. Subsequently, I'm setting this bug's status to Wishlist.

Changed in ubuntu:
importance: Undecided → Wishlist
summary: - [needs-packaging] ukui-menu
+ [FFE] ukui-menu
Jack Yu (jackyu) on 2017-02-20
summary: - [FFE] ukui-menu
+ [FFe] ukui-menu
description: updated
description: updated
description: updated
Jeremy Bicha (jbicha) wrote :

1. The Maintainer in debian/control should probably be set to an ubuntu.com email address. If you run update-maintainer, it will set the default Ubuntu Developers email address there.

2. Depends: libwnck-dev is probably wrong.

3. Why does this depend on synaptic? I believe Kylin 17.04 already includes both Ubuntu Software and Ubuntu Kylin Software Center.

4. Please drop Suggests: software-center.

5. This package should not conflict with mate-menu because it prevents a user from being able to install both packages. At a quick look, these files should not use the mate-menu ID and name but should use their own name.

data/org.mate.panel.MateMenuApplet.mate-panel-applet
data/org.mate.panel.applet.MateMenuAppletFactory.service

https://www.debian.org/doc/debian-policy/ch-relationships.html#s-conflicts

6. You should not leave the Summary and Description fields blank in
data/org.mate.ukui-menu.gschema.xml

That will help people using the command line or dconf-editor to tweak settings.

7. You should convert to python3.

8. As was mentioned in bug 1664232, it would be better if you would do proper upstream releases and switch to 3.0 (quilt) in debian/source/format. This will allow other distros to make ukui-menu available.

9. This bug needs to be mentioned in debian/changelog

10. You can replace lines 6-55 of your debian/copyright with Files: *

Changed in ubuntu:
status: New → Incomplete
handsome_feng (feng-kylin) wrote :

> You should convert to python3.
Ok, we will do this as soon as possible, but maybe after this uploaded to Ubuntu archive?

And we have fixed the other issues your mentioned, Thank you!

Jeremy Bicha (jbicha) wrote :

Thank you.

6. Check data/plugins/org.mate.ukui-menu.plugins.menu.gschema.xml

7. Because other things in the Ubuntu desktop still depend on python2, I'm not going to block this initial release for using python2.

I'm curious to know why you're reluctant to do #8.

9. Please use (LP: #1664229) instead of (LP:1664229) in your debian/changelog.

handsome_feng (feng-kylin) wrote :

Done.

And all the UKUI projects have switched to 3.0(quilt), Thank you!

Jeremy Bicha (jbicha) wrote :

Thank you.

Since this an Ubuntu package, not a Debian package, the version number should end with ubuntu1 for the first Ubuntu upload. And since there isn't a Debian revision you're basing on, the full version number would be 1.0.0-0ubuntu1.

(If your revision were based off a package in Debian, 1.0.0-1, then the Ubuntu version would be 1.0.0-1ubuntu1 to show that it's derived from 1.0.0-1.)

You've now taken the first step to making the UKUI projects separate from their Ubuntu packaging to allow other distros to easily package them if they want. Here are my recommendations for next steps:

11. Remove the debian/ directory from your upstream master branch.
12. Create a release.
https://help.github.com/articles/creating-releases/
13. Maintain your debian/ directory in a separate branch. I recommend using git-buildpackage
14. Add a debian/watch so that uscan and other tools can easily check for the latest available release and download it.

I know I did not give much detail about these steps, so feel free to ask here or in IRC #ubuntu-devel if you need more help.

handsome_feng (feng-kylin) wrote :

Hi, Jeremy,
   We have updated the version number in all UKUI projects, updated the ppa, and almost finished the steps 12-14.
   BTW, when do you think those packages can be in ubuntu archive? The Final Beta is coming soon. :(

Jeremy Bicha (jbicha) wrote :

For ukui-menu, it looks like you tagged the wrong commit? (It's not the most recent commit.)

I will upload ukui-menu when the packaging is ready. (Steps 11-14 are just an expansion of step 8 from my original review.)

After that, the package goes into the new queue, where a member of the Ubuntu Archive Admin will need to review the package for the package to land in zesty.

There is still time for at least some of these UKUI packages to make it into the Final Beta.

Jeremy Bicha (jbicha) wrote :

Thank you for your contribution and helping to make Ubuntu better!

I have uploaded to zesty's new queue now.

I am unsubscribing ubuntu-sponsors. Feel free to resubscribe if something else needs sponsoring.

Changed in ubuntu:
status: Incomplete → In Progress
Jeremy Bicha (jbicha) wrote :
affects: ubuntu → ukui-menu (Ubuntu)
Changed in ukui-menu (Ubuntu):
status: In Progress → Fix Released
Changed in ubuntukylin:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers