Comment 5 for bug 715820

Revision history for this message
Chris McGinlay (chrismcginlay) wrote : Re: [Bug 715820] Re: No tooltip for disconnect button

On Tue, 2011-02-15 at 18:26 +0000, Naty Bidart wrote:
> Chris,
>
> Hello! Thanks for your contribution.
> Question: why are you proposing a branch against the source package? I think it would be best to propose it against the project, so we can add it to the source and the release with the rest of the code.
>
> Also, we require tests to be provided along with the patch, you can
> check ubuntuone/controlpanel/gtk/tests to do so.
>
> Once you get your branch ready, to propose the branch you will need to
> sign the Canonical contributor's agreement located at
> http://www.canonical.com/contributors
>
> If you sign it, please send it to <email address hidden> and to
> myself.
>
> Thanks!
>

Hello Naty and thank you for the instructions. I have signed
contributor's agreement.

In answer to your question about proposing branch against source -vs-
project: this is only the second bug that I have attempted to work on,
so actually I don't know how to propose against project instead of
source. These are the steps I took to push my branch back to the server:

debcommit
bzr push lp:~chris-asce....tware.org.uk/ub...ne-control-panel-fix-715820
bzr lp-open

I should add that I first ran bzr-buildpackage, pbuilder-dist and dpkg,
to try out the modified control panel, which does function with
tooltips, although clearly not rigorous testing.

I will probably need a bit of help (or pointers to docs) running the
tests and with correctly proposing branch against project. My nick is
grunthus on #ubuntu-motu, so I'm happy to ask for help there or perhaps
via email from you, so long as you have time!

Thanks again,
Chris