No tooltip for disconnect button

[Danielle Foré]

Especially for an action that may be perceived as possibly having some negative affects, there should be a tooltip explaining a little better what this button does.

My suggestion would be something to the affect of "Disconnect this computer from Ubuntu One"

[Chris McGinlay (chrismcginlay)]

I'm interested in trying to implement a suitable tooltip for this, and probably for the 'Account', ' Cloud Folders' and 'Devices' buttons too.
I have been looking in data/dashboard.ui which implements tooltips for 'Edit' and 'Buy more storage...', also been looking in ubuntuone/controlpanel/gtk/widgets.py.

There is no existing mechanism in widgets.py to implement tooltip, at least not one that I was able to notice. What would be the preferred mechanism to implement this, consistent with other Python applications?

I have the latest source code branched from bazaar and can successfully build/test with pbuilder.

[Chris McGinlay (chrismcginlay)]

Something as simple as

tooltips = GtkTooltips()
tooltips.set_tip(widget, text)

?

[Chris McGinlay (chrismcginlay)]

Implementing this will require modification to the list of function arguments for _update_status() function in controlpanel/gtk/gui.py. Basically inserting a tooltip=None argument after the callback argument.

[Natalia Bidart (nataliabidart)]

Chris,

Hello! Thanks for your contribution.
Question: why are you proposing a branch against the source package? I think it would be best to propose it against the project, so we can add it to the source and the release with the rest of the code.

Also, we require tests to be provided along with the patch, you can check ubuntuone/controlpanel/gtk/tests to do so.

Once you get your branch ready, to propose the branch you will need to sign the Canonical contributor's agreement located at http://www.canonical.com/contributors

If you sign it, please send it to <email address hidden> and to myself.

Thanks!

[Chris McGinlay (chrismcginlay)]

On Tue, 2011-02-15 at 18:26 +0000, Naty Bidart wrote:
> Chris,
>
> Hello! Thanks for your contribution.
> Question: why are you proposing a branch against the source package? I think it would be best to propose it against the project, so we can add it to the source and the release with the rest of the code.
>
> Also, we require tests to be provided along with the patch, you can
> check ubuntuone/controlpanel/gtk/tests to do so.
>
> Once you get your branch ready, to propose the branch you will need to
> sign the Canonical contributor's agreement located at
> http://www.canonical.com/contributors
>
> If you sign it, please send it to <email address hidden> and to
> myself.
>
> Thanks!
>

Hello Naty and thank you for the instructions. I have signed
contributor's agreement.

In answer to your question about proposing branch against source -vs-
project: this is only the second bug that I have attempted to work on,
so actually I don't know how to propose against project instead of
source. These are the steps I took to push my branch back to the server:

debcommit
bzr push lp:~chris-asce....tware.org.uk/ub...ne-control-panel-fix-715820
bzr lp-open

I should add that I first ran bzr-buildpackage, pbuilder-dist and dpkg,
to try out the modified control panel, which does function with
tooltips, although clearly not rigorous testing.

I will probably need a bit of help (or pointers to docs) running the
tests and with correctly proposing branch against project. My nick is
grunthus on #ubuntu-motu, so I'm happy to ask for help there or perhaps
via email from you, so long as you have time!

Thanks again,
Chris

[Natalia Bidart (nataliabidart)]

Hi Chris!

Thanks for taking the time to help us. My nick is nessita and you can ping me in #ubuntuone at freenode. To propose a branch against the project, you should:

* branch the project's trunk

bzr branch lp:ubuntuone-control-panel <a branch name>

* code tests, run tests with:
 - the whole suite: ./run-tests
 - a specific test or test suite or test file: u1trial [-t <test pattern regex>] <test filename>

For example, to run all the tests for the UI:

u1trial ubuntuone/controlpanel/gtk/tests/test_gui.py

(you can find several examples of UI testing in that file)

* commit attaching the bug number to your commit:

bzr ci --fixes=lp:<bug number>

* push to the project, something like:

bzr push lp:~chris/ubuntuone-control-panel/<branch name>

Let me know if you need something else!

[Robert Roth (evfool)]

As the fix for this bug has been released with ubuntuone-control-panel 0.9.0, shouldn't the Papercut and the ubuntu task be set to Fix released too?

[Chris Wilson (notgary-deactivatedaccount)]

Good point :)