Comment 2 for bug 941111

Revision history for this message
Johannes Ernst (johannes-ernst) wrote :

I just did an clean install, and noticed this: all the external links in the pre-populated default content have this kind of HTML:

<a class="ext-link" href="http://trac.edgewall.org/">
<span class="icon">&nbsp;</span>The Trac project
</a>

which looks correct without the fix I'm proposing.

In the past, the following HTML would also render correctly (there's a bunch of that at http://infogrid.org/ )

<a class="ext-link" href="http://trac.edgewall.org/">
<span class="icon">The Trac project</span>
</a>

That is the HTML that doesn't render correctly with the "center center" instead of the "left" values. It seems that one use case was eliminated in changeset 7920 (thanks for finding that) without buying anything as far as I can tell. (I fail to see that enclosing a &nbsp; instead of the label is an improvement if it was done intentionally)