trac.css icon alignment

[Johannes Ernst]

It says in 0.11.7-1:

trac.css:
@media screen {
 a.ext-link .icon {
  background: url(../extlink.gif) center center no-repeat;
  padding-left: 12px;

I think this should read:

@media screen {
 a.ext-link .icon {
  background: url(../extlink.gif) left center no-repeat;
  padding-left: 12px;

otherwise the icon sits underneath the text, instead of to the left where room was created with the padding-left.

[Tim Hatch (timhatch)]

Upstream 0.11.7 has "center center", which was introduced in http://trac.edgewall.org/changeset/7920

The change isn't in trunk, however.

What browser are you using? If you can provide that, and a screenshot, I'd suggest reporting upstream.

[Johannes Ernst (johannes-ernst)]

I just did an clean install, and noticed this: all the external links in the pre-populated default content have this kind of HTML:

<a class="ext-link" href="http://trac.edgewall.org/">
<span class="icon">&nbsp;</span>The Trac project
</a>

which looks correct without the fix I'm proposing.

In the past, the following HTML would also render correctly (there's a bunch of that at http://infogrid.org/ )

<a class="ext-link" href="http://trac.edgewall.org/">
<span class="icon">The Trac project</span>
</a>

That is the HTML that doesn't render correctly with the "center center" instead of the "left" values. It seems that one use case was eliminated in changeset 7920 (thanks for finding that) without buying anything as far as I can tell. (I fail to see that enclosing a &nbsp; instead of the label is an improvement if it was done intentionally)