Comment 5 for bug 690927

Revision history for this message
Bhavani Shankar (bhavi) wrote : Re: Please merge tpb 0.6.4-6 (universe) from Debian unstable (main)

hello Mahyuddin,

this looks a bit better than the former but still a few things that caught my eye are

1. its LP: #690927 instead of LP: #12345 in the LP closure directive

2. Please make the changelog more verbose i.e when you mention for example debian/init.d you should mention what is its relevant change affected in ubuntu so that its that much easier to track changes from previous merged version

3. Please update your Maintainer field to Ubuntu Developers <email address hidden> instead of the old address (Hint: you can use update-maintainer from ubuntu-dev-tools for the same)

4. Your changelog contains whitespaces such as

@@ -186,13 +269,13 @@ tpb (0.3.0-1) unstable; urgency=low
   * new upstream version

  -- Markus Braun <email address hidden> Tue, 22 Jul 2002 15:30:32 +0200
-
+
 tpb (0.2.2-1) unstable; urgency=low

   * new upstream version

  -- Markus Braun <email address hidden> Mon, 8 Jul 2002 23:42:07 +0200
-
+
 tpb (0.2.1-1) unstable; urgency=low

   * Initial Release.

Please delete/correct them

5. As Evan said, I too see unnecessary deletion of commented out lines in debian/rules which can be avoided I think

Unsubscribing sponsors for now. Please resubscribe when the above points are taken care of

Regards