Comment 3 for bug 690927

Revision history for this message
Evan Broder (broder) wrote : Re: Please merge tpb 0.6.4-6 (universe) from Debian unstable (main)

Your changelog entry needs some work:

 - (small nit) Our standard form for LP closers is "(LP: #12345)" not "(Closes LP: #12345)"
 - Don't bother putting in the changelog that you're changing Maintainer/Original-Mainatainer. There's no need to document something that we will always do

But most importantly,

 - Please *do* actually list the Ubuntu changes that you're keeping. Merging is an opportunity to reconsider the changes that have been introduced in the past and confirm that they're still needed. Without this, it's difficult to track the ongoing Ubuntu diff from Debian.

And, in fact, I see several places where we could shrink the Ubuntu diff, which makes packages more maintainable in the long run. For instance, there are some commented-out lines which were unnecessarily removed from debian/rules, and a blank line that was removed from debian/tpb.preinst. Also, there are a bunch of changes in the .po files that seem superfluous.

We also discussed adding a new translation on #ubuntu-motu. Since I don't speak Indonesian and can't review your work in that area, I'm uncomfortable sponsoring that work myself. Since, as far as I know, we can only use Rosetta for packages in main, I think the best thing to do would be to submit this translation file to Debian's Indonesian l10n list. If they approve of it, then I wouldn't have a problem including the translation until Debian is unfrozen.

I'm going to go ahead and unsubscribe ubuntu-sponsors for now, but feel free to resubscribe them when you've updated the patch.