Comment 21 for bug 1895898

Revision history for this message
In , Rob Lemley (rjl-tbird) wrote :

Comment on attachment 9175384
Bug 1664607 - Don't try to load what's new page when built with updater disabled. r=mkmelin

[Approval Request Comment]
Regression caused by (bug #): 1563411
User impact if declined: This issue affects users that use various Linux distribution builds which are built with --disable-updater. The bug causes portions of the UI to not load resulting in an unusable interface. Users of "official" builds are not affected, and the fix would have no impact as it just wraps the what-new loading code in a conditional based on the value of MOZ_UPDATER which is set at build time automatically.
Testing completed (on c-c, etc.): I tested local a build of esr78 with this patch and --disable-updater to make sure it works as expected. When testing beta it would be nice if QA can test with an enterprise policy that disables updates. I don't expect any issues based on reading the code, but I may have missed something.
Risk to taking this patch (and alternatives if risky): I see very little risk in accepting this patch as the variable in question is always set to True on official builds and is not possible to change without a recompile.