Comment 12 for bug 1838590

Mario Limonciello (superm1) wrote :

Reviewing the package in your PPA I do have a few comments that should be addressed.

1) It looks like the standards version has been downgraded. If being modified at all it should be bumped up to match standards version in Eoan. This should also be mentioned in debian/changelog
2) VCS-Git and VCS-Browser URLs shouldn't be updated to upstream, packaging isn't maintained there.
3) in dptfxtract-helper I'm wondering why do you need to switch to dptfxtract-static? Is there new dependency?
4) debian/rules changes look unnecessary to me, but should be mentioned in changelog if needed.
5) I think you should be updating the packaging at https://git.launchpad.net/~canonical-hwe-team/+git/dptfxtract, no?