spice package for trusty contains a malformed patch
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
spice (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Trusty |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
=======
Impact: the package cannot be unpacked (patches do not apply)
Devel fix: the patch is dropped (applied upstream)
stable fix: fix the newline damage in the patch
test case: apt-get source spice (on a trusty machine)
regression potential: there should be none, however this should cause to be linked with lpthread (as it was meant to be to fix Debian bug #713681 since 2013). This *could* cause a regression. The alternative would be to simply drop the patch from the package, which should have no risk of regression at all. However, this change has been in wheezy-backports for a long time with no reported troubles.
=======
The source package for spice contains a malformed patch such that dpkg-source cannot extract it. This is fixed in later releases by removing the specific patch, but it would be useful for the Trusty package to be fixed.
$ apt-get source spice
Reading package lists... Done
Building dependency tree
Reading state information... Done
NOTICE: 'spice' packaging is maintained in the 'Git' version control system at:
git://anonscm.
Need to get 1,744 kB of source archives.
Get:1 http://
Get:2 http://
Get:3 http://
Fetched 1,744 kB in 0s (2,169 kB/s)
gpgv: Signature made Fri 08 Nov 2013 10:55:11 AM EST using RSA key ID 68C097BC
gpgv: Can't check signature: public key not found
dpkg-source: warning: failed to verify signature on ./spice_
dpkg-source: info: extracting spice in spice-0.12.4
dpkg-source: info: unpacking spice_0.
dpkg-source: info: unpacking spice_0.
dpkg-source: info: applying fix-tests-
dpkg-source: info: applying make-celt-
dpkg-source: info: applying link-server-
dpkg-source: info: fuzz is not allowed when applying patches
dpkg-source: info: if patch 'link-server-
dpkg-source: error: expected ^--- in line 2 of diff `spice-
Unpack command 'dpkg-source -x spice_0.
Check if the 'dpkg-dev' package is installed.
E: Child process failed
The issue is a simple missing newline in the patch itself.
Related branches
Changed in spice (Ubuntu): | |
status: | Incomplete → Triaged |
importance: | Undecided → High |
description: | updated |
description: | updated |
description: | updated |
tags: | added: ftbfs |
Changed in spice (Ubuntu): | |
status: | Triaged → Fix Released |
Thank you for taking the time to report this bug and helping to make Ubuntu better.
> This is fixed in later releases by removing the specific patch, but it would be useful for the Trusty package to be fixed.
Why? What is the impact to Trusty users?
To update a package in Trusty the procedure is documented at https:/ /wiki.ubuntu. com/StableRelea seUpdates# Procedure. I'm not yet convinced that the fix you proposed is justified under the SRU policy (documented elsewhere in that page) but if you think otherwise then you could proceed by beginning the documentation part of the procedure which is a requirement for doing the update anyway.