Comment 5 for bug 1450043

Thanks Brian. It's not in proposed yet, but the package itself extracts
fine.

On Fri, May 8, 2015 at 5:20 PM Brian Murray <email address hidden> wrote:

> Hello Gregory, or anyone else affected,
>
> Accepted spice into trusty-proposed. The package will build now and be
> available at
> https://launchpad.net/ubuntu/+source/spice/0.12.4-0nocelt2ubuntu1 in a
> few hours, and then in the -proposed repository.
>
> Please help us by testing this new package. See
> https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
> enable and use -proposed. Your feedback will aid us getting this update
> out to other Ubuntu users.
>
> If this package fixes the bug for you, please add a comment to this bug,
> mentioning the version of the package you tested, and change the tag
> from verification-needed to verification-done. If it does not fix the
> bug for you, please add a comment stating that, and change the tag to
> verification-failed. In either case, details of your testing will help
> us make a better decision.
>
> Further information regarding the verification process can be found at
> https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in
> advance!
>
> ** Changed in: spice (Ubuntu Trusty)
> Status: New => Fix Committed
>
> ** Tags added: verification-needed
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1450043
>
> Title:
> spice package for trusty contains a malformed patch
>
> Status in spice package in Ubuntu:
> Triaged
> Status in spice source package in Trusty:
> Fix Committed
>
> Bug description:
> ====================================
> Impact: the package cannot be unpacked (patches do not apply)
> Devel fix: the patch is dropped (applied upstream)
> stable fix: fix the newline damage in the patch
> test case: apt-get source spice (on a trusty machine)
> regression potential: there should be none, however this should cause to
> be linked with lpthread (as it was meant to be to fix Debian bug #713681
> since 2013). This *could* cause a regression. The alternative would be to
> simply drop the patch from the package, which should have no risk of
> regression at all. However, this change has been in wheezy-backports for a
> long time with no reported troubles.
> ====================================
>
> The source package for spice contains a malformed patch such that
> dpkg-source cannot extract it. This is fixed in later releases by
> removing the specific patch, but it would be useful for the Trusty
> package to be fixed.
>
> $ apt-get source spice
> Reading package lists... Done
> Building dependency tree
> Reading state information... Done
> NOTICE: 'spice' packaging is maintained in the 'Git' version control
> system at:
> git://anonscm.debian.org/collab-maint/spice.git
> Need to get 1,744 kB of source archives.
> Get:1 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice
> 0.12.4-0nocelt2 (dsc) [2,236 B]
> Get:2 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice
> 0.12.4-0nocelt2 (tar) [1,719 kB]
> Get:3 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice
> 0.12.4-0nocelt2 (diff) [23.0 kB]
> Fetched 1,744 kB in 0s (2,169 kB/s)
> gpgv: Signature made Fri 08 Nov 2013 10:55:11 AM EST using RSA key ID
> 68C097BC
> gpgv: Can't check signature: public key not found
> dpkg-source: warning: failed to verify signature on
> ./spice_0.12.4-0nocelt2.dsc
> dpkg-source: info: extracting spice in spice-0.12.4
> dpkg-source: info: unpacking spice_0.12.4.orig.tar.bz2
> dpkg-source: info: unpacking spice_0.12.4-0nocelt2.debian.tar.gz
> dpkg-source: info: applying fix-tests-warnings.patch
> dpkg-source: info: applying make-celt-to-be-optional.patch
> dpkg-source: info: applying link-server-test-with-libm-libpthread.patch
> dpkg-source: info: fuzz is not allowed when applying patches
> dpkg-source: info: if patch
> 'link-server-test-with-libm-libpthread.patch' is correctly applied by
> quilt, use 'quilt refresh' to update it
> dpkg-source: error: expected ^--- in line 2 of diff
> `spice-0.12.4/debian/patches/link-server-test-with-libm-libpthread.patch'
> Unpack command 'dpkg-source -x spice_0.12.4-0nocelt2.dsc' failed.
> Check if the 'dpkg-dev' package is installed.
> E: Child process failed
>
> The issue is a simple missing newline in the patch itself.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/ubuntu/+source/spice/+bug/1450043/+subscriptions
>