Activity log for bug #1450043

Date Who What changed Old value New value Message
2015-04-29 14:18:17 Gregory Boyce bug added bug
2015-04-30 07:22:38 Robie Basak bug added subscriber Robie Basak
2015-04-30 07:25:39 Robie Basak spice (Ubuntu): status New Incomplete
2015-04-30 19:40:23 Gregory Boyce attachment added spice-newlinefix.patch https://bugs.launchpad.net/ubuntu/+source/spice/+bug/1450043/+attachment/4388552/+files/spice-newlinefix.patch
2015-04-30 20:19:56 Ubuntu Foundations Team Bug Bot tags patch
2015-04-30 20:20:04 Ubuntu Foundations Team Bug Bot bug added subscriber Ubuntu Review Team
2015-05-04 15:44:45 Serge Hallyn spice (Ubuntu): status Incomplete Triaged
2015-05-04 15:44:48 Serge Hallyn spice (Ubuntu): importance Undecided High
2015-05-04 15:55:28 Serge Hallyn description The source package for spice contains a malformed patch such that dpkg-source cannot extract it. This is fixed in later releases by removing the specific patch, but it would be useful for the Trusty package to be fixed. $ apt-get source spice Reading package lists... Done Building dependency tree Reading state information... Done NOTICE: 'spice' packaging is maintained in the 'Git' version control system at: git://anonscm.debian.org/collab-maint/spice.git Need to get 1,744 kB of source archives. Get:1 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (dsc) [2,236 B] Get:2 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (tar) [1,719 kB] Get:3 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (diff) [23.0 kB] Fetched 1,744 kB in 0s (2,169 kB/s) gpgv: Signature made Fri 08 Nov 2013 10:55:11 AM EST using RSA key ID 68C097BC gpgv: Can't check signature: public key not found dpkg-source: warning: failed to verify signature on ./spice_0.12.4-0nocelt2.dsc dpkg-source: info: extracting spice in spice-0.12.4 dpkg-source: info: unpacking spice_0.12.4.orig.tar.bz2 dpkg-source: info: unpacking spice_0.12.4-0nocelt2.debian.tar.gz dpkg-source: info: applying fix-tests-warnings.patch dpkg-source: info: applying make-celt-to-be-optional.patch dpkg-source: info: applying link-server-test-with-libm-libpthread.patch dpkg-source: info: fuzz is not allowed when applying patches dpkg-source: info: if patch 'link-server-test-with-libm-libpthread.patch' is correctly applied by quilt, use 'quilt refresh' to update it dpkg-source: error: expected ^--- in line 2 of diff `spice-0.12.4/debian/patches/link-server-test-with-libm-libpthread.patch' Unpack command 'dpkg-source -x spice_0.12.4-0nocelt2.dsc' failed. Check if the 'dpkg-dev' package is installed. E: Child process failed The issue is a simple missing newline in the patch itself. ==================================== Impact: the package cannot be unpacked (patches do not apply) Devel fix: the patch is dropped (applied upstream) stable fix: fix the newline damage in the patch test case: apt-get source spice (on a trusty machine) regression potential: there should be none. However, I am concerned as to how this happened, as the package build should have failed with this whitespace damage. ==================================== The source package for spice contains a malformed patch such that dpkg-source cannot extract it. This is fixed in later releases by removing the specific patch, but it would be useful for the Trusty package to be fixed. $ apt-get source spice Reading package lists... Done Building dependency tree Reading state information... Done NOTICE: 'spice' packaging is maintained in the 'Git' version control system at: git://anonscm.debian.org/collab-maint/spice.git Need to get 1,744 kB of source archives. Get:1 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (dsc) [2,236 B] Get:2 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (tar) [1,719 kB] Get:3 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (diff) [23.0 kB] Fetched 1,744 kB in 0s (2,169 kB/s) gpgv: Signature made Fri 08 Nov 2013 10:55:11 AM EST using RSA key ID 68C097BC gpgv: Can't check signature: public key not found dpkg-source: warning: failed to verify signature on ./spice_0.12.4-0nocelt2.dsc dpkg-source: info: extracting spice in spice-0.12.4 dpkg-source: info: unpacking spice_0.12.4.orig.tar.bz2 dpkg-source: info: unpacking spice_0.12.4-0nocelt2.debian.tar.gz dpkg-source: info: applying fix-tests-warnings.patch dpkg-source: info: applying make-celt-to-be-optional.patch dpkg-source: info: applying link-server-test-with-libm-libpthread.patch dpkg-source: info: fuzz is not allowed when applying patches dpkg-source: info: if patch 'link-server-test-with-libm-libpthread.patch' is correctly applied by quilt, use 'quilt refresh' to update it dpkg-source: error: expected ^--- in line 2 of diff `spice-0.12.4/debian/patches/link-server-test-with-libm-libpthread.patch' Unpack command 'dpkg-source -x spice_0.12.4-0nocelt2.dsc' failed. Check if the 'dpkg-dev' package is installed. E: Child process failed The issue is a simple missing newline in the patch itself.
2015-05-04 16:11:35 Serge Hallyn description ==================================== Impact: the package cannot be unpacked (patches do not apply) Devel fix: the patch is dropped (applied upstream) stable fix: fix the newline damage in the patch test case: apt-get source spice (on a trusty machine) regression potential: there should be none. However, I am concerned as to how this happened, as the package build should have failed with this whitespace damage. ==================================== The source package for spice contains a malformed patch such that dpkg-source cannot extract it. This is fixed in later releases by removing the specific patch, but it would be useful for the Trusty package to be fixed. $ apt-get source spice Reading package lists... Done Building dependency tree Reading state information... Done NOTICE: 'spice' packaging is maintained in the 'Git' version control system at: git://anonscm.debian.org/collab-maint/spice.git Need to get 1,744 kB of source archives. Get:1 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (dsc) [2,236 B] Get:2 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (tar) [1,719 kB] Get:3 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (diff) [23.0 kB] Fetched 1,744 kB in 0s (2,169 kB/s) gpgv: Signature made Fri 08 Nov 2013 10:55:11 AM EST using RSA key ID 68C097BC gpgv: Can't check signature: public key not found dpkg-source: warning: failed to verify signature on ./spice_0.12.4-0nocelt2.dsc dpkg-source: info: extracting spice in spice-0.12.4 dpkg-source: info: unpacking spice_0.12.4.orig.tar.bz2 dpkg-source: info: unpacking spice_0.12.4-0nocelt2.debian.tar.gz dpkg-source: info: applying fix-tests-warnings.patch dpkg-source: info: applying make-celt-to-be-optional.patch dpkg-source: info: applying link-server-test-with-libm-libpthread.patch dpkg-source: info: fuzz is not allowed when applying patches dpkg-source: info: if patch 'link-server-test-with-libm-libpthread.patch' is correctly applied by quilt, use 'quilt refresh' to update it dpkg-source: error: expected ^--- in line 2 of diff `spice-0.12.4/debian/patches/link-server-test-with-libm-libpthread.patch' Unpack command 'dpkg-source -x spice_0.12.4-0nocelt2.dsc' failed. Check if the 'dpkg-dev' package is installed. E: Child process failed The issue is a simple missing newline in the patch itself. ==================================== Impact: the package cannot be unpacked (patches do not apply) Devel fix: the patch is dropped (applied upstream) stable fix: fix the newline damage in the patch test case: apt-get source spice (on a trusty machine) regression potential: there should be none, however this should cause to be linked with lpthread (as it was meant to be to fix Debian bug #713681 since 2013). This *could* cause a regression. The alternative would be to simply drop the patch from the package, which should have no risk of regression at all. ==================================== The source package for spice contains a malformed patch such that dpkg-source cannot extract it. This is fixed in later releases by removing the specific patch, but it would be useful for the Trusty package to be fixed. $ apt-get source spice Reading package lists... Done Building dependency tree Reading state information... Done NOTICE: 'spice' packaging is maintained in the 'Git' version control system at: git://anonscm.debian.org/collab-maint/spice.git Need to get 1,744 kB of source archives. Get:1 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (dsc) [2,236 B] Get:2 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (tar) [1,719 kB] Get:3 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (diff) [23.0 kB] Fetched 1,744 kB in 0s (2,169 kB/s) gpgv: Signature made Fri 08 Nov 2013 10:55:11 AM EST using RSA key ID 68C097BC gpgv: Can't check signature: public key not found dpkg-source: warning: failed to verify signature on ./spice_0.12.4-0nocelt2.dsc dpkg-source: info: extracting spice in spice-0.12.4 dpkg-source: info: unpacking spice_0.12.4.orig.tar.bz2 dpkg-source: info: unpacking spice_0.12.4-0nocelt2.debian.tar.gz dpkg-source: info: applying fix-tests-warnings.patch dpkg-source: info: applying make-celt-to-be-optional.patch dpkg-source: info: applying link-server-test-with-libm-libpthread.patch dpkg-source: info: fuzz is not allowed when applying patches dpkg-source: info: if patch 'link-server-test-with-libm-libpthread.patch' is correctly applied by quilt, use 'quilt refresh' to update it dpkg-source: error: expected ^--- in line 2 of diff `spice-0.12.4/debian/patches/link-server-test-with-libm-libpthread.patch' Unpack command 'dpkg-source -x spice_0.12.4-0nocelt2.dsc' failed. Check if the 'dpkg-dev' package is installed. E: Child process failed The issue is a simple missing newline in the patch itself.
2015-05-04 16:14:18 Serge Hallyn description ==================================== Impact: the package cannot be unpacked (patches do not apply) Devel fix: the patch is dropped (applied upstream) stable fix: fix the newline damage in the patch test case: apt-get source spice (on a trusty machine) regression potential: there should be none, however this should cause to be linked with lpthread (as it was meant to be to fix Debian bug #713681 since 2013). This *could* cause a regression. The alternative would be to simply drop the patch from the package, which should have no risk of regression at all. ==================================== The source package for spice contains a malformed patch such that dpkg-source cannot extract it. This is fixed in later releases by removing the specific patch, but it would be useful for the Trusty package to be fixed. $ apt-get source spice Reading package lists... Done Building dependency tree Reading state information... Done NOTICE: 'spice' packaging is maintained in the 'Git' version control system at: git://anonscm.debian.org/collab-maint/spice.git Need to get 1,744 kB of source archives. Get:1 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (dsc) [2,236 B] Get:2 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (tar) [1,719 kB] Get:3 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (diff) [23.0 kB] Fetched 1,744 kB in 0s (2,169 kB/s) gpgv: Signature made Fri 08 Nov 2013 10:55:11 AM EST using RSA key ID 68C097BC gpgv: Can't check signature: public key not found dpkg-source: warning: failed to verify signature on ./spice_0.12.4-0nocelt2.dsc dpkg-source: info: extracting spice in spice-0.12.4 dpkg-source: info: unpacking spice_0.12.4.orig.tar.bz2 dpkg-source: info: unpacking spice_0.12.4-0nocelt2.debian.tar.gz dpkg-source: info: applying fix-tests-warnings.patch dpkg-source: info: applying make-celt-to-be-optional.patch dpkg-source: info: applying link-server-test-with-libm-libpthread.patch dpkg-source: info: fuzz is not allowed when applying patches dpkg-source: info: if patch 'link-server-test-with-libm-libpthread.patch' is correctly applied by quilt, use 'quilt refresh' to update it dpkg-source: error: expected ^--- in line 2 of diff `spice-0.12.4/debian/patches/link-server-test-with-libm-libpthread.patch' Unpack command 'dpkg-source -x spice_0.12.4-0nocelt2.dsc' failed. Check if the 'dpkg-dev' package is installed. E: Child process failed The issue is a simple missing newline in the patch itself. ==================================== Impact: the package cannot be unpacked (patches do not apply) Devel fix: the patch is dropped (applied upstream) stable fix: fix the newline damage in the patch test case: apt-get source spice (on a trusty machine) regression potential: there should be none, however this should cause to be linked with lpthread (as it was meant to be to fix Debian bug #713681 since 2013). This *could* cause a regression. The alternative would be to simply drop the patch from the package, which should have no risk of regression at all. However, this change has been in wheezy-backports for a long time with no reported troubles. ==================================== The source package for spice contains a malformed patch such that dpkg-source cannot extract it. This is fixed in later releases by removing the specific patch, but it would be useful for the Trusty package to be fixed. $ apt-get source spice Reading package lists... Done Building dependency tree Reading state information... Done NOTICE: 'spice' packaging is maintained in the 'Git' version control system at: git://anonscm.debian.org/collab-maint/spice.git Need to get 1,744 kB of source archives. Get:1 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (dsc) [2,236 B] Get:2 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (tar) [1,719 kB] Get:3 http://us.archive.ubuntu.com/ubuntu/ trusty/main spice 0.12.4-0nocelt2 (diff) [23.0 kB] Fetched 1,744 kB in 0s (2,169 kB/s) gpgv: Signature made Fri 08 Nov 2013 10:55:11 AM EST using RSA key ID 68C097BC gpgv: Can't check signature: public key not found dpkg-source: warning: failed to verify signature on ./spice_0.12.4-0nocelt2.dsc dpkg-source: info: extracting spice in spice-0.12.4 dpkg-source: info: unpacking spice_0.12.4.orig.tar.bz2 dpkg-source: info: unpacking spice_0.12.4-0nocelt2.debian.tar.gz dpkg-source: info: applying fix-tests-warnings.patch dpkg-source: info: applying make-celt-to-be-optional.patch dpkg-source: info: applying link-server-test-with-libm-libpthread.patch dpkg-source: info: fuzz is not allowed when applying patches dpkg-source: info: if patch 'link-server-test-with-libm-libpthread.patch' is correctly applied by quilt, use 'quilt refresh' to update it dpkg-source: error: expected ^--- in line 2 of diff `spice-0.12.4/debian/patches/link-server-test-with-libm-libpthread.patch' Unpack command 'dpkg-source -x spice_0.12.4-0nocelt2.dsc' failed. Check if the 'dpkg-dev' package is installed. E: Child process failed The issue is a simple missing newline in the patch itself.
2015-05-04 19:01:02 Matthias Klose tags patch ftbfs patch
2015-05-06 20:49:44 Chris J Arges nominated for series Ubuntu Trusty
2015-05-06 20:49:44 Chris J Arges bug task added spice (Ubuntu Trusty)
2015-05-08 21:12:36 Brian Murray spice (Ubuntu Trusty): status New Fix Committed
2015-05-08 21:12:38 Brian Murray bug added subscriber Ubuntu Stable Release Updates Team
2015-05-08 21:12:42 Brian Murray bug added subscriber SRU Verification
2015-05-08 21:12:46 Brian Murray tags ftbfs patch ftbfs patch verification-needed
2015-05-19 20:56:50 Felipe Reyes tags ftbfs patch verification-needed ftbfs patch verification-done
2015-05-21 22:58:00 Launchpad Janitor spice (Ubuntu Trusty): status Fix Committed Fix Released
2015-05-21 22:58:04 Brian Murray removed subscriber Ubuntu Stable Release Updates Team
2015-05-27 04:06:56 Launchpad Janitor branch linked lp:ubuntu/trusty-proposed/spice
2016-12-28 19:35:32 Laurent Bigonville spice (Ubuntu): status Triaged Fix Released