Comment 1 for bug 193945

This bug has been patched and merged upstream. I have a patch in my bzr repo and it should go into the next package update (hopefully ;o}

Thanks for the report,

Caleb

------------------------------------------------------------------------
r2849 | ssmalley | 2008-03-18 16:25:27 -0400 (Tue, 18 Mar 2008) | 33 lines

Author: Caleb Case
Email: <email address hidden>
Subject: policycoreutils semanage --proto --protocol inconsistent flags
Date: Tue, 18 Mar 2008 10:31:16 -0400

semanage --help indicates two conflicting ways of using the port protocol flag:

# semanage --help | grep proto
semanage port -{a|d|m} [-tr] [ -p protocol ] port | port_range
 -p, --proto Port protocol (tcp or udp)

That is --protocol and --proto.

The code paths are similarly conflicted with --protocol as the 'valid_option', but --proto as the flag actually used in getopt. This results in --protocol not being recognized:

# semanage port -t ftp_port_t -a --protocol tcp 12345
/usr/sbin/semanage: Options Error option --protocol not recognized

The port is not added in this case.

Using --proto instead results in a 'not valid for port objects' error, but the error is ignored and the port added:

# semanage port -t ftp_port_t -a --proto tcp 12345
--proto not valid for port objects

# semanage port -l | grep 12345
ftp_port_t tcp 12345, 21

The man pages for semanage are also inconsistent.

This patch resolves the inconsistency to use --proto.