Comment 1 for bug 1265754

Revision history for this message
Michael Terry (mterry) wrote :

Looks mostly good! But two things:

1) Package needs a team bug subscriber for whoever is looking after this package.

2) The dep8 test will never fail, because the test run is inside an if condition. You should change the following lines:

if plainbox self-test -u >/dev/null 2>&1; then
    echo "unit-tests: OK"
fi

to just (which works as intended because of the set -e):

plainbox self-test -u >/dev/null 2>&1
echo "unit-tests: OK"