[MIR] plainbox
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| plainbox (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
Following https:/
I have checked the following requirements:
Availability: the package is available in Debian and Ubuntu 14.04 and builds for every architecture
Rationale: The package is a new (upcoming) dependency for a package already in main, checkbox, hopefully offering better quality and features to implement the new internals of checkbox
Security: this is a new package with no known security issues. The package has extensive test suite, especially focusing on security sensitive components. A team of people supports the package so any discovered issues can be addressed quickly.
Quality assurance: the package is a library for implementing specific testing tools so it's not aimed at end users directly. In the future it will also be useful for a class of test developers and the upstream project is working on providing high quality documentation and good out-of-the box experience. Having said that this is not the current state and most developers will not find this package useful at this time. The package does not ask any defconf questions at all. The package is maintained in Debian and Ubuntu and has no outstanding bugs reported there. There are many bugs reported on the upstream project itself (specifically tagged with 'plainbox' tag as it shares code with lp:checkbox) but those are used for tracking development internally by the team. The package is used daily without major issues (from a development PPA). The package does not have any hardware dependent code. The package ships with both build-time test suite and autopackagetests to ensure stability for downstream users. The code coverage is extensive, averaging at 77% with most of the essential modules at 100% and some of the command line tools at lower (sometimes very low) coverage. The package uses debian/watch file to track new releases.
UI standards: this package provides one command line program, plainbox, and one internal support program plainbox-
Dependencies: This package depends, apart from python3, on three other binary packages, python3-
Standards compliance: The package is standards compliant. The only minor violation is the fact that some resources are installed in /usr/lib instead of /usr/share but the packages believe that the cost of maintaining a patch for that outweights the practical usefulness as those resources are only consumed by plainbox. The source packaging is straightforward, having basically two non-default behaviours: help2man is used to generate two manual pages and the main executable is relocated to the 'plainbox' package for easier discover-ability (so that apt-get install plainbox works and has the expected effect).
Maintenance: The package is maintained by the hardware certification team inside Canonical. It is a relatively simple tool so that should be more than sufficient. There is no Ubuntu/Debian delta now nor can the reporter imagine a reason why that should ever change.
Background information: the package description contains extensive description of the purpose and scope of the package. Appropriate, varying, descriptions are provided for every single binary package built. This package was not renamed recently, or at all.
| Michael Terry (mterry) wrote | #1 |
| Changed in plainbox (Ubuntu): | |
| status: | New → Incomplete |
| Zygmunt Krynicki (zyga) wrote | #2 |
| Changed in plainbox (Ubuntu): | |
| status: | Incomplete → New |
| Changed in plainbox (Ubuntu): | |
| status: | New → Fix Committed |
| Matthias Klose (doko) wrote | #3 |
| Changed in plainbox (Ubuntu): | |
| status: | Fix Committed → Fix Released |
| Zygmunt Krynicki (zyga) wrote | #4 |
| Martin Pitt (pitti) wrote | #5 |
Looks mostly good! But two things:
1) Package needs a team bug subscriber for whoever is looking after this package.
2) The dep8 test will never fail, because the test run is inside an if condition. You should change the following lines:
if plainbox self-test -u >/dev/null 2>&1; then
echo "unit-tests: OK"
fi
to just (which works as intended because of the set -e):
plainbox self-test -u >/dev/null 2>&1
echo "unit-tests: OK"