pcmanfm - does not trigger hal startup

Bug #556080 reported by Iain Buclaw
24
This bug affects 4 people
Affects Status Importance Assigned to Milestone
pcmanfm (Ubuntu)
Fix Released
High
Julien Lavergne

Bug Description

Since hal service daemon has been removed from system startup - pcmanfm should try to connect to hal, even if no service is running.

The current implementation in Lucid (and prior) is that it backs down too soon. What it should really be doing is continuing anyway, where it will error out if it truly can't get a hal service running.

Package: pcmanfm
Status: install ok installed
Priority: optional
Section: utils
Installed-Size: 2332
Maintainer: Ubuntu Developers <email address hidden>
Architecture: amd64
Version: 0.5.2+svn20091029-1ubuntu2
Depends: libc6 (>= 2.7), libcairo2 (>= 1.2.4), libdbus-1-3 (>= 1.0.2), libdbus-glib-1-2 (>= 0.78), libgamin0 | libfam0, libglib2.0-0 (>= 2.23.5), libgtk2.0-0 (>= 2.18.0), libhal-storage1 (>= 0.5.8.1), libhal1 (>= 0.5.8.1), libpango1.0-0 (>= 1.18.0), libstartup-notification0 (>= 0.10), libx11-6 (>= 0), gamin, shared-mime-info, desktop-file-utils, dbus, hal

Tags: patch lucid

Related branches

Revision history for this message
Iain Buclaw (iainb) wrote :
Iain Buclaw (iainb)
tags: removed: amd64 apport-bug
Revision history for this message
Iain Buclaw (iainb) wrote :

problem found to be in pcmanfm itself.

summary: - HAL - service init scripts missing from package
+ pcmanfm - does not trigger hal startup
affects: hal (Ubuntu) → pcmanfm (Ubuntu)
Iain Buclaw (iainb)
description: updated
description: updated
Revision history for this message
Iain Buclaw (iainb) wrote :

Attaching patch.

tags: added: patch
Revision history for this message
Iain Buclaw (iainb) wrote :

Alternatively, see no harm in just removing the check altogether, as if hal is not present, it *should* error out later when calling libhal_device_property_watch_all().

Regards

Julien Lavergne (gilir)
Changed in pcmanfm (Ubuntu):
status: New → In Progress
importance: Undecided → High
assignee: nobody → Julien Lavergne (gilir)
Revision history for this message
Julien Lavergne (gilir) wrote :

Thanks Iain for the patch.

A package including the fix will be available in my PPA : https://launchpad.net/~gilir/+archive/updates

Please test if it fixes the bug.

Thanks.

Revision history for this message
Tomasz Rzepecki (nub) wrote :

i tried the pcmanfm package from the repo, both versions, and neither seems to fix the issue (the devices are still not shown in places menu).

Revision history for this message
Julien Lavergne (gilir) wrote :

Oops, I made a mistake in the package. the ~ppa2 version should include the fix.

Revision history for this message
Tomasz Rzepecki (nub) wrote :

ok - the issue i noticed seems to have been fixed. most devices do show up in places menu. this does not seem to be the case for an usb drive i plugged in (which does show up in nautilus...), but that's probably a different bug.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pcmanfm - 0.5.2+svn20091029-1ubuntu3

---------------
pcmanfm (0.5.2+svn20091029-1ubuntu3) lucid; urgency=low

  * debian/patch/01-hal-init.dpatch:
   - Try to connect to hal, even if no service is running. Thanks Iain Bucław
     for the patch. (LP: #556080)
 -- Julien Lavergne <email address hidden> Sun, 18 Apr 2010 01:45:21 +0200

Changed in pcmanfm (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Djo (tueurdecorneilles) wrote :

I use pcmanfm (0.5.2+svn20091029-1ubuntu3) lucid from the official repo and I still need to write 'hald --daemon=yes' to /etc/rc.local to make automounting fonctional. Before that, devices were sometimes detected but when I tried to mount the device, "The folder does not exist" error messahe was displayed.

Revision history for this message
Iain Buclaw (iainb) wrote :

@Djo, what type of session are you running? And what applications autostart when you login?

Regards

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.