The uploaded SRU includes the following new file, which is not covered by the MRE and not explained in the changelog:
--- mythtv-0.25.0+fixes.20120410.1f5962a/debian/30-mythtv-sysctl.conf 1970-01-01 00:00:00.000000000 +0000
+++ mythtv-0.25.2+fixes.20120802.46cab93/debian/30-mythtv-sysctl.conf 2012-08-01 13:59:24.000000000 +0000
@@ -0,0 +1,5 @@
+# Increase the max allowed socket buffer for MythTV.
+# See http://code.mythtv.org/trac/ticket/10414 for more context
+# Doesn't actually increase the default socket buffer so it shouldn't affect
+# any other applications.
+net.core.rmem_max=1048576
Please explain why this is appropriate to include in an SRU (preferably with a reupload that provides a link to an Ubuntu bug in the changelog).
--- mythtv-0.25.0+fixes.20120410.1f5962a/debian/mythtv-database.postinst 2011-12-08 16:10:15.000000000 +0000
+++ mythtv-0.25.2+fixes.20120802.46cab93/debian/mythtv-database.postinst 2012-08-01 13:59:24.000000000 +0000
@@ -112,7 +112,7 @@
#and mysql binding checks
if [ -f "${MYSQLCONFIG}" ]; then
db_get mythtv/public_bind
- if [ $RET = true ]; then
+ if [ -n "$RET" ] && [ $RET = true ]; then NEWIP=`ifconfig | grep "inet addr:" | grep --invert-match 127.0.0.1 | sed ' s/inet addr://g; s/^[ \t]*//;s/[ \t]*$//; q;' | awk '{print $1}'`
sed -i -e 's/^#bind/bind/' ${MYSQLCONFIG}
else
This would have been more succinctly written
if [ "$RET" = true ]; then
> + * Update apport hook for python3 (LP: #1013171)
python3 is not used for apport in 12.04, and there's no reason to include such a change in an SRU - this is all risk and no benefit. Please drop this change.
The rest of the changes to debian/ seem fine, and the changes outside of debian/ are of course covered by the MRE. Please reupload with the aforementioned changes. Rejecting from the queue for now.
The uploaded SRU includes the following new file, which is not covered by the MRE and not explained in the changelog:
--- mythtv- 0.25.0+ fixes.20120410. 1f5962a/ debian/ 30-mythtv- sysctl. conf 1970-01-01 00:00:00.000000000 +0000 0.25.2+ fixes.20120802. 46cab93/ debian/ 30-mythtv- sysctl. conf 2012-08-01 13:59:24.000000000 +0000 code.mythtv. org/trac/ ticket/ 10414 for more context rmem_max= 1048576
+++ mythtv-
@@ -0,0 +1,5 @@
+# Increase the max allowed socket buffer for MythTV.
+# See http://
+# Doesn't actually increase the default socket buffer so it shouldn't affect
+# any other applications.
+net.core.
Please explain why this is appropriate to include in an SRU (preferably with a reupload that provides a link to an Ubuntu bug in the changelog).
--- mythtv- 0.25.0+ fixes.20120410. 1f5962a/ debian/ mythtv- database. postinst 2011-12-08 16:10:15.000000000 +0000 0.25.2+ fixes.20120802. 46cab93/ debian/ mythtv- database. postinst 2012-08-01 13:59:24.000000000 +0000
NEWIP= `ifconfig | grep "inet addr:" | grep --invert-match 127.0.0.1 | sed ' s/inet addr://g; s/^[ \t]*//;s/[ \t]*$//; q;' | awk '{print $1}'`
+++ mythtv-
@@ -112,7 +112,7 @@
#and mysql binding checks
if [ -f "${MYSQLCONFIG}" ]; then
db_get mythtv/public_bind
- if [ $RET = true ]; then
+ if [ -n "$RET" ] && [ $RET = true ]; then
sed -i -e 's/^#bind/bind/' ${MYSQLCONFIG}
else
This would have been more succinctly written
if [ "$RET" = true ]; then
> + * Update apport hook for python3 (LP: #1013171)
python3 is not used for apport in 12.04, and there's no reason to include such a change in an SRU - this is all risk and no benefit. Please drop this change.
The rest of the changes to debian/ seem fine, and the changes outside of debian/ are of course covered by the MRE. Please reupload with the aforementioned changes. Rejecting from the queue for now.