Comment 167 for bug 1563110

Revision history for this message
In , pierre-louis.bossart (pierre-louis.bossart-linux-kernel-bugs) wrote :

Nice work Takashi.
I see that you took the machine driver from my experimental/codecs branch, which controls the mclk as in all previous cases.
From email discussions with Simon Ho, it appears problematic, Simon wanted to control the clock from his codec driver based on the codec state, not the stream state and that's the reason why I recently submitted the patch to create an "mclk" alias. This disconnect is likely the reason for the quality issue.
While I think of it, the codec driver may need to set the mclk rate as well, if we want to reuse the machine driver on baytrail platforms then it has to be explicitly configured to 19.2MHz (default is 25).