Extra debug printk in route.c "rt_may_expire"

Bug #960340 reported by Tobin Davis on 2012-03-20
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linux-armadaxp (Ubuntu)
High
Ike Panhc

Bug Description

The patchset from Marvell included a debugging printk that should be removed prior to release. THis printk spams syslog with "[151184.452453] rt_may_expire:" messages.

This is the patch that created it:

diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 94cdbc5..59c8467 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
.
.
.
@@ -687,10 +700,18 @@ static int rt_may_expire(struct rtable *rth, unsigned long tmo1, unsigned long t
 {
        unsigned long age;
        int ret = 0;
-
+ printk("%s:\n", __func__);
        if (atomic_read(&rth->dst.__refcnt))
                goto out;

+#if defined(CONFIG_MV_ETH_NFP_FIB_LEARN)
+ if (rth->nfp) {
+ if (nfp_hook_fib_rule_age(AF_INET,(u8 *)(&rth->rt_src), (u8 *)(&rth->rt_dst),
+ rth->rt_iif, rth->dst.dev->ifindex))
+ rth->dst.lastuse = jiffies;
+ }
+#endif /* CONFIG_MV_ETH_NFP_FIB_LEARN */
+
        age = jiffies - rth->dst.lastuse;
        if ((age <= tmo1 && !rt_fast_clean(rth)) ||
            (age <= tmo2 && rt_valuable(rth)))
.
.
.

(there is more to the patch, but the printk line above should be removed).

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: linux-armadaxp 3.2.0.1600.1
ProcVersionSignature: User Name 3.2.0-1600.3-armadaxp 3.2.9
Uname: Linux 3.2.0-1600-armadaxp armv7l
ApportVersion: 1.94.1-0ubuntu2
Architecture: armhf
Date: Tue Mar 20 08:56:55 2012
ProcEnviron:
 TERM=screen-bce
 SHELL=/bin/bash
 LANG=en_US.UTF-8
 LANGUAGE=en_US:
SourcePackage: linux-meta-armadaxp
UpgradeStatus: No upgrade log present (probably fresh install)

Tobin Davis (gruemaster) wrote :
tags: added: bot-stop-nagging
affects: linux-meta-armadaxp (Ubuntu) → linux-armadaxp (Ubuntu)
Changed in linux-armadaxp (Ubuntu):
importance: Undecided → High
assignee: nobody → Bryan Wu (cooloney)
Changed in eilt:
importance: Undecided → High
Tobin Davis (gruemaster) on 2012-03-22
no longer affects: eilt
Ike Panhc (ikepanhc) on 2012-03-27
Changed in linux-armadaxp (Ubuntu):
assignee: Bryan Wu (cooloney) → Ike Panhc (ikepanhc)
status: New → In Progress
Ike Panhc (ikepanhc) wrote :

A simple patch can fix the spam message.

Changed in linux-armadaxp (Ubuntu):
status: In Progress → Fix Committed
tags: added: patch
Launchpad Janitor (janitor) wrote :
Download full text (5.3 KiB)

This bug was fixed in the package linux-armadaxp - 3.2.0-1602.5

---------------
linux-armadaxp (3.2.0-1602.5) precise; urgency=low

  [ Ike Panhc ]

  * Remove unnecessary debug message
    - LP: #960340
  * Rebase onto Ubuntu-3.2.0-22.35

  [ Stefan Bader ]

  * d-i: Fix module name for dm-raid45
    - LP: #969248

  [ Upstream Kernel Changes ]

  * ARM: 7178/1: fault.c: Port OOM changes into do_page_fault
    - LP: #951043

  [ Ubuntu: 3.2.0-22.35 ]

  * Revert "SAUCE: hotkey quirks for various Zeptro Znote and Fujitsu Amilo
    laptops"
  * SAUCE: (no-up) elide some ioctl warnings which are known benign
    - LP: #972355
  * SAUCE (no-up) Provide a param for allowing the BIOS to handle changing
    the brightness on AC/battery status changes.
    - LP: #949311
  * SAUCE (drop after 3.4) Quirk for enabling backlight hotkeys on Samsung
    N150P
    - LP: #875893
  * SAUCE: PCI: Allow pcie_aspm=force to work even when FADT indicates it
    is unsupported
    - LP: #962038
  * SAUCE: (drop after 3.5) drm/i915: reinstate GM45 TV detection fix
    - LP: #638939
  * SAUCE: SECCOMP: audit: always report seccomp violations
  * SAUCE: SECCOMP: adjust prctl constant
  * [Config] Enable CONFIG_USBIP_CORE=m
    - LP: #900384
  * Rebase to v3.2.14
  * [Config] Updateconfigs after rebase to v3.2.14
  * d-i: Fix module name for dm-raid45
    - LP: #969248
  * SAUCE: remove __initdata from vesafb_fix
    - LP: #969309
  * Revert "sched: tg->se->load should be initialised to tg->shares"
  * toshiba_acpi: make one-bit bitfields unsigned
    - LP: #810015
  * ACPI: EC: Add ec_get_handle()
    - LP: #810015
  * toshiba_acpi: Support alternate hotkey interfaces
    - LP: #810015
  * toshiba_acpi: Support additional hotkey scancodes
    - LP: #810015
  * toshiba_acpi: Refuse to load on machines with buggy INFO
    implementations
    - LP: #810015
  * ata_piix: Add Toshiba Satellite Pro A120 to the quirks list due to
    broken suspend functionality.
    - LP: #886850
  * sweep the floors and convert some .get_drvinfo routines to strlcpy
    - LP: #921793
  * be2net: init (vf)_if_handle/vf_pmac_id to handle failure scenarios
    - LP: #921793
  * be2net: stop checking the UE registers after an EEH error
    - LP: #921793
  * be2net: don't log more than one error on detecting EEH/UE errors
    - LP: #921793
  * be2net: stop issuing FW cmds if any cmd times out
    - LP: #921793
  * be2net: Fix TX queue create for Lancer
    - LP: #921793
  * be2net: add register dump feature for Lancer
    - LP: #921793
  * be2net: Add EEPROM dump feature for Lancer
    - LP: #921793
  * be2net: Fix VLAN promiscous mode for Lancer
    - LP: #921793
  * be2net: Use V1 query link status command for lancer
    - LP: #921793
  * be2net: Move to new SR-IOV implementation in Lancer
    - LP: #921793
  * be2net: Fix error recovery paths
    - LP: #921793
  * be2net: Add error handling for Lancer
    - LP: #921793
  * be2net: Use new hash key
    - LP: #921793
  * be2net: Fix non utilization of RX queues
    - LP: #921793
  * be2net: netpoll support
    - LP: #921793
  * be2net: update some counters to display via ethtool
    - LP: #921793
  * be2net: workaround to fix a bug in BE
    ...

Read more...

Changed in linux-armadaxp (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers