Extra debug printk in route.c "rt_may_expire"
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux-armadaxp (Ubuntu) |
Fix Released
|
High
|
Ike Panhc |
Bug Description
The patchset from Marvell included a debugging printk that should be removed prior to release. THis printk spams syslog with "[151184.452453] rt_may_expire:" messages.
This is the patch that created it:
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index 94cdbc5..59c8467 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
.
.
.
@@ -687,10 +700,18 @@ static int rt_may_
{
unsigned long age;
int ret = 0;
-
+ printk("%s:\n", __func__);
if (atomic_
+#if defined(
+ if (rth->nfp) {
+ if (nfp_hook_
+ rth->rt_iif, rth->dst.
+ rth->dst.lastuse = jiffies;
+ }
+#endif /* CONFIG_
+
age = jiffies - rth->dst.lastuse;
if ((age <= tmo1 && !rt_fast_
(age <= tmo2 && rt_valuable(rth)))
.
.
.
(there is more to the patch, but the printk line above should be removed).
ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: linux-armadaxp 3.2.0.1600.1
ProcVersionSign
Uname: Linux 3.2.0-1600-armadaxp armv7l
ApportVersion: 1.94.1-0ubuntu2
Architecture: armhf
Date: Tue Mar 20 08:56:55 2012
ProcEnviron:
TERM=screen-bce
SHELL=/bin/bash
LANG=en_US.UTF-8
LANGUAGE=en_US:
SourcePackage: linux-meta-armadaxp
UpgradeStatus: No upgrade log present (probably fresh install)
Related branches
no longer affects: | eilt |
Changed in linux-armadaxp (Ubuntu): | |
assignee: | Bryan Wu (cooloney) → Ike Panhc (ikepanhc) |
status: | New → In Progress |
tags: | added: patch |
A simple patch can fix the spam message.