Comment 2 for bug 516762

Revision history for this message
Fabrice Coutadeur (fabricesp) wrote :

Hi,

Some comments on the packages:
- Why do you install lgpl.txt as doc? The LGPL license should be already on the disk, so no need to install an additional license text.
- the manpages file is not of any use, as you have hdhomerun-config.manpages
- Are you the upstream of this software (as stated in the copyright file)? As stated in the README file, the copyright owner is Silicondust USA Inc., and that should be reflected in the copyright file. Also, you could change the format of the copyright file to DEP5, to make easier to 'parse'. Also, you sjould keep Mario as one of the copyright owner of the packaging, and add yourself, with correct dates
- why changing the versioning ? As upstream changed their policy (from 0.YYYYMMDD to YYYYMMDD) ?

Thanks,
Fabrice
- Why do you create a lib package? Is the lib used in any other packages?