[sponsor request] libhdhomerun update

Bug #516762 reported by rhpot1991 on 2010-02-03
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
libhdhomerun (Ubuntu)
Undecided
Unassigned

Bug Description

Binary package hint: hdhomerun-config

Current package is far out of date, I have packaged up the latest version available here: http://www.silicondust.com/downloads/linux

Also worth noting, I have added additional packages needed for the GUI which is awaiting approval in REVU.

Bzr branch available here: https://code.launchpad.net/~rhpot1991/libhdhomerun/trunk

Related branches

rhpot1991 (rhpot1991) on 2010-02-03
description: updated
rhpot1991 (rhpot1991) wrote :

I would also like to note that the dpatch in this branch has been submitted to upstream.

Changed in libhdhomerun (Ubuntu):
assignee: nobody → Fabrice Coutadeur (fabricesp)
status: New → In Progress
Fabrice Coutadeur (fabricesp) wrote :

Hi,

Some comments on the packages:
- Why do you install lgpl.txt as doc? The LGPL license should be already on the disk, so no need to install an additional license text.
- the manpages file is not of any use, as you have hdhomerun-config.manpages
- Are you the upstream of this software (as stated in the copyright file)? As stated in the README file, the copyright owner is Silicondust USA Inc., and that should be reflected in the copyright file. Also, you could change the format of the copyright file to DEP5, to make easier to 'parse'. Also, you sjould keep Mario as one of the copyright owner of the packaging, and add yourself, with correct dates
- why changing the versioning ? As upstream changed their policy (from 0.YYYYMMDD to YYYYMMDD) ?

Thanks,
Fabrice
- Why do you create a lib package? Is the lib used in any other packages?

Changed in libhdhomerun (Ubuntu):
assignee: Fabrice Coutadeur (fabricesp) → nobody
status: In Progress → Incomplete
rhpot1991 (rhpot1991) wrote :

I updated the branch, check revision 23.

1. Came from the original package, removed.
2. Removed this.
3. Nope, I'm not upstream, mistakenly copied this from a package where I am upstream. I pulled the old copyright information and updated it, should be good now.
4. I discussed this with Mario, upstream has always used YYYYMMDD. I verified that they have no plans of chaning this. Matching version numbers helped with the get-orig-source work as well.
5. Yes, the lib package is used by hdhomerun-config-gui (currently in revu: http://revu.ubuntuwire.com/p/hdhomerun-config-gui). The lib-dev package is a build depends for hdhomerun-config-gui.

Changed in libhdhomerun (Ubuntu):
assignee: nobody → Fabrice Coutadeur (fabricesp)
status: Incomplete → In Progress
rhpot1991 (rhpot1991) wrote :

I just pushed up revision 24, fixing 2 lintian warning. The 1st adding a dpatch description and the 2nd adding debian/README.source.

Fabrice Coutadeur (fabricesp) wrote :

Hi,

Could you please attach the diff.gz file to the bug report? I'm having problems with bzr right now.

Thanks,
Fabrice

Changed in libhdhomerun (Ubuntu):
assignee: Fabrice Coutadeur (fabricesp) → John Baab (rhpot1991)
rhpot1991 (rhpot1991) wrote :

Sure, here you go.

Changed in libhdhomerun (Ubuntu):
assignee: John Baab (rhpot1991) → Fabrice Coutadeur (fabricesp)
Changed in libhdhomerun (Ubuntu):
assignee: Fabrice Coutadeur (fabricesp) → John Baab (rhpot1991)
Fabrice Coutadeur (fabricesp) wrote :

Hi,

Why the main binary package does not depends on the lib package? I would expect that.
Could you also add a DEP3 header (http://dep.debian.net/deps/dep3/) to the patch?

Thanks,
Fabrice

rhpot1991 (rhpot1991) wrote :

I added DEP-3 headers to the dpatch in revision 25. The main binary package does not require a depends on the lib package. Only the GUI (separate source, on REVU as mentioned in a previous comment) needs to depends on the lib package.

Changed in libhdhomerun (Ubuntu):
assignee: John Baab (rhpot1991) → Fabrice Coutadeur (fabricesp)
Fabrice Coutadeur (fabricesp) wrote :

Hi,

Thanks for your work and reactivity!

Before uploading your package, I updated the changelog to add the copyrgiht change, and the closure of this bug report. I also added some content to the description of -dev lib packages in debian/control.

Thanks again,

Fabrice

Changed in libhdhomerun (Ubuntu):
assignee: Fabrice Coutadeur (fabricesp) → nobody
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package libhdhomerun - 20100121-0ubuntu1

---------------
libhdhomerun (20100121-0ubuntu1) lucid; urgency=low

  * New upstream version (LP: #516762).
  * debian/changelog: Changed version numbering to match upstream.
  * Added debian/watch.
  * debian/control, new debian/ files:
    - Added package for libhdhomerun1.
    - Added package for libhdhomerun-dev.
  * debian/compat: Changed to newest version.
  * debian/rules:
    - Added get-orig-source, using uscan.
    - Rewritten to use Debhelper 7.
    - Adjusted LDFLAGS to match new upstream code.
  * debian/links: Added propper SONAME symlinks.
  * debian/patches: Added patch to fix missing SONAME data.
  * debian/copyright: added myself as copyright owner on the debian directory
 -- John Baab <email address hidden> Fri, 11 Dec 2009 17:42:38 -0500

Changed in libhdhomerun (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers