Comment 10 for bug 1017978

Revision history for this message
James Page (james-page) wrote :

Thanks for the review Jamie.

I think that it is still worth enabling this feature for ceph even if it is in Universe; I'm concerned that as soon as a user wants to try out/use the RADO gateway they are forced to either cut their own package or revert to using upstream packages (which although in itself is not bad it drives users away from the distro for supported components).

Also in time this may become more of a strategic feature as/when integration with keystone is delivered and the RADOS gateway can be integrated more tightly into Openstack.

I've review/resolved most of the compiler warnings and submitted back upstream; the only two I have left are the two in example/threaded.c - this is only an example and AFAICT the casting int <-> void* should be OK as it relates to both ends of the same pthread_create call and associated function.