So I reviewed the modified package and have a few comments:
The (final) package version must not have the the "+ppa1" suffix (for testing purposes that is of course okay, but not for uploading to the archive).
It must have the exact version like it should have in the archive, here just:
0.97-0ubuntu1
There is always a reference to the underlying LP bug needed in the changelog, like:
* New upstream release 0.97, now Ubuntu-specific package. (LP: #2052653)
lintian on the source package looks okay (just informational messages "I"):
$ lintian -EvIL -pedantic
I: ledmon source: adopted-extended-field (in section for source) XSBC-Original-Maintainer [debian/control:5]
I: ledmon source: older-debian-watch-file-standard 3 [debian/watch]
I: ledmon source: out-of-date-standards-version 4.5.0 (released 2020-01-20) (current is 4.6.2)
I: ledmon source: patch-not-forwarded-upstream [debian/patches/0002-To-cast-uint64_t-for-shift-to-prevent-Werror-shift-c.patch]
Since the currently existing ledmon package is available for multiple architectures:
$ rmadison --suite=noble ledmon
ledmon | 0.95-2build1 | noble/universe | source, amd64, arm64, armhf, ppc64el, riscv64, s390x
the PPA test build must be done on the same set of architectures (so not only amd64).
I've done that here: https://launchpad.net/~fheimes/+archive/ubuntu/lp2052653
And an install (from scratch) and upgrade (from the existing version 0.95-2build1) to the new one should also be tried (at least on one plaform, often amd64).
(Due to the lack of access to other systems I just did that quickly on s390x.)
The build logs look okay(-ish), no errors (but several warning).
These should be ideally addressed/reported upstream, to be fixed in future releases.
lintian on the binaries / DEBs looks also okay (only I and X):
$ lintian -EvIL -pedantic ../*.deb
I: ledmon: systemd-service-file-missing-documentation-key [lib/systemd/system/ledmon.service]
I: ledmon: systemd-service-file-missing-documentation-key [lib/systemd/system/ledmon.service]
I: ledmon: systemd-service-file-missing-documentation-key [lib/systemd/system/ledmon.service]
I: ledmon: systemd-service-file-missing-documentation-key [lib/systemd/system/ledmon.service]
I: ledmon: systemd-service-file-missing-documentation-key [lib/systemd/system/ledmon.service]
I: ledmon: systemd-service-file-missing-documentation-key [lib/systemd/system/ledmon.service]
X: ledmon: binary-file-built-without-LFS-support [usr/sbin/ledctl]
X: ledmon: binary-file-built-without-LFS-support [usr/sbin/ledmon]
I did the changes to the code mentioned above and can sponsor it (especially knowing that there is a plan in place to close the gap between Debian and Ubuntu again in future).
So I reviewed the modified package and have a few comments:
The (final) package version must not have the the "+ppa1" suffix (for testing purposes that is of course okay, but not for uploading to the archive).
It must have the exact version like it should have in the archive, here just:
0.97-0ubuntu1
There is always a reference to the underlying LP bug needed in the changelog, like:
* New upstream release 0.97, now Ubuntu-specific package. (LP: #2052653)
lintian on the source package looks okay (just informational messages "I"): extended- field (in section for source) XSBC-Original- Maintainer [debian/control:5] watch-file- standard 3 [debian/watch] date-standards- version 4.5.0 (released 2020-01-20) (current is 4.6.2) forwarded- upstream [debian/ patches/ 0002-To- cast-uint64_ t-for-shift- to-prevent- Werror- shift-c. patch]
$ lintian -EvIL -pedantic
I: ledmon source: adopted-
I: ledmon source: older-debian-
I: ledmon source: out-of-
I: ledmon source: patch-not-
Since the currently existing ledmon package is available for multiple architectures: /launchpad. net/~fheimes/ +archive/ ubuntu/ lp2052653
$ rmadison --suite=noble ledmon
ledmon | 0.95-2build1 | noble/universe | source, amd64, arm64, armhf, ppc64el, riscv64, s390x
the PPA test build must be done on the same set of architectures (so not only amd64).
I've done that here: https:/
And an install (from scratch) and upgrade (from the existing version 0.95-2build1) to the new one should also be tried (at least on one plaform, often amd64).
(Due to the lack of access to other systems I just did that quickly on s390x.)
The build logs look okay(-ish), no errors (but several warning).
These should be ideally addressed/reported upstream, to be fixed in future releases.
lintian on the binaries / DEBs looks also okay (only I and X): service- file-missing- documentation- key [lib/systemd/ system/ ledmon. service] service- file-missing- documentation- key [lib/systemd/ system/ ledmon. service] service- file-missing- documentation- key [lib/systemd/ system/ ledmon. service] service- file-missing- documentation- key [lib/systemd/ system/ ledmon. service] service- file-missing- documentation- key [lib/systemd/ system/ ledmon. service] service- file-missing- documentation- key [lib/systemd/ system/ ledmon. service] file-built- without- LFS-support [usr/sbin/ledctl] file-built- without- LFS-support [usr/sbin/ledmon]
$ lintian -EvIL -pedantic ../*.deb
I: ledmon: systemd-
I: ledmon: systemd-
I: ledmon: systemd-
I: ledmon: systemd-
I: ledmon: systemd-
I: ledmon: systemd-
X: ledmon: binary-
X: ledmon: binary-
I did the changes to the code mentioned above and can sponsor it (especially knowing that there is a plan in place to close the gap between Debian and Ubuntu again in future).
Upload done: /launchpad. net/ubuntu/ noble/+ queue?queue_ state=3& queue_text= ledmon
https:/