[GNR][SRF][CWF] VROC: Update ledmon package to version 0.97 for Noble

[Bun K Tan]

Version bump for ledmon to 0.97

Package PPA: https://launchpad.net/~hectorcao/+archive/ubuntu/lp2052653

[Other info]

As we want to have this new version in 24.04 (feature freeze is coming soon), we do the version bump directly on Ubuntu.
Once the package is accepted into 24.04, we will reach out to Debian to have this new version also available in Debian.

[Justification]

Update of the ledmon package to latest version v0.97
The current package version in Noble is 0.95, it was released 3 years ago (Jan 2021)
The version bump will allow to fix various bugs without significant risk
of regressions. In fact, the changelog from 0.95 to 0.97 shows that most
of the changes are about bugs fixing and small improvements without
new feature introduction nor big structural/design change.

Changelog v0.97
----

Enhancements

ledctl: add support to empty slots blinking
ledmon license change to LGPLv2
ledctl: Add SES get/set/list slot support
Update NPEM wait command
Remove exclusionary language
ledmon: Define ONESHOT_NORMAL for VMD

Bug fixes

ipmi: avoid error messages on non-dell platforms
vmdssd: define normal pattern
ledctl: clear unsupported params from config
block.c: get_block_device_from_sysfs_path modification
fix ibpi_value lists getter
amd_ipmi: Allow to _enable_smbus_control
ledmon.c: allocate memory for ignore
sysfs: add only vmd devices to slots_list
Rename --controller parameter
Slots list implementations and fixes

v0.96
----

Manual updates, clarify --listed-only option
Fix cache indexing of ATA port
Fixes in regard to macros
Fix memory leak in amd_ipmi.c
Fix NULL pointer dereferences in sysfs.c
Make messages appear in service log immediately
Other minor fixes

==================

[Description]
  Please update ledmon package version to:
  https://github.com/intel/ledmon/releases/tag/v0.97
  current version of ledmon 0.95 in ubuntu 24.04 is out-of-date. It appears to be abandoned in Debian.

[Hardware Information]
  Architecture:
    Intel / AMD (x86_64)
  Platform(s):
    GNR, SRF, CWF
  Date HW is expected at Canonical:

  Component(s):
    Tools

[Software Information]
  Target Version:
    24.04
  Target Kernel:
    N/A
  Commit IDs:
    N/A
  External Links:
    https://github.com/intel/ledmon/releases/tag/v0.97

[Business Justification]
  The current version 0.95 of ledmon in Ubuntu 24.04 active development is outdated.

[Testing guidance]
  N/A

[External ID]

[Hector CAO (hectorcao)]

The ledmon package at version v0.97 for Noble (24.04) is available for testing at : https://launchpad.net/~hectorcao/+archive/ubuntu/lp2052653

[Bun K Tan (bktan1)]

@mtkaczyk - can you test?

[Frank Heimes (fheimes)]

So I reviewed the modified package and have a few comments:

The (final) package version must not have the the "+ppa1" suffix (for testing purposes that is of course okay, but not for uploading to the archive).
It must have the exact version like it should have in the archive, here just:
0.97-0ubuntu1

There is always a reference to the underlying LP bug needed in the changelog, like:
  * New upstream release 0.97, now Ubuntu-specific package. (LP: #2052653)

lintian on the source package looks okay (just informational messages "I"):
$ lintian -EvIL -pedantic
I: ledmon source: adopted-extended-field (in section for source) XSBC-Original-Maintainer [debian/control:5]
I: ledmon source: older-debian-watch-file-standard 3 [debian/watch]
I: ledmon source: out-of-date-standards-version 4.5.0 (released 2020-01-20) (current is 4.6.2)
I: ledmon source: patch-not-forwarded-upstream [debian/patches/0002-To-cast-uint64_t-for-shift-to-prevent-Werror-shift-c.patch]

Since the currently existing ledmon package is available for multiple architectures:
$ rmadison --suite=noble ledmon
 ledmon | 0.95-2build1 | noble/universe | source, amd64, arm64, armhf, ppc64el, riscv64, s390x
the PPA test build must be done on the same set of architectures (so not only amd64).
I've done that here: https://launchpad.net/~fheimes/+archive/ubuntu/lp2052653

And an install (from scratch) and upgrade (from the existing version 0.95-2build1) to the new one should also be tried (at least on one plaform, often amd64).
(Due to the lack of access to other systems I just did that quickly on s390x.)

The build logs look okay(-ish), no errors (but several warning).
These should be ideally addressed/reported upstream, to be fixed in future releases.

lintian on the binaries / DEBs looks also okay (only I and X):
$ lintian -EvIL -pedantic ../*.deb
I: ledmon: systemd-service-file-missing-documentation-key [lib/systemd/system/ledmon.service]
I: ledmon: systemd-service-file-missing-documentation-key [lib/systemd/system/ledmon.service]
I: ledmon: systemd-service-file-missing-documentation-key [lib/systemd/system/ledmon.service]
I: ledmon: systemd-service-file-missing-documentation-key [lib/systemd/system/ledmon.service]
I: ledmon: systemd-service-file-missing-documentation-key [lib/systemd/system/ledmon.service]
I: ledmon: systemd-service-file-missing-documentation-key [lib/systemd/system/ledmon.service]
X: ledmon: binary-file-built-without-LFS-support [usr/sbin/ledctl]
X: ledmon: binary-file-built-without-LFS-support [usr/sbin/ledmon]

I did the changes to the code mentioned above and can sponsor it (especially knowing that there is a plan in place to close the gap between Debian and Ubuntu again in future).

Upload done:
https://launchpad.net/ubuntu/noble/+queue?queue_state=3&queue_text=ledmon

[Frank Heimes (fheimes)]

ledmon version 0.97-0ubuntu1 now landed in noble-proposed:
ledmon | 0.97-0ubuntu1 | noble-proposed/universe | source, amd64, arm64, armhf, ppc64el, riscv64, s390x

[Launchpad Janitor (janitor)]

This bug was fixed in the package ledmon - 0.97-0ubuntu1

---------------
ledmon (0.97-0ubuntu1) noble; urgency=medium

  * New upstream release 0.97, now Ubuntu-specific package. (LP: #2052653)

 -- Hector Cao <email address hidden> Mon, 12 Feb 2024 17:11:37 +0100

[Frank Heimes (fheimes)]

ledmon version 0.97-0ubuntu1 has now landed in noble's release pocket:
ledmon | 0.97-0ubuntu1 | noble/universe | source, amd64, arm64, armhf, ppc64el, riscv64, s390x
With that this ticket can be closed as Fix Released.

[Hector CAO (hectorcao)]

@fheimes : thanks for the feedback, and even taking time to test it, i also tested it on Intel server hardware (amd64). I also took notes of your feedback for next time.