Comment 7 for bug 85725

Sebastien Bacher (seb128) wrote :

thank you for your work on that Luke, some comments about the changes:

- you need to bump the shlibs version
- don't use g_return_if_fail to return when launchpad-integration is not install, that will raise a critical warning, you should rather use a simple if (g_find_program_in_path ("launchpad-integration")) return;
- the library version could be updated in the configure so other applications could version their requirements

not sure on whether looking for the program in the path is a good idea, would it make sense to use an environment variable rather? I try to avoid creating extra ios when not required. Once those issue fixed I think that can be uploaded to hardy