Add a setting to hide the launchpad menu items

Bug #85725 reported by Vincent Untz on 2007-02-17
4
Affects Status Importance Assigned to Milestone
launchpad-integration (Ubuntu)
Wishlist
Luke Yelavich

Bug Description

Binary package hint: liblaunchpad-integration0

It's good to have launchpad integration, but some people might want to hide them (for example, when they want to show an upstream desktop, or if they disagree with the use of launchpad for some reason).

There should be a global gconf key that this lib would look at to know whether the menu items should be added or not.

Sebastien Bacher (seb128) wrote :

Thank you for your bug, patches are welcome for that. Not sure if that would be easy to do since applications are patched to add menu separators and a place holder

Changed in launchpad-integration:
importance: Undecided → Wishlist
status: Unconfirmed → Confirmed
Sebastien Bacher (seb128) wrote :

Note the liblaunchpad-integration doesn't Depends on gconf as we patch GTK applications also

Sebastien Bacher (seb128) wrote :

We could use an environment variable, the launchpad-integration API needs to be updated to add separators which is done with the applications changes currently

Matt Zimmerman (mdz) wrote :

I have suggested in the past that a simple way to do this would be to disable the menu items if /usr/bin/launchpad-integration is not present. In this case, the items wouldn't work anyway, and this would make it trivial to disable by uninstalling the package.

Matt Zimmerman (mdz) wrote :

The library should recommend launchpad-integration, rather than depend on it, to allow this to be trivially disabled by uninstalling the package

Colin Watson (cjwatson) on 2008-03-14
Changed in launchpad-integration:
assignee: nobody → themuso
Luke Yelavich (themuso) on 2008-03-14
Changed in launchpad-integration:
status: Confirmed → In Progress
Luke Yelavich (themuso) wrote :

I'd like someone to have a look over my changes please. You can pull them from http://bazaar.launchpad.net/~themuso/launchpad-integration/new-api

If all looks good, I'll push to the main branch, and upload.

Sebastien Bacher (seb128) wrote :

thank you for your work on that Luke, some comments about the changes:

- you need to bump the shlibs version
- don't use g_return_if_fail to return when launchpad-integration is not install, that will raise a critical warning, you should rather use a simple if (g_find_program_in_path ("launchpad-integration")) return;
- the library version could be updated in the configure so other applications could version their requirements

not sure on whether looking for the program in the path is a good idea, would it make sense to use an environment variable rather? I try to avoid creating extra ios when not required. Once those issue fixed I think that can be uploaded to hardy

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package launchpad-integration - 0.1.16

---------------
launchpad-integration (0.1.16) hardy; urgency=low

  [ Martin Pitt ]
  * debian/control: Fix Vcs-Bzr to get along with current debcheckout.

  [ Luke Yelavich ]
  * lib/launchpad-integration.c:
    - Add launchpad_integration_add_ui_with_separators function to allow the
      adding of launchpad menu items, with optional separators.
    - Don't show launchpad menu items if the launchpad-integration script
      cannot be found in the path. (LP: #85725)
  * debian/control: Move launchpad-integration from depends, to recommends.
  * debian/rules: Update shlibs version.
  * patches/evince-lpint.patch: Updated to use new function.
  * configure.ac: Update version number.

 -- Luke Yelavich <email address hidden> Tue, 01 Apr 2008 15:49:43 +1100

Changed in launchpad-integration:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers