Reduce clutter and frame as in HIG

Bug #697606 reported by tsg1zzn on 2011-01-05
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
language-selector (Ubuntu)
Undecided
Gunnar Hjalmarsson

Bug Description

Binary package hint: language-selector

The "Text" tab looks a little messy, but can be tidied up by following the Gnome HIG more closely.

Especially:
http://library.gnome.org/devel/hig-book/stable/controls-frames.html.en
http://library.gnome.org/devel/hig-book/stable/design-text-labels.html.en

I removed the frame and changed some unevent alignments to match better.

tsg1zzn (tsg1zzn) wrote :
tsg1zzn (tsg1zzn) wrote :
tsg1zzn (tsg1zzn) wrote :
tsg1zzn (tsg1zzn) wrote :
Gunnar Hjalmarsson (gunnarhj) wrote :

I agree that your patch is an improvement, so I'm going to propose it to be applied in Natty. Please see https://code.launchpad.net/~gunnarhj/language-selector/language-menu, which branch includes your patch together with other suggested changes. If you want to test the changes, you can install the development package at https://launchpad.net/~gunnarhj/+archive/language-menus

Thanks!

Changed in language-selector (Ubuntu):
assignee: nobody → Gunnar Hjalmarsson (gunnarhj)
status: New → In Progress
tags: added: patch
Gunnar Hjalmarsson (gunnarhj) wrote :

I just viewed the modified language-selector UI in Natty, and there it doesn't look quite the same (see the attached file format-tab-natty.png). The list of l-s dependencies in Natty includes 'gir1.2-gtk-3.0' instead of 'python-gtk2'.

Even if there is a border, sort of, around the examples, personally I think it's pleasant, and not like the previous black border. Thought I'd mention it, though.

tsg1zzn (tsg1zzn) wrote :

The frame just looks different because of the theme. I think it's the theme shown when the correct theme engine isn't installed. Natty will surely not look like that.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package language-selector - 0.12

---------------
language-selector (0.12) natty; urgency=low

  [ Gunnar Hjalmarsson ]
  * LanguageSelector/gtk/GtkLanguageSelector.py:
    - Show only options corresponding to available translations in the
      combo box on language-selector's "Language" tab (LP: #693337).
  * LanguageSelector/LanguageSelector.py:
    - Skip the encoding part in the dmrc "Language" value. It's not
      a locale name, so let's not give the impression it is.
  * data/LanguageSelector.ui:
    - Clearer labels to describe the second ("Text") tab.
    - Icon added to taskbar. Thanks to Pavol Klačanský (LP: #648109).
    - Texts that inform the user about the need to restart for changes
      to system settings to take effect (LP: #127356, #612991).
    - Ellipses removed from the labels on the "Apply System-Wide"
      buttons (LP: #531799).
    - Layout tweaking of the "Format" (previously "Text") tab
      (LP: #697606).
  * data/main-countries:
    - Provide main or origin country for languages with multiple country
      codes present among the languages' available locales.
  * LanguageSelector/utils.py:
    - Take main country code into account when language2locale()
      generates a locale name for LC_MESSAGES.
    - language2locale() rewritten to make use of other language-selector
      functions.

  [ Martin Pitt ]
  * LanguageSelector/gtk/GtkLanguageSelector.py: Update ListStore construction
    to also work with the next pygobject release.
 -- Gunnar Hjalmarsson <email address hidden> Fri, 28 Jan 2011 15:50:50 +0100

Changed in language-selector (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers