Restricted Manager fails to start with Russian, Finnish, Romanian, Japanese or Turkish localization packs.

[Andrey Zaitsev]

Binary package hint: language-pack-ru-base, language-pack-fi-base, language-pack-ja-base, language-pack-tr-base

Release: Ubuntu 7.10
Package version: 7.10+20071012
Steps to reproduce: Try to use restricted-manager with Finnish, Russian, Romanian, Japanese or Turkish localization

This bug is caused by errors in translations in restricted-manager.po. There are two messages in po-file that have inline dictionary key 'os'. In all 5 translations this key causes bug, the correct usage of the key in translated text should be '%(os)s'

In Finnish and Japanese translation key misses format specifier 's', in Russian the key itself is missed, there is %(s) instead. I've uploaded file patches.tar.gz which contains three debdiffs with patches that fix po-files in each of language-pack-*-base file.

[Andrey Vihrov (andrey.vihrov)]

I can confirm I have exactly the same situation - upgrade from feisty to gutsy, amd64 and ru_RU locale. Indeed, restricted-manager operates normally with LANG=C.

[Andrey Zaitsev (a-zaitsev)]

The same thing happens with finnish locale. See bug https://bugs.launchpad.net/ubuntu/+source/restricted-manager/+bug/153220

As I can see from source package of restricted-manager there is now translation in the file ru.po for the following text:
-----------
#: ../restricted-manager:476
msgid ""
"Proprietary drivers do not have public source code that %(os)s developers "
"are free to modify. They represent a risk to you because they are only "
"available on the types of computer chosen by the manufacturer, and security "
"updates to them depend solely on the responsiveness of the manufacturer. "
"%(os)s cannot fix or improve these drivers."
msgstr ""

#: ../restricted-manager:499
-----------------------
So the key 'os' in "% {'os' : get_os_name())" becomes invalid in RestrictedManagerCommon.py line 242. In finnish case there is an error in translations (see the link i've provided).

So the quick workaround is to copy-paste the contetnts of msgid secton i've provided to msgstr section of ru.po.

I will provide a patch with translated text soon.

[Timo Karhu (nalle-karhulitos)]

Confirming the same (Andrey mentioned finnish already but here it comes again):

xx@yy:~$ restricted-manager
  File "/usr/bin/restricted-manager", line 42, in <module>
    rm = RestrictedManager()
  File "/usr/lib/python2.5/site-packages/RestrictedManager/RestrictedManagerGtk.py", line 53, in __init__
    RestrictedManagerCommon.__init__(self,args,opts)
  File "/usr/lib/python2.5/site-packages/RestrictedManager/RestrictedManagerCommon.py", line 197, in __init__
    self.launch_manager()
  File "/usr/lib/python2.5/site-packages/RestrictedManager/RestrictedManagerGtk.py", line 151, in launch_manager
    self.ManagerWindow(self.xml, self.handlers, self)
  File "/usr/lib/python2.5/site-packages/RestrictedManager/RestrictedManagerGtk.py", line 209, in __init__
    self.reset_model()
  File "/usr/lib/python2.5/site-packages/RestrictedManager/RestrictedManagerGtk.py", line 262, in reset_model
    self.parent.set_title_label(self.xml.get_widget('label_heading'), any_enabled)
  File "/usr/lib/python2.5/site-packages/RestrictedManager/RestrictedManagerGtk.py", line 122, in set_title_label
    (bold, normal) = RestrictedManagerCommon.title_label(self, in_use)
  File "/usr/lib/python2.5/site-packages/RestrictedManager/RestrictedManagerCommon.py", line 242, in title_label
    'these drivers.') % {'os': get_os_name()}
ValueError: unsupported format character 'k' (0x6b) at index 82
xx@yy-laptop:~$ locale
LANG=fi_FI.UTF-8

After saying LANG=C I could run restricted-manager! Thank you Andrey!

[Andrey Zaitsev (a-zaitsev)]

OK. Here is a patch that probably fixes (I've not tried yet, I'll do if I will have time to build the package) restricted manager for Finnish and Russian locale. I think it's a good idea to search all of po-files in restricted manager source for similar bugs.

[Andrey Vihrov (andrey.vihrov)]

I wonder how could this get through the development cycle and beta testing - Russian/Finnish localisations and restricted-manager are widely used.

[Andrey Zaitsev (a-zaitsev)]

>> I wonder how could this get through the development cycle and beta testing - Russian/Finnish localisations and restricted-manager are widely used.

Hmm, well, many things are broken in this release. Just look at the bugs related to fgrlx drivers, and framebuffer bugs (setting the "vga" kernel parameter to something different from "normal" breaks tty's I/O :)).

I guess this bug will not be fixed soon. :( As it was in 7.04, "domestic" bugs don't get much attention to. It's sad. One thing is obvious - you don't use restricted-manager often (once or twice maybe), so this does not become annoying :)

[Andrey Vihrov (andrey.vihrov)]

Yes, there's plenty of bugs. I've personally encountered the fb bug since I had vga=795 option thas was added to every kernel command line by grub-update.

[Fumihito YOSHIDA (hito)]

This problem cause in Japanese locales too.
Please update description "Russian or Finnish or Japanese" .

I'll post a .po patch at soon.

[Andrey Zaitsev (a-zaitsev)]

Fumihito, your patch reverses normal code to buggy, nevertheless I've corrected it, and post a patch that accumulates bugfixes for Japanese, Finnish and Russian locales. Soon (I think tomorrow) I'll build a package and upload it to PPA for everyone to test.

[Andrey Vihrov (andrey.vihrov)]

I just took a brief view on the patch, it contains some mistakes in the Russian translation :>

[Andrey Zaitsev (a-zaitsev)]

:) Found one

[Andrey Vihrov (andrey.vihrov)]

I've corrected the remaining :)

[Andrey Zaitsev (a-zaitsev)]

Patching and building restricted-manager-core, restricted-manager and restricted-manager-kde doesn't make much sense, because *.mo files aren't generated during the build process. Quick investigation shows, that localized messages for restricted-manager are contained in language-pack-*-base packages, so they need to be patched instead of restricted-manager-* and our "big" pacth should be divided to 3 lesser ones: for ru, fi, and ja locales respectively.

I've added affected packages, and assigned the bug to the language-pack-*-base maintainer - Marin Pitt.

I'll post new patches soon.

[Andrey Zaitsev (a-zaitsev)]

Fill free to patch language-pack-*-base with attached pacth

[Martin Pitt (pitti)]

Not a bug in restricted-manager, this needs to be fixed in Rosetta's translations:

  https://translations.launchpad.net/ubuntu/gutsy/+source/restricted-manager

[Andrey Zaitsev (a-zaitsev)]

Thank you Martin!

Everything is correct in current translations, so waiting for update!

[Serhiy Kachaniuk (serzholino)]

Same problem here with Ukrainian locale, see aslso bug# 156559. Should i mark it as duplicate of this bug?

[Andrey Zaitsev (a-zaitsev)]

Hello, Serhiy!

Yes, please mark bug #156559 as a duplicate of this one. Also goto to the link that Martin Pitt provided three posts above and correct the translation (if it's not already corrected). When done, please change the status of this bug.

Thank you!

[Bohdan Kmit' (mit)]

I have fixed Ukrainian translation.

[Juksu (jluostar)]

Still no restricted manager...

[Adi Roiban (adiroiban)]

I have updated the Romanian key. I was the one translating '%(os)s' to '%os'.

Should I send a patch, or it is of if the key is updated in rosetta?

[Andrey Zaitsev (a-zaitsev)]

No, there is no need to send the patch.

[Freezen (niko-volanen)]

excuse for being such a noob, but how do i exactly apply the patch? step by step instructions would be nice.. where to put the patch file, from where to apply the patch etc..

[Juksu (jluostar)]

sorry but i do not catch the meaning of "fix committed"? This has been the status for quite some time now!
I still get no restricted manager. Although my bug was marked as a duplicate of this?
Or are we supposed to do something ourselves?
I can help right away with the finnish translation if needed.

[Juksu (jluostar)]

This is a fresh crash report from network manager. It never starts, only crashes. And then apport crashes when trying to report.
Why is this bug marked as fixed? Or is my bug report NOT a duplicate of this after all?

[Andrey Zaitsev (a-zaitsev)]

>> This is a fresh crash report from network manager.

You should open a bug on network manager.

>> sorry but i do not catch the meaning of "fix committed"?

It means that fix is commited but not released yet. Wait for lang-packs update with fixed translations.

[Sergiu Bivol (sergiu-bivol)]

I can confirm this bug for a Romanian system for even more applications: Login Window, Shared Folders (when navigating to the needed folder), Synaptic (when selecting Generate package download script), About Me (navigating to a custom folder makes the application crash).

[Adi Roiban (adiroiban)]

> Sc0rpi0n
> I can confirm this bug for a Romanian system for even more applications:
> Login Window, Shared Folders (when navigating to the needed folder),
>Synaptic (when selecting Generate package download script), About Me (navigating to a custom folder makes the application crash).

Thank you for your report. I will investigate this problem.

Hope the language-package will be updated soon.

[Timo Jyrinki (timo-jyrinki)]

The updated Finnish language packs now fixed this for Finnish.

[Adi Roiban (adiroiban)]

fix released and tested. everything is ok now

[Evgeny Kuznetsov (nekr0z)]

Fix may be released, but a problem with Russian locale persists up till the latest Hardy.

[balcis (stadatyum)]

Same problem exists for Turkish, too. I have a system of amd64 processor, ubuntu gutsy (for i386) clean install, and it's localized for Turkish. The same problem, is there any fix or something?

[Martin Pitt (pitti)]

There are new language packs in gutsy/feisty/edgy/dapper-proposed. Can you please enable proposed and check if they fix the issue?

[Andrey Zaitsev (a-zaitsev)]

Hello, Martin!

Members of russian translation team are morons - that's all that I can
say. Russian translation is not fixed after update.

В Чтв, 21/02/2008 в 15:49 +0000, Martin Pitt пишет:
> There are new language packs in gutsy/feisty/edgy/dapper-proposed. Can
> you please enable proposed and check if they fix the issue?
>

[balcis (stadatyum)]

i've searched "propose" in sources.list but i couldn't find it; how can i enable them?

[Andrey Zaitsev (a-zaitsev)]

Changing status back to confirmed for russian lang-pack. Recent update of the package didn't fix the bug. Damn, don't those guys in russian translation team use restricted manager or what?

[Martin Pitt (pitti)]

balcis: System -> Administration -> Software Sources -> Updates

But the new packages are in -updates now, so you should get them anyway.

[Ushakov Maksym (mmx-dimitrov)]

Sorry for slow reaction on the bug in russian translation team.

Thanks to all. Fix committed.

[Ushakov Maksym (mmx-dimitrov)]

Sorry for slow reaction on the bug in russian translation team.

Thanks to all. Fix restricted-manager committed. Hardy & Gutsy

[Martin Pitt (pitti)]

Not a bug in r-m itself, it's in the language packs. Closing r-m task.

[Martin Pitt (pitti)]

I hope this is fixed in the current automatically created weekly updates in my PPA. Can you please try to install

  http://ppa.launchpad.net/ubuntu-langpack/ubuntu/pool/main/l/language-pack-ru/language-pack-ru_7.10+20080229_all.deb

and report back whether it fixes the problem for you?

[Peter Matulis (petermatulis)]

Martin, the PPA package proved successful in the Montreal office; the restricted-manager opened up for a Russian system.

[Andrey Zaitsev (a-zaitsev)]

I confirm, restricted manager now works! Thank you Martin.
I hope we won't have such stupid bugs in future.

[Igor Zubarev (igor.zubarev)]

I confirm too, restricted manager now works! :)

[Martin Pitt (pitti)]

Hardy got new language packs now, too, should be fixed.

[Martin Pitt (pitti)]

Can anyone please test and report about the Japanese language packs?

[Martin Pitt (pitti)]

Setting to incomplete until someone gives feedback about the Japanese langpacks.

[Ikuya Awashiro (ikuya-fruitsbasket)]

Hi Martin,

I've tested it in newest Japanese Langupacks, and works fine!

Thanks,

[Ikuya Awashiro (ikuya-fruitsbasket)]

Status changed to "In Progress"

[Martin Pitt (pitti)]

Thanks for the feedback! Closing then.

[emre. (emre.)]

Restricted Manager in Turkish doesn't work either because of "%(os)s" changing. Also Totem and some other programs either. Can't we make a function to check these wrong translations? I wrote this to Brainstorm too: http://brainstorm.ubuntu.com/idea/5134/

[Emrah Ergin (erginemr)]

For those who are still having problems in launching these two applications, you may try this workaround until the release of Hardy. This workaround works especially for Turkish, but may also apply to other languages:

1. Right-click on Gnome's main menu and select "Edit Menus" to start Alacarte menu editor.

2. Find "Movie Player" under "Sound & Video", and "Restricted Drivers Manager" under "Administration" (or their equivalents in Russian, Finnish, Romanian, Japanese or Turkish.)

3. Right click on the corresponding items and add the following line as a prefix to the text box titled "Command" (i.e. to the beginning part of the command line supposed to run the program):
env LC_CTYPE=en_US.UTF8

For instance, for Totem Media Player, this line should read as follows:
env LC_CTYPE=en_US.UTF8 totem %U

4. Close the dialogs and then, the menu editor. Both applications should run and, do so in your local language, now.

[Timo Jyrinki (timo-jyrinki)]

Looks fixed, checked 9.04 sources. 7.10 is not anymore supported.