Comment 3 for bug 1488569

Revision history for this message
Xavi Garcia (xavi-garcia-mena) wrote :

Hi,

I've installed silo 055 and check the result with the new code of the indicator-sound from branch:
lp:~xavi-garcia-mena/indicator-sound/next-play-prev-buttons-bug-1373313

The code instead of setting the MPRIS controls by default reads the CanPlay, CanGoNext and CanGoPrevous properties.

The MPRIS player always return true to CanPlay, but returns always false for CanGoNext and CanGoPrevious, the result is obviously that the play control is the only only one showing as active.

I've also noticed that the player is not emiting any signal when the properties change.
The indicator-sound is subscribed to the PropertiesChanged signal with the following code:

/* Connecting to GDBusProxy's "g-properties-changed" signal here, because vala's dbus objects don't
    emit notify signals */
var gproxy = this.proxy as DBusProxy;
gproxy.g_properties_changed.connect (this.proxy_properties_changed);

To debug the code I'm listing all the properties that changed.
The method proxy_properties_changed is never called.

This works fine on the desktop, but not on the phone with silo 55.

Should we register to the signal in a different way? or should we consider the above issues as a bug?

In relation with the play/pause button: the desktop changes from the play to the pause button correctly with the current indicator-sound code, but not on the phone. (could this be a bug in the UI?)

We can maybe set a different value for the play property in the indicator menu, but as I said the PropertiesChanged signal is not working...