Date with event isn't highlighted in the calendar

[Matthew Paul Thomas]

Binary package hint: indicator-datetime

indicator-datetime 0.1.98-0ubuntu1, Ubuntu Natty

1. In "Time & Date Settings…" > "Clock", check both "Monthly calendar" and "Coming events" if they are not checked already.
2. In Evolution, add an event for some day in the current month.
3. If bug 740977 has not been fixed yet, log out and log back in again.
4. Open the clock menu.

What you see: No special highlighting for that date.

What you should see: "If a date has at least one event, it should be shown in bold." <https://wiki.ubuntu.com/TimeAndDate#Monthly%20calendar>

[Karl Lattimer (karl-qdh)]

This should be working already, but I noticed it isn't.

I've been debugging the issue along with; https://bugs.launchpad.net/indicator-datetime/+bug/649800

[Karl Lattimer (karl-qdh)]

I've created the following bug to group these calendar widget related issues;

"IDO calendar should replace GtkCalendar wrapper with a grid layout menu"
https://bugs.launchpad.net/ubuntu/+source/ido/+bug/742370

I'm trying to fix this issue independent of the above bug, there seems to be a communication problem with dbusmenu at the moment.

[Karl Lattimer (karl-qdh)]

Some notes on this bug;

In datetime-service.c the function update_appointment_menu_items will call in the iteration of appointment items, dbusmenu_menuitem_property_set_int (calendar, CALENDAR_MENUITEM_PROP_MARK, dmday);

This is supposed to be received by calendar_prop_change_cb in indicator-datetime.c we assign this callback in new_calendar_item like so;

g_signal_connect(G_OBJECT(newitem), DBUSMENU_MENUITEM_SIGNAL_PROPERTY_CHANGED, G_CALLBACK(calendar_prop_change_cb), ido);

There are various properties we want to be able to set on the calendar, setting the date, marking, unmarking and clearing marks, each has a function in ido calendar menu item.

Watching the communication between the service and the indicator shows that a property call is being sent for set mark and clear marks. Neither of these commands appears to be received by indicator-datetime.c

[Karl Lattimer (karl-qdh)]

Ted gave me a pointer to a possible problem, in that it might be de-duplicating the signals, in which case it would be better to fix this by sending an array of ints.

However, this still doesn't explain why the signal wasn't being received at all by the indicator. The recommendation there is to turn on -DMASSIVEDEBUGGIN in dbusmenu and see if there's a reason for it.

Possibly the array of ints will solve the problem, I'm trying that as it's a sensible move anyway.

[Karl Lattimer (karl-qdh)]

I've updated the branch to include the array of ints change tedg suggested, however the bug is still there.

Can get a capture from dbus-monitor but it looks like I'll need to rebuild dbusmenu to do any real testing on it.

[Karl Lattimer (karl-qdh)]

after some debugging I think I've cracked it, stay tuned :)

[Karl Lattimer (karl-qdh)]

Currently pushed branch shows marked days when the calendar is updated however it seems to fail to do this on startup.

I'm testing to see if it updates on the timer if so i'll add a one time event on startup to trigger an update after 30 seconds or so.

maybe ted will have a better suggestion

[Karl Lattimer (karl-qdh)]

Seems fixed in head today, thanks ted :D