Comment 3 for bug 1332187

Revision history for this message
Michael F. Miller (mikem1355) wrote : Re: [Bug 1332187] Re: driver-injection-disk script needs to support disk and usb-partition devices

Adam,
Looks good to me.

-- mikem

On Fri, Jun 27, 2014 at 11:26 AM, Adam Conrad <adconrad@0c3.net> wrote:

> I'd assume the following 1-line patch would achieve the same result:
>
> --- driver-injection-disk.sh.orig 2013-10-04 03:38:29.000000000 -0600
> +++ driver-injection-disk.sh 2014-06-27 10:25:29.546558043 -0600
> @@ -29,7 +29,7 @@
> }
>
> #try to mount possible driver disk
> -for device in $(list-devices usb-partition); do
> +for device in $(list-devices disk; list-devices usb-partition); do
> label=$(block-attr --label $device 2>/dev/null || true)
> if [ "$label" = "OEMDRV" ]; then
> db_input high driver-injection-disk/load || true
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1332187
>
> Title:
> driver-injection-disk script needs to support disk and usb-partition
> devices
>
> Status in “hw-detect” package in Ubuntu:
> Confirmed
>
> Bug description:
> 14.04 LTS (and older) does not support driver injection via micro deb
> (udeb) package when mounted from iLO virtual media.
>
> iLO does not present an OEMDRV device with a partition, therefore,
> the Ubuntu installer overlooks that media as being viable. Instead of
> a usb-partition, the device is seen as a disk. Running "list-devices
> disk" and then a blkid against that disk will reveal the OEMDRV label.
>
> Instead of just probing for usb-partitoin in list-devices, the driver-
> injection-disk script also needs to check the "disk" device via list-
> devices.
>
> I'll post a possible fix via bzr merge proposal shortly.
>
> This will need to go into 14.10 as well as an update in 14.04 LTS
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/ubuntu/+source/hw-detect/+bug/1332187/+subscriptions
>