smbbrowse: Force NT1 protocol version for workgroup support
"Windows Network" doesn't work with recent samba versions, because
"client max protocol" has been changed from NT1 to SMB3 recently.
NT1 is mandatory for workgroup support. Let's force NT1 using the
newly added smbc_setOptionProtocols API if available. But force this
only when neither hostname, nor IP address is used. This among others
prevents complete breakage if NT1 is disabled on server. Use GResolver
to implement this heuristic.
Does this also happen with Ubuntu Disco? I checked upstream and there were no other changes following this one in that file:
commit 6c8bc39f570ea82 cf14e83ce7d1dbd be569d09d1
Author: Ondrej Holy <email address hidden>
Date: Wed Sep 12 15:28:51 2018 +0200
smbbrowse: Force NT1 protocol version for workgroup support
"Windows Network" doesn't work with recent samba versions, because rotocols API if available. But force this
"client max protocol" has been changed from NT1 to SMB3 recently.
NT1 is mandatory for workgroup support. Let's force NT1 using the
newly added smbc_setOptionP
only when neither hostname, nor IP address is used. This among others
prevents complete breakage if NT1 is disabled on server. Use GResolver
to implement this heuristic.
https:/ /bugzilla. gnome.org/ show_bug. cgi?id= 780958
In the SRU test, smbstatus does show some NT1 connections, but in the end the share connection is using SMB3.11, which is what we want.
Since the machine now shows up, and it wasn't before, this may warrant a new separate bug.