gvfs-smb-browse can't browse samba/smb tree

Bug #1778322 reported by Sebastian Byczkowski on 2018-06-23
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
gvfs (Ubuntu)
High
Unassigned
Bionic
Undecided
Unassigned
Cosmic
Undecided
Unassigned
nautilus (Ubuntu)
Undecided
Unassigned
samba (Ubuntu)
High
Unassigned

Bug Description

* Impact
On Bionic Beaver 18.04.1 gvfs-smb-browse can't browse smbtree because of that Nautilus displays "Empty Folder" when clicking "Windows Network"

* Test case
Try to browse a smb share from a bionic client

* Regression potential
Check that smb browsing/mounts still work as they should

---------------------------

Nautilus should show smbtree nad host on the smb network.

When inputing this command:
killall gvfsd-smb-browse && GVFS_DEBUG=1 /usr/lib/gvfs/gvfsd-smb-browse

You can see the error:
smb-network: Queued new job 0x55b19a2c9f40 (GVfsJobCreateMonitor)
smb-network: send_reply(0x55b19a2c9f40), failed=1 (Action not supported by the processing engine)
smb-network: backend_dbus_handler org.gtk.vfs.Mount:QueryFilesystemInfo (pid=5708)
smb-network: Queued new job 0x55b19a2e7820 (GVfsJobQueryFsInfo)
smb-network: send_reply(0x55b19a2e7820), failed=0 ()
smb-network: backend_dbus_handler org.gtk.vfs.Mount:Enumerate (pid=5708)
smb-network: Queued new job 0x55b19a2c30c0 (GVfsJobEnumerate)
smb-network: send_reply(0x55b19a2c30c0), failed=0 ()

Proposed solution:
Add gvfsbackendbrowse-switch-to-NT1.patch disscused on RedHat Bugzilla
[link]https://bugzilla.redhat.com/show_bug.cgi?id=1513394
which implements "change to NT1" in gvfs-smb-browse to browse smbtree to aviod adding "max client protocol" = NT1" to smb.conf to switch all samba to unsafe NT1 which most users are doing to correct this bug.

A patch for gvfs-smb-browse to switch to NT1

Simpler form of before posted patch.Ehh

The attachment "gvfs-smb-browse change to NT1 from RedHat Bugzilla" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gvfs (Ubuntu):
status: New → Confirmed
Changed in nautilus (Ubuntu):
status: New → Confirmed
Changed in nautilus (Ubuntu):
status: Confirmed → Invalid
Sebastien Bacher (seb128) wrote :

The fix is in https://launchpad.net/ubuntu/+source/gvfs/1.38.1-1ubuntu1

And being backported to cosmic and bionic

Changed in gvfs (Ubuntu):
importance: Undecided → Low
status: Confirmed → Fix Released
description: updated

Hello Sebastian, or anyone else affected,

Accepted gvfs into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gvfs/1.38.1-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gvfs (Ubuntu Cosmic):
status: New → Fix Committed
tags: added: verification-needed verification-needed-cosmic
Brian Murray (brian-murray) wrote :

Hello Sebastian, or anyone else affected,

Accepted gvfs into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gvfs/1.36.1-0ubuntu1.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gvfs (Ubuntu Bionic):
status: New → Fix Committed
tags: added: verification-needed-bionic
Brian Murray (brian-murray) wrote :

Hello Sebastian, or anyone else affected,

Accepted gvfs into cosmic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gvfs/1.38.1-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-cosmic to verification-done-cosmic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-cosmic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

I have checked bionic-proposed repo and listed packages have installed:
gvfs-backends/bionic-proposed,now 1.36.1-0ubuntu1.2 amd64 [installed]
gvfs-bin/bionic-proposed,now 1.36.1-0ubuntu1.2 amd64 [installed]
gvfs-common/bionic-proposed,now 1.36.1-0ubuntu1.2 all [installed]
gvfs-daemons/bionic-proposed,now 1.36.1-0ubuntu1.2 amd64 [installed]
gvfs-fuse/bionic-proposed,now 1.36.1-0ubuntu1.2 amd64 [installed]
gvfs-libs/bionic-proposed,now 1.36.1-0ubuntu1.2 amd64 [installed]
gvfs-libs/bionic-proposed,now 1.36.1-0ubuntu1.2 amd64 [installed]

But if I disable with # in smb.conf
max client protocol = NT1
or chane it to:
max client protocol = SMB3
Nautilus still shows me Empty Dir if I enter Windows Network and gvfs can't browse smbtree still.
So I assume the patch does not work as expected.

I'm sending Gvfs log.
Interesting part starts at line 173:

Starting GENSEC mechanism spnego
Server claims it's principal name is NONE
SPNEGO: Could not find a suitable mechtype in NEG_TOKEN_INIT
SPNEGO login failed: An invalid parameter was passed to a service or function.

And line 270 in Gvfs log:
Server connect ok: //TOMATO/IPC$: 0x7f72b4020fd0
smb-network: do_mount - [smb://DOMOWA; 0] dir = (nil), cancelled = 0, errno = [0] 'Succes'
smb-network: do_mount - (errno != EPERM && errno != EACCES), cancelled = 0, breaking
smb-network: send_reply(0x556b8fdb32b0), failed=1 (Downloading resources list from server failed: Succes)
Performing aggressive shutdown.
smb-network: purging server cache
Context 0x7f72b4010b60 successfully freed
Freeing parametrics:
network: Couldn't create directory monitor on smb://x-gnome-default-workgroup/. Error: given location is not mounted

Sebastien Bacher (seb128) wrote :

Thanks for the testing. Indeed there is a problem, from the build log

"Native dependency smbclient found: YES 0.3.1
Checking for function "smbc_setOptionProtocols" : NO"

The API needed is too new for our current libsmbclient version, we need to backport that one as well.
The other changes from the SRU are fine though and that one is just a no-change without the API so it probably makes sense to validate the current SRU anyway and do another round for libsmbclient/rebuild gvfs later

Changed in samba (Ubuntu):
importance: Undecided → High
Changed in gvfs (Ubuntu):
status: Fix Released → Triaged
importance: Low → High
Sebastien Bacher (seb128) wrote :
Changed in samba (Ubuntu):
status: New → Triaged
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers