Comment 24 for bug 1691678

Revision history for this message
Egmont Koblinger (egmont-gmail) wrote :

> but dropping the change creates a regression on the Ubuntu session/theme

So the situation is: Unpatched gnome-terminal looks perfect on the default GTK theme and on many others, except Ubuntu's.

Conclusion: Let's patch gnome-terminal! Wow.

I'm wondering: Has anyone considered fixing the Ubuntu theme(s) instead?

Oh, sure, in comment 16: "there's a workaround hacked into Yaru"

Why is that a workaround, and not a fix? Any why Yaru only and not Ambiance or any other affected Ubuntu theme? Move forward please in this direction, fix (or workaround, whatever) the affected themes so that then you can drop the broken gnome-terminal patch.

Or, again: If you believe that your themes as well as your gnome-terminal patch are correct, and other themes are buggy, please provide evidence. If that's not the case, adding a workaround to (and thus breaking) gnome-terminal instead of fixing the broken themes was clearly the wrong thing to do, and should be properly fixed ASAP.