Comment 6 for bug 133600

Christophe, few additional comments:

The package is quite old, so I think it is a good idea to fix these lintian warnings too:

W: flightgear source: debian-rules-sets-DH_COMPAT line 9
W: flightgear source: debian-rules-ignores-make-clean-error line 41
W: flightgear source: debian-rules-ignores-make-clean-error line 42
W: flightgear source: dh_testversion-is-deprecated
W: flightgear source: package-uses-deprecated-debhelper-compat-version 3
W: flightgear source: ancient-standards-version 3.5.5 (current is 3.7.2)

Let me know if you need help with these (use lintian -i to have details).

In copyright:

The ubuntu-motu are ubuntu maintainers (not debian maintainers)
The fsf address is old (should be Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA)
I would modify "The file in debian/FlightGear.xpm ..." to "The icon flightgear.xpm is derived from flightgear.pgn ..."

In dirs:

You should add usr/share/applications since you deleted "mkdir -p debian/flightgear/usr/share/applications" from rules

I would restructure the changelog too (to show the main changes and where they have been made):

flightgear (0.9.10-2ubuntu2) gutsy; urgency=low

  * Add 48x48 icon (LP: #133600)
    - add flightgear.xpm in debian/
    - add icon copyright's information in debian/copyright
  * Modify Maintainer value to match Debian-Maintainer-Field Spec
  * Update debian/flightgear.desktop:
    - Add icon
    - Removal of the Encoding entry (deprecated)
    - Change Version to 1.0
  * General clean-up:
     - Add usr/share/pixmaps and usr/share/applications in debian/dirs
     - Remove mkdir of usr/share/applications in debian/rules
     - Change installation method of desktop file from cp to install
     - Rework debian/copyright in compliance to present standards
     - Update debian/watch
     - (here add also the changes to correct the above lintian warnings)

 -- Christophe Sauthier <email address hidden> Wed, 22 Aug 2007 18:43:43 +0200

Re. the icon, I would consider reducing the number of colours. The icon is quite simple but the number of colours makes it quite huge (for no visible results).

You can also consider installing using debian/install (check man dh_install).
Finally, if you could add a man page, that would be super.

Thanks for your work!