There is no icon in xubuntu menu

[Shirish Agarwal]

Binary package hint: flightgear

Hi all,
    This is on gutsy gibbon 7.10 xubuntu latest updates. In the Applications menu, flightgear is shown but there is no icon :(

[Cesare Tirabassi (norsetto)]

There is indeed no icon specified in the .desktop file

[Christophe Sauthier (christophe.sauthier)]

I think I might be able to correct it... But it is my first one, so as you offer to mentor for this bug resolution, I'd really like your help...

[Christophe Sauthier (christophe.sauthier)]

The patch that I think might fix it.

[Christophe Sauthier (christophe.sauthier)]

Corrected patch file.

[Christophe Sauthier (christophe.sauthier)]

Corrected patch file.

[Cesare Tirabassi (norsetto)]

Christophe, few additional comments:

The package is quite old, so I think it is a good idea to fix these lintian warnings too:

W: flightgear source: debian-rules-sets-DH_COMPAT line 9
W: flightgear source: debian-rules-ignores-make-clean-error line 41
W: flightgear source: debian-rules-ignores-make-clean-error line 42
W: flightgear source: dh_testversion-is-deprecated
W: flightgear source: package-uses-deprecated-debhelper-compat-version 3
W: flightgear source: ancient-standards-version 3.5.5 (current is 3.7.2)

Let me know if you need help with these (use lintian -i to have details).

In copyright:

The ubuntu-motu are ubuntu maintainers (not debian maintainers)
The fsf address is old (should be Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA)
I would modify "The file in debian/FlightGear.xpm ..." to "The icon flightgear.xpm is derived from flightgear.pgn ..."

In dirs:

You should add usr/share/applications since you deleted "mkdir -p debian/flightgear/usr/share/applications" from rules

I would restructure the changelog too (to show the main changes and where they have been made):

flightgear (0.9.10-2ubuntu2) gutsy; urgency=low

  * Add 48x48 icon (LP: #133600)
    - add flightgear.xpm in debian/
    - add icon copyright's information in debian/copyright
  * Modify Maintainer value to match Debian-Maintainer-Field Spec
  * Update debian/flightgear.desktop:
    - Add icon
    - Removal of the Encoding entry (deprecated)
    - Change Version to 1.0
  * General clean-up:
     - Add usr/share/pixmaps and usr/share/applications in debian/dirs
     - Remove mkdir of usr/share/applications in debian/rules
     - Change installation method of desktop file from cp to install
     - Rework debian/copyright in compliance to present standards
     - Update debian/watch
     - (here add also the changes to correct the above lintian warnings)

 -- Christophe Sauthier <email address hidden> Wed, 22 Aug 2007 18:43:43 +0200

Re. the icon, I would consider reducing the number of colours. The icon is quite simple but the number of colours makes it quite huge (for no visible results).

You can also consider installing using debian/install (check man dh_install).
Finally, if you could add a man page, that would be super.

Thanks for your work!

[Christophe Sauthier (christophe.sauthier)]

Corrected debdiff file (before adding the manpage)

[Cesare Tirabassi (norsetto)]

Still two warnings to work out:

W: flightgear source: debian-rules-ignores-make-clean-error line 38
W: flightgear source: debian-rules-ignores-make-clean-error line 39

You should try to use a debian/install file and remove the two calls in debian/rules which install the desktop file and icon.

In debian/install you list the files to install and the directory they should be installed to. The name of the files to install should be given relative to the current directory, while the installation directory is given relative to the package build directory.

Excellent work with the icon!

[Christophe Sauthier (christophe.sauthier)]

flightgear (0.9.10-2ubuntu2) gutsy; urgency=low

  * Add 48x48 icon (LP: #133600)
    - add flightgear.xpm in debian/
    - add icon copyright's information in debian/copyright
  * Modify Maintainer value to match Debian-Maintainer-Field Spec
  * Update debian/flightgear.desktop:
    - Add icon
    - Removal of the Encoding entry (deprecated)
    - Change Version to 1.0
  * General clean-up:
     - Add usr/share/pixmaps and usr/share/applications in debian/dirs
     - Remove mkdir of usr/share/applications in debian/rules
     - Change installation method of desktop file from cp to install
     - Rework debian/copyright in compliance to present standards
     - Update debian/watch
     - Creation of a debian/compat file (level 5) and removal of all DH_COMPAT reference in debian/rules
     - Update of the Builds-Dependence to debhalper to >>5.0.0 and removal of the deprecated dh_testversion in debian/rules
     - Update of the Standard-Version debian/control to 3.7.2

 -- Christophe Sauthier <email address hidden> Tue, 4 Sep 2007 14:56:55 +0200

[Christophe Sauthier (christophe.sauthier)]

debdiff with the correct name.

[Cesare Tirabassi (norsetto)]

The .desktop and icon are not yet installed.
You need to add a call to dh_install, for instance after:

binary-arch: build install
        dh_testdir
        dh_testroot

You should change /usr/share/pixmaps/applications to /usr/share/pixmaps.
A minor point: the changelog should be made so that it is correctly visible over 80 columns. Please wrap the entries accordingly.
A little typo in the changelog: debhalper should be debhelper
In Debian its ok, but in Ubuntu some people do not like to have Section: universe/games and prefer Section: games
If you upload a new debdiff which correct these, you should subscribe u-u-s to find a sponsor for the upload.

[Christophe Sauthier (christophe.sauthier)]

Corrections with the comments.

[Christophe Sauthier (christophe.sauthier)]

This debdiff correct the comments, EXCEPT that I don't know how to wrap the line that contains the name of the comiter and the date...

I still cannot build on my computer and I won't be able to try again before the beginning of next week. In case you can puild it, I am putting the debdiff here.

[Cesare Tirabassi (norsetto)]

Thanks, looks very good to me!
There is no need to wrap the line that contains name and date.
Once you have tested that it builds and installs correctly, please subscribe u-u-s to find a sponsor for the upload.
Once uploaded, please consider as well submitting your patch to Debian:

https://wiki.ubuntu.com/ContributingToDebian
https://wiki.ubuntu.com/Bugs/Debian

[Christophe Sauthier (christophe.sauthier)]

flightgear (0.9.10-2ubuntu1~ppa1) gutsy; urgency=low

  * Add 48x48 icon (LP: #133600)
    - add flightgear.xpm in debian/
    - add icon copyright's information in debian/copyright
  * Modify Maintainer value to match Debian-Maintainer-Field Spec
  * Update debian/flightgear.desktop:
    - Add icon
    - Removal of the Encoding entry (deprecated)
    - Change Version to 1.0
  * General clean-up:
     - Add usr/share/pixmaps and usr/share/applications in debian/dirs
     - Remove mkdir of usr/share/applications in debian/rules
     - Change installation method of desktop file from cp to install
     - Rework debian/copyright in compliance to present standards
     - Update debian/watch
     - Creation of a debian/compat file (level 5) and removal of all DH_COMPAT
       reference in debian/rules
     - Update of the Builds-Dependence to debhelper to >>5.0.0 and removal of
       the deprecated dh_testversion in debian/rules
     - Update of the Standard-Version debian/control to 3.7.2

 -- Christophe Sauthier <email address hidden> Fri, 7 Sep 2007 01:44:39 +0200

[Cesare Tirabassi (norsetto)]

Christophe, you can also use the one I built on my PPA:

http://ppa.launchpad.net/norsetto/ubuntu/pool/universe/f/flightgear/

note that when using your PPA it is advised to add a ~ppa# at the end, so that you can increment the test version easily. Once you think it is ready, just replace the ~ppa# with the correct version (in this case 0.9.10-2ubuntu1~ppa1 -> 0.9.10-2ubuntu2).

[Christophe Sauthier (christophe.sauthier)]

flightgear (0.9.10-2ubuntu2~ppa2) gutsy; urgency=low

  * Add 48x48 icon (LP: #133600)
    - add flightgear.xpm in debian/
    - add icon copyright's information in debian/copyright
  * Modify Maintainer value to match Debian-Maintainer-Field Spec
  * Update debian/flightgear.desktop:
    - Add icon
    - Removal of the Encoding entry (deprecated)
    - Change Version to 1.0
  * General clean-up:
     - Add usr/share/pixmaps and usr/share/applications in debian/dirs
     - Remove mkdir of usr/share/applications in debian/rules
     - Change installation method of desktop file from cp to install
     - Rework debian/copyright in compliance to present standards
     - Update debian/watch
     - Creation of a debian/compat file (level 5) and removal of all DH_COMPAT
       reference in debian/rules
     - Update of the Builds-Dependence to debhelper to >>5.0.0 and removal of
       the deprecated dh_testversion in debian/rules
     - Update of the Standard-Version debian/control to 3.7.2

 -- Christophe Sauthier <email address hidden> Mon, 10 Sep 2007 12:43:36 +0200

[Christophe Sauthier (christophe.sauthier)]

flightgear (0.9.10-2ubuntu2~ppa3) gutsy; urgency=low

  * Add 48x48 icon (LP: #133600)
    - add flightgear.xpm in debian/
    - add icon copyright's information in debian/copyright
  * Modify Maintainer value to match Debian-Maintainer-Field Spec
  * Update debian/flightgear.desktop:
    - Add icon
    - Removal of the Encoding entry (deprecated)
    - Change Version to 1.0
  * General clean-up:
     - Add usr/share/pixmaps and usr/share/applications in debian/dirs
     - Remove mkdir of usr/share/applications in debian/rules
     - Change installation method of desktop file from cp to install
     - Rework debian/copyright in compliance to present standards
     - Update debian/watch
     - Creation of a debian/compat file (level 5) and removal of all DH_COMPAT
       reference in debian/rules
     - Update of the Builds-Dependence to debhelper to >>5.0.0 and removal of
       the deprecated dh_testversion in debian/rules
     - Update of the Standard-Version debian/control to 3.7.2

 -- Christophe Sauthier <email address hidden> Mon, 10 Sep 2007 13:06:07 +0200

[Cesare Tirabassi (norsetto)]

I really hope this will be fixed soon:

https://bugs.launchpad.net/soyuz/+bug/137767

[Christophe Sauthier (christophe.sauthier)]

Here is the debdiff that fixes it. Attention the build in my ppa called flightgear_0.9.10-2ubuntu2.deb is incomplete (wrong usage of the ppa), but this is the right debdiff. It corresponds to the flightgear_0.9.10-2ubuntu2+ppa4 build on my ppa which is correct.

[Cesare Tirabassi (norsetto)]

If you are happy with the patch, please:

- change the status to confirmed
- change the assignment to none
- subscribe u-u-s

Note that section is still universe/games.
For details about the sponsorship process, please refer to this wiki page:

https://wiki.ubuntu.com/MOTU/Sponsorship/SponsorsQueue

[Christophe Sauthier (christophe.sauthier)]

The same debdiff tha the previous one except that I changed the section in the debian/control the match again the one needed in ubuntu for inclusion (opposite to the one needed in building in ppa).

[Luke Yelavich (themuso)]

If you are doing package cleanup, it might be worthwhile satisfying the following lintian warnings for the
binary deb, particularly the last 5.

luke@marin:~/Projects/Ubuntu_Development/gutsy/sources/flightgear$ lintian flightgear_0.9.10-2ubuntu2_i386.deb
W: flightgear: binary-without-manpage usr/games/al-info
W: flightgear: binary-without-manpage usr/games/metar
W: flightgear: binary-without-manpage usr/games/terrasync
W: flightgear: binary-without-manpage usr/games/yasim
W: flightgear: package-contains-readme-for-other-platform-or-distro usr/share/doc/flightgear/README.Cygwin
W: flightgear: package-contains-readme-for-other-platform-or-distro usr/share/doc/flightgear/README.IRIX
W: flightgear: package-contains-readme-for-other-platform-or-distro usr/share/doc/flightgear/README.MacOS
W: flightgear: unquoted-string-in-menu-item /usr/share/menu/flightgear needs:2
W: flightgear: unquoted-string-in-menu-item /usr/share/menu/flightgear section:2

[Christophe Sauthier (christophe.sauthier)]

An updated debdiff that corrects the last 5 warnings you've mentioned.

[Christophe Sauthier (christophe.sauthier)]

The new updated debdiff which has been corrected again.

[Christophe Sauthier (christophe.sauthier)]

flightgear (0.9.10-2ubuntu2) gutsy; urgency=low

  * Add 48x48 icon (LP: #133600)
    - add flightgear.xpm in debian/
    - add icon copyright's information in debian/copyright
  * Modify Maintainer value to match Debian-Maintainer-Field Spec
  * Update debian/flightgear.desktop:
    - Add icon
    - Removal of the Encoding entry (deprecated)
    - Change Version to 1.0
  * General clean-up:
     - Add usr/share/pixmaps and usr/share/applications in debian/dirs
     - Remove mkdir of usr/share/applications in debian/rules
     - Change installation method of desktop file from cp to install
     - Rework debian/copyright in compliance to present standards
     - Update debian/watch
     - Update debian/menu
     - Creation of a debian/compat file (level 5) and removal of all DH_COMPAT
     - Update of the Builds-Dependence to debhelper to >>5.0.0 and removal of
       the deprecated dh_testversion in debian/rules
     - Update of the Standard-Version debian/control to 3.7.2
     - Heavier usage of dh_installdocs and removal of all platform specific
       README in the package

 -- Christophe Sauthier <email address hidden> Fri, 14 Sep 2007 16:12:05 +0200