Comment 21 for bug 1901344

Revision history for this message
Robie Basak (racb) wrote :

I fixed a few things up, figuring we'd done enough back and forthing on this already. For the record:

The cinnamon Groovy debdiff didn't apply, but as it's supposed to be the same as the patch being applied to Focal, I picked up your changelog entry and manually took the quilt patch from Focal. This seems to work.

The cinnamon-screensaver patch (update-spotify-album-art-url.patch) varies very slightly between Focal and Groovy, including one statement-ending semicolon disappearing in Groovy. Since it's Python, I trust this makes no functional difference.

The Groovy changelog entries said "groovy-updates" in their header. I'm not sure how that'll be handled by Launchpad; it may redirect just fine. But to save another iteration to find out, I just changed both to "groovy" to match convention and your debdiffs for Focal.

The SRU information in this bug looks good, and the bug references in the changelog entries and version numbers are all correct. Sponsored and unsubscribed ~ubuntu-sponsors. Thanks!

Now awaiting SRU team review (I shouldn't do that myself as I sponsored).