Comment 8 for bug 1882375

Revision history for this message
Joshua Peisach (itzswirlz) wrote : Re: Cinnamon custom keyboard shortcuts don't work until logout

I love when I mess up the versions. I fixed it and another small issue

SRU template is the same (mostly)

[Impact]

 * The users who manually set their own Keyboard Shortcuts will not have them applied until a full
 reset of Cinnamon occurs.
 * This can be very annoying and the code insertion is adding a reverse trigger to the custom list keybinding, and then adding a dummy string in case it can't (if there is only one keybind).

[Test Case]

 * The bug is simply reproducable by changing a Keyboard Shortcut and testing it. It will likely
 not work until you log out and log in again.

[Regression Potential]

 * Through this change it looks like there won't be any regression. Later on I will backport more
 patches added to cinnamon.

 * Two commits were made on this-another one was a revisit that fixed one so it looks like we are stable enough to not have to worry about regressions.

 * The updated version of this patch actually fixes a regression-we should be okay.

[Other Info]

 * Backporting patch from Linux Mint upstream, solved a few other issues
 * This is a FIXED patch to not mess up other patches and it also fixes a (probably) regression.
 * This is my 3rd attempt, fixed changelog and version