Comment 5 for bug 1986925

Hang on, look at that hard-coded directory name: "/snap/gnome-3-38-2004".
Since the gnome extension under core 22 is named just "gnome", any
hardcoded names to the old extension should fail.

On Thu, Aug 18, 2022 at 10:15 AM Robert Day <email address hidden>
wrote:

> Same result:
>
> 2022-08-18 14:13:31.315 :: + OUT=out/Release
>
> 2022-08-18 14:13:31.316 :: + mkdir -p out/Release
>
> 2022-08-18 14:13:31.335 :: + cp /root/snaps/snap-from-source/stage/build/
> args.gn out/Release/
> 2022-08-18 14:13:31.367 :: + '[' amd64 = armhf ']'
>
> 2022-08-18 14:13:31.367 :: + '[' amd64 = armhf ']'
>
> 2022-08-18 14:13:31.368 :: + cd /usr/lib/x86_64-linux-gnu/pkgconfig
>
> 2022-08-18 14:13:31.368 :: + ln -s libdrm.pc libdrm-uninstalled.pc
>
> 2022-08-18 14:13:31.389 :: + cd -
>
> 2022-08-18 14:13:31.389 ::
> /root/snaps/snap-from-source/parts/chromium/build
>
> 2022-08-18 14:13:31.389 :: + out/Release/gn gen out/Release
>
> 2022-08-18 14:13:37.548 :: ERROR at
> //build/config/linux/pkg_config.gni:104:17: Script returned non-zero exit
> code.
>
> 2022-08-18 14:13:37.549 :: pkgresult = exec_script(pkg_config_script,
> args, "value")
> 2022-08-18 14:13:37.549 :: ^----------
>
> 2022-08-18 14:13:37.549 :: Current dir:
> /root/snaps/snap-from-source/parts/chromium/build/out/Release/
> 2022-08-18 14:13:37.549 :: Command: python3
> /root/snaps/snap-from-source/parts/chromium/build/build/config/linux/pkg-config.py
> -p /snap/gnome-3-38-2004/current/usr/bin/pkg-config x11-xcb
>
> 2022-08-18 14:13:37.549 :: Returned 1.
>
> 2022-08-18 14:13:37.549 :: stderr:
>
> 2022-08-18 14:13:37.549 ::
>
> 2022-08-18 14:13:37.550 :: Could not run pkg-config.
>
> 2022-08-18 14:13:37.550 ::
>
> 2022-08-18 14:13:37.550 :: See
> //third_party/swiftshader/src/Vulkan/BUILD.gn:69:5: whence it was called.
> 2022-08-18 14:13:37.550 :: pkg_config("x11-xcb") {
>
> 2022-08-18 14:13:37.550 :: ^----------------------
>
> 2022-08-18 14:13:37.550 :: See //BUILD.gn:529:7: which caused the file to
> be included.
> 2022-08-18 14:13:37.550 ::
> "//third_party/swiftshader/src/Vulkan:swiftshader_libvulkan",
> 2022-08-18 14:13:37.550 ::
> ^-----------------------------------------------------------
> 2022-08-18 14:13:37.782 'override-build' in part 'chromium' failed with
> code 1.
> Review the scriptlet and make sure it's correct.
>
> 2022-08-18 14:13:37.867 Traceback (most recent call last):
>
> 2022-08-18 14:13:37.867 File
> "/snap/snapcraft/8122/lib/python3.8/site-packages/snapcraft/parts/parts.py",
> line 170, in run
>
> 2022-08-18 14:13:37.867 aex.execute(action, stdout=stream,
> stderr=stream)
> 2022-08-18 14:13:37.867 File
> "/snap/snapcraft/8122/lib/python3.8/site-packages/craft_parts/executor/executor.py",
> line 301, in execute
>
> 2022-08-18 14:13:37.867 self._executor.execute(actions, stdout=stdout,
> stderr=stderr)
> 2022-08-18 14:13:37.867 File
> "/snap/snapcraft/8122/lib/python3.8/site-packages/craft_parts/executor/executor.py",
> line 126, in execute
>
> 2022-08-18 14:13:37.867 self._run_action(act, stdout=stdout,
> stderr=stderr)
> 2022-08-18 14:13:37.868 File
> "/snap/snapcraft/8122/lib/python3.8/site-packages/craft_parts/executor/executor.py",
> line 189, in _run_action
>
> 2022-08-18 14:13:37.868 handler.run_action(action, stdout=stdout,
> stderr=stderr)
> 2022-08-18 14:13:37.868 File
> "/snap/snapcraft/8122/lib/python3.8/site-packages/craft_parts/executor/part_handler.py",
> line 161, in run_action
>
> 2022-08-18 14:13:37.868 state = handler(step_info, stdout=stdout,
> stderr=stderr)
> 2022-08-18 14:13:37.868 File
> "/snap/snapcraft/8122/lib/python3.8/site-packages/craft_parts/executor/part_handler.py",
> line 297, in _run_build
>
> 2022-08-18 14:13:37.868 self._run_step(
>
> 2022-08-18 14:13:37.868 File
> "/snap/snapcraft/8122/lib/python3.8/site-packages/craft_parts/executor/part_handler.py",
> line 469, in _run_step
>
> 2022-08-18 14:13:37.868 step_handler.run_scriptlet(
>
> 2022-08-18 14:13:37.868 File
> "/snap/snapcraft/8122/lib/python3.8/site-packages/craft_parts/executor/step_handler.py",
> line 265, in run_scriptlet
>
> 2022-08-18 14:13:37.868 raise errors.ScriptletRunError(
>
> 2022-08-18 14:13:37.868 craft_parts.errors.ScriptletRunError:
> 'override-build' in part 'chromium' failed with code 1.
>
>
> 2022-08-18 14:13:37.869 Review the scriptlet and make sure it's correct.
>
> 2022-08-18 14:13:37.869 Full execution log:
> '/root/.cache/snapcraft/log/snapcraft-20220818-140941.486880.log'
>
>
> I think pkg-config is being invoked, it's just failing based on what it's
> being asked to do.
>
> On Thu, Aug 18, 2022 at 10:11 AM Robert Day <email address hidden>
> wrote:
>
>> OK, I'm trying that now, but I would be astonished if that was the
>> solution as pkg-config is already installed, either because I installed it
>> manually at some point, or maybe it was installed by an earlier snap, who
>> knows? But it's definitely there so adding it to "build-packages" should
>> make no difference.
>>
>> On Thu, Aug 18, 2022 at 9:30 AM Nathan Teodosio <
>> <email address hidden>> wrote:
>>
>>> Thanks for the bug report, Robert.
>>>
>>> My first attempt would be adding a pkg-config line to the build-packages
>>> of chromium. Does it make sense to you? If yes, could you please try
>>> that?
>>>
>>> --
>>> You received this bug notification because you are subscribed to the bug
>>> report.
>>> https://bugs.launchpad.net/bugs/1986925
>>>
>>> Title:
>>> [snap] Trying to build chromium snap for core22: pkg-config fails.
>>>
>>> Status in chromium-browser package in Ubuntu:
>>> New
>>>
>>> Bug description:
>>> I checked out the "dev" branch of chromium-browser from launchpad and
>>> did what seemed necessary to update snapcraft.yaml to build with
>>> snapcraft 7 for core22. The only change of any significance was to
>>> change the extension from "gnome-3-38" to the core22-specific "gnome"
>>> extension. I started the build and it ran for quite some time (in a
>>> persistent 22.04 LXD container) until:
>>>
>>> 2022-08-18 09:11:00.869 :: + OUT=out/Release
>>>
>>> 2022-08-18 09:11:00.869 :: + mkdir -p out/Release
>>>
>>> 2022-08-18 09:11:00.888 :: + cp
>>> /root/snaps/snap-from-source/stage/build/args.gn out/Release/
>>>
>>> 2022-08-18 09:11:00.922 :: + '[' amd64 = armhf ']'
>>>
>>> 2022-08-18 09:11:00.922 :: + '[' amd64 = armhf ']'
>>>
>>> 2022-08-18 09:11:00.922 :: + cd /usr/lib/x86_64-linux-gnu/pkgconfig
>>>
>>> 2022-08-18 09:11:00.922 :: + ln -s libdrm.pc libdrm-uninstalled.pc
>>>
>>> 2022-08-18 09:11:00.935 :: + cd -
>>>
>>> 2022-08-18 09:11:00.935 ::
>>> /root/snaps/snap-from-source/parts/chromium/build
>>>
>>> 2022-08-18 09:11:00.935 :: + out/Release/gn gen out/Release
>>>
>>> 2022-08-18 09:11:07.112 :: ERROR at
>>> //build/config/linux/pkg_config.gni:104:17: Script returned non-zero exit
>>> code.
>>>
>>> 2022-08-18 09:11:07.112 :: pkgresult =
>>> exec_script(pkg_config_script, args, "value")
>>> 2022-08-18 09:11:07.113 :: ^----------
>>>
>>> 2022-08-18 09:11:07.113 :: Current dir:
>>> /root/snaps/snap-from-source/parts/chromium/build/out/Release/
>>> 2022-08-18 09:11:07.113 :: Command: python3
>>> /root/snaps/snap-from-source/parts/chromium/build/build/config/linux/pkg-config.py
>>> -p /snap/gnome-3-38-2004/current/usr/bin/pkg-config x11-xcb
>>>
>>> 2022-08-18 09:11:07.113 :: Returned 1.
>>>
>>> 2022-08-18 09:11:07.113 :: stderr:
>>>
>>> 2022-08-18 09:11:07.113 ::
>>>
>>> 2022-08-18 09:11:07.113 :: Could not run pkg-config.
>>>
>>> 2022-08-18 09:11:07.113 ::
>>>
>>> 2022-08-18 09:11:07.113 :: See
>>> //third_party/swiftshader/src/Vulkan/BUILD.gn:69:5: whence it was called.
>>> 2022-08-18 09:11:07.113 :: pkg_config("x11-xcb") {
>>>
>>> 2022-08-18 09:11:07.113 :: ^----------------------
>>>
>>> 2022-08-18 09:11:07.114 :: See //BUILD.gn:529:7: which caused the file
>>> to be included.
>>> 2022-08-18 09:11:07.114 ::
>>> "//third_party/swiftshader/src/Vulkan:swiftshader_libvulkan",
>>> 2022-08-18 09:11:07.114 ::
>>> ^-----------------------------------------------------------
>>> 2022-08-18 09:11:07.243 'override-build' in part 'chromium' failed
>>> with code 1.
>>> Review the scriptlet and make sure it's correct.
>>>
>>> I verified that the pkg-config utility is installed in the container;
>>> I can only suspect that this error is related to switching to the
>>> core22 gnome extension. I am open to suggestions.
>>>
>>> To manage notifications about this bug go to:
>>>
>>> https://bugs.launchpad.net/ubuntu/+source/chromium-browser/+bug/1986925/+subscriptions
>>>
>>>