[snap] Trying to build chromium snap for core22: pkg-config fails.

[Robert P. J. Day]

I checked out the "dev" branch of chromium-browser from launchpad and did what seemed necessary to update snapcraft.yaml to build with snapcraft 7 for core22. The only change of any significance was to change the extension from "gnome-3-38" to the core22-specific "gnome" extension. I started the build and it ran for quite some time (in a persistent 22.04 LXD container) until:

2022-08-18 09:11:00.869 :: + OUT=out/Release
2022-08-18 09:11:00.869 :: + mkdir -p out/Release
2022-08-18 09:11:00.888 :: + cp /root/snaps/snap-from-source/stage/build/args.gn out/Release/
2022-08-18 09:11:00.922 :: + '[' amd64 = armhf ']'
2022-08-18 09:11:00.922 :: + '[' amd64 = armhf ']'
2022-08-18 09:11:00.922 :: + cd /usr/lib/x86_64-linux-gnu/pkgconfig
2022-08-18 09:11:00.922 :: + ln -s libdrm.pc libdrm-uninstalled.pc
2022-08-18 09:11:00.935 :: + cd -
2022-08-18 09:11:00.935 :: /root/snaps/snap-from-source/parts/chromium/build
2022-08-18 09:11:00.935 :: + out/Release/gn gen out/Release
2022-08-18 09:11:07.112 :: ERROR at //build/config/linux/pkg_config.gni:104:17: Script returned non-zero exit code.
2022-08-18 09:11:07.112 :: pkgresult = exec_script(pkg_config_script, args, "value")
2022-08-18 09:11:07.113 :: ^----------
2022-08-18 09:11:07.113 :: Current dir: /root/snaps/snap-from-source/parts/chromium/build/out/Release/
2022-08-18 09:11:07.113 :: Command: python3 /root/snaps/snap-from-source/parts/chromium/build/build/config/linux/pkg-config.py -p /snap/gnome-3-38-2004/current/usr/bin/pkg-config x11-xcb
2022-08-18 09:11:07.113 :: Returned 1.
2022-08-18 09:11:07.113 :: stderr:
2022-08-18 09:11:07.113 ::
2022-08-18 09:11:07.113 :: Could not run pkg-config.
2022-08-18 09:11:07.113 ::
2022-08-18 09:11:07.113 :: See //third_party/swiftshader/src/Vulkan/BUILD.gn:69:5: whence it was called.
2022-08-18 09:11:07.113 :: pkg_config("x11-xcb") {
2022-08-18 09:11:07.113 :: ^----------------------
2022-08-18 09:11:07.114 :: See //BUILD.gn:529:7: which caused the file to be included.
2022-08-18 09:11:07.114 :: "//third_party/swiftshader/src/Vulkan:swiftshader_libvulkan",
2022-08-18 09:11:07.114 :: ^-----------------------------------------------------------
2022-08-18 09:11:07.243 'override-build' in part 'chromium' failed with code 1.
Review the scriptlet and make sure it's correct.

I verified that the pkg-config utility is installed in the container; I can only suspect that this error is related to switching to the core22 gnome extension. I am open to suggestions.

[Robert P. J. Day (rpjday)]

Let me know if there's anything you want me to test; I have the container sitting here, ready for further experimentation.

[Nathan Teodosio (nteodosio)]

Thanks for the bug report, Robert.

My first attempt would be adding a pkg-config line to the build-packages of chromium. Does it make sense to you? If yes, could you please try that?

[Robert P. J. Day (rpjday)]

OK, I'm trying that now, but I would be astonished if that was the solution
as pkg-config is already installed, either because I installed it manually
at some point, or maybe it was installed by an earlier snap, who knows? But
it's definitely there so adding it to "build-packages" should make no
difference.

On Thu, Aug 18, 2022 at 9:30 AM Nathan Teodosio <email address hidden>
wrote:

> Thanks for the bug report, Robert.
>
> My first attempt would be adding a pkg-config line to the build-packages
> of chromium. Does it make sense to you? If yes, could you please try
> that?
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1986925
>
> Title:
> [snap] Trying to build chromium snap for core22: pkg-config fails.
>
> Status in chromium-browser package in Ubuntu:
> New
>
> Bug description:
> I checked out the "dev" branch of chromium-browser from launchpad and
> did what seemed necessary to update snapcraft.yaml to build with
> snapcraft 7 for core22. The only change of any significance was to
> change the extension from "gnome-3-38" to the core22-specific "gnome"
> extension. I started the build and it ran for quite some time (in a
> persistent 22.04 LXD container) until:
>
> 2022-08-18 09:11:00.869 :: + OUT=out/Release
>
> 2022-08-18 09:11:00.869 :: + mkdir -p out/Release
>
> 2022-08-18 09:11:00.888 :: + cp /root/snaps/snap-from-source/stage/build/
> args.gn out/Release/
> 2022-08-18 09:11:00.922 :: + '[' amd64 = armhf ']'
>
> 2022-08-18 09:11:00.922 :: + '[' amd64 = armhf ']'
>
> 2022-08-18 09:11:00.922 :: + cd /usr/lib/x86_64-linux-gnu/pkgconfig
>
> 2022-08-18 09:11:00.922 :: + ln -s libdrm.pc libdrm-uninstalled.pc
>
> 2022-08-18 09:11:00.935 :: + cd -
>
> 2022-08-18 09:11:00.935 ::
> /root/snaps/snap-from-source/parts/chromium/build
>
> 2022-08-18 09:11:00.935 :: + out/Release/gn gen out/Release
>
> 2022-08-18 09:11:07.112 :: ERROR at
> //build/config/linux/pkg_config.gni:104:17: Script returned non-zero exit
> code.
>
> 2022-08-18 09:11:07.112 :: pkgresult =
> exec_script(pkg_config_script, args, "value")
> 2022-08-18 09:11:07.113 :: ^----------
>
> 2022-08-18 09:11:07.113 :: Current dir:
> /root/snaps/snap-from-source/parts/chromium/build/out/Release/
> 2022-08-18 09:11:07.113 :: Command: python3
> /root/snaps/snap-from-source/parts/chromium/build/build/config/linux/pkg-config.py
> -p /snap/gnome-3-38-2004/current/usr/bin/pkg-config x11-xcb
>
> 2022-08-18 09:11:07.113 :: Returned 1.
>
> 2022-08-18 09:11:07.113 :: stderr:
>
> 2022-08-18 09:11:07.113 ::
>
> 2022-08-18 09:11:07.113 :: Could not run pkg-config.
>
> 2022-08-18 09:11:07.113 ::
>
> 2022-08-18 09:11:07.113 :: See
> //third_party/swiftshader/src/Vulkan/BUILD.gn:69:5: whence it was called.
> 2022-08-18 09:11:07.113 :: pkg_config("x11-xcb") {
>
> 2022-08-18 09:11:07.113 :: ^----------------------
>
> 2022-08-18 09:11:07.114 :: See //BUILD.gn:529:7: which caused the file
> to be included.
> 2022-08-18 09:11:07.114 ::
> "//third_party/swiftshader/src/Vulkan:swiftshader_libvulkan",
> 2022-08-18 09:11:07.114 ::
...

[Robert P. J. Day (rpjday)]

Same result:

2022-08-18 14:13:31.315 :: + OUT=out/Release

2022-08-18 14:13:31.316 :: + mkdir -p out/Release

2022-08-18 14:13:31.335 :: + cp /root/snaps/snap-from-source/stage/build/
args.gn out/Release/
2022-08-18 14:13:31.367 :: + '[' amd64 = armhf ']'

2022-08-18 14:13:31.367 :: + '[' amd64 = armhf ']'

2022-08-18 14:13:31.368 :: + cd /usr/lib/x86_64-linux-gnu/pkgconfig

2022-08-18 14:13:31.368 :: + ln -s libdrm.pc libdrm-uninstalled.pc

2022-08-18 14:13:31.389 :: + cd -

2022-08-18 14:13:31.389 ::
/root/snaps/snap-from-source/parts/chromium/build

2022-08-18 14:13:31.389 :: + out/Release/gn gen out/Release

2022-08-18 14:13:37.548 :: ERROR at
//build/config/linux/pkg_config.gni:104:17: Script returned non-zero exit
code.

2022-08-18 14:13:37.549 :: pkgresult = exec_script(pkg_config_script,
args, "value")
2022-08-18 14:13:37.549 :: ^----------

2022-08-18 14:13:37.549 :: Current dir:
/root/snaps/snap-from-source/parts/chromium/build/out/Release/
2022-08-18 14:13:37.549 :: Command: python3
/root/snaps/snap-from-source/parts/chromium/build/build/config/linux/pkg-config.py
-p /snap/gnome-3-38-2004/current/usr/bin/pkg-config x11-xcb

2022-08-18 14:13:37.549 :: Returned 1.

2022-08-18 14:13:37.549 :: stderr:

2022-08-18 14:13:37.549 ::

2022-08-18 14:13:37.550 :: Could not run pkg-config.

2022-08-18 14:13:37.550 ::

2022-08-18 14:13:37.550 :: See
//third_party/swiftshader/src/Vulkan/BUILD.gn:69:5: whence it was called.
2022-08-18 14:13:37.550 :: pkg_config("x11-xcb") {

2022-08-18 14:13:37.550 :: ^----------------------

2022-08-18 14:13:37.550 :: See //BUILD.gn:529:7: which caused the file to
be included.
2022-08-18 14:13:37.550 ::
"//third_party/swiftshader/src/Vulkan:swiftshader_libvulkan",
2022-08-18 14:13:37.550 ::
^-----------------------------------------------------------
2022-08-18 14:13:37.782 'override-build' in part 'chromium' failed with
code 1.
Review the scriptlet and make sure it's correct.

2022-08-18 14:13:37.867 Traceback (most recent call last):

2022-08-18 14:13:37.867 File
"/snap/snapcraft/8122/lib/python3.8/site-packages/snapcraft/parts/parts.py",
line 170, in run

2022-08-18 14:13:37.867 aex.execute(action, stdout=stream,
stderr=stream)
2022-08-18 14:13:37.867 File
"/snap/snapcraft/8122/lib/python3.8/site-packages/craft_parts/executor/executor.py",
line 301, in execute

2022-08-18 14:13:37.867 self._executor.execute(actions, stdout=stdout,
stderr=stderr)
2022-08-18 14:13:37.867 File
"/snap/snapcraft/8122/lib/python3.8/site-packages/craft_parts/executor/executor.py",
line 126, in execute

2022-08-18 14:13:37.867 self._run_action(act, stdout=stdout,
stderr=stderr)
2022-08-18 14:13:37.868 File
"/snap/snapcraft/8122/lib/python3.8/site-packages/craft_parts/executor/executor.py",
line 189, in _run_action

2022-08-18 14:13:37.868 handler.run_action(action, stdout=stdout,
stderr=stderr)
2022-08-18 14:13:37.868 File
"/snap/snapcraft/8122/lib/python3.8/site-packages/craft_parts/executor/part_handler.py",
line 161, in run_action

2022-08-18 14:13:37.868 state = handler(step_info, stdout=stdout,
stderr=stderr)
2022-08-18 14:13:37.868 File
"/snap/snapcraft/8122/lib/pytho...

[Robert P. J. Day (rpjday)]

Hang on, look at that hard-coded directory name: "/snap/gnome-3-38-2004".
Since the gnome extension under core 22 is named just "gnome", any
hardcoded names to the old extension should fail.

On Thu, Aug 18, 2022 at 10:15 AM Robert Day <email address hidden>
wrote:

> Same result:
>
> 2022-08-18 14:13:31.315 :: + OUT=out/Release
>
> 2022-08-18 14:13:31.316 :: + mkdir -p out/Release
>
> 2022-08-18 14:13:31.335 :: + cp /root/snaps/snap-from-source/stage/build/
> args.gn out/Release/
> 2022-08-18 14:13:31.367 :: + '[' amd64 = armhf ']'
>
> 2022-08-18 14:13:31.367 :: + '[' amd64 = armhf ']'
>
> 2022-08-18 14:13:31.368 :: + cd /usr/lib/x86_64-linux-gnu/pkgconfig
>
> 2022-08-18 14:13:31.368 :: + ln -s libdrm.pc libdrm-uninstalled.pc
>
> 2022-08-18 14:13:31.389 :: + cd -
>
> 2022-08-18 14:13:31.389 ::
> /root/snaps/snap-from-source/parts/chromium/build
>
> 2022-08-18 14:13:31.389 :: + out/Release/gn gen out/Release
>
> 2022-08-18 14:13:37.548 :: ERROR at
> //build/config/linux/pkg_config.gni:104:17: Script returned non-zero exit
> code.
>
> 2022-08-18 14:13:37.549 :: pkgresult = exec_script(pkg_config_script,
> args, "value")
> 2022-08-18 14:13:37.549 :: ^----------
>
> 2022-08-18 14:13:37.549 :: Current dir:
> /root/snaps/snap-from-source/parts/chromium/build/out/Release/
> 2022-08-18 14:13:37.549 :: Command: python3
> /root/snaps/snap-from-source/parts/chromium/build/build/config/linux/pkg-config.py
> -p /snap/gnome-3-38-2004/current/usr/bin/pkg-config x11-xcb
>
> 2022-08-18 14:13:37.549 :: Returned 1.
>
> 2022-08-18 14:13:37.549 :: stderr:
>
> 2022-08-18 14:13:37.549 ::
>
> 2022-08-18 14:13:37.550 :: Could not run pkg-config.
>
> 2022-08-18 14:13:37.550 ::
>
> 2022-08-18 14:13:37.550 :: See
> //third_party/swiftshader/src/Vulkan/BUILD.gn:69:5: whence it was called.
> 2022-08-18 14:13:37.550 :: pkg_config("x11-xcb") {
>
> 2022-08-18 14:13:37.550 :: ^----------------------
>
> 2022-08-18 14:13:37.550 :: See //BUILD.gn:529:7: which caused the file to
> be included.
> 2022-08-18 14:13:37.550 ::
> "//third_party/swiftshader/src/Vulkan:swiftshader_libvulkan",
> 2022-08-18 14:13:37.550 ::
> ^-----------------------------------------------------------
> 2022-08-18 14:13:37.782 'override-build' in part 'chromium' failed with
> code 1.
> Review the scriptlet and make sure it's correct.
>
> 2022-08-18 14:13:37.867 Traceback (most recent call last):
>
> 2022-08-18 14:13:37.867 File
> "/snap/snapcraft/8122/lib/python3.8/site-packages/snapcraft/parts/parts.py",
> line 170, in run
>
> 2022-08-18 14:13:37.867 aex.execute(action, stdout=stream,
> stderr=stream)
> 2022-08-18 14:13:37.867 File
> "/snap/snapcraft/8122/lib/python3.8/site-packages/craft_parts/executor/executor.py",
> line 301, in execute
>
> 2022-08-18 14:13:37.867 self._executor.execute(actions, stdout=stdout,
> stderr=stderr)
> 2022-08-18 14:13:37.867 File
> "/snap/snapcraft/8122/lib/python3.8/site-packages/craft_parts/executor/executor.py",
> line 126, in execute
>
> 2022-08-18 14:13:37.867 self._run_action(act, stdout=stdout,
> stderr=stderr)
> 2022-08-18 14:13:37.868 File
> "/snap/snapcraft/8122/lib/python3.8/site-packages/craft_parts/executor/e...

[Olivier Tilloy (osomon)]

Yes, you will need to update build/args.gn where there's a hardcoded path to the pkg-config binary (https://git.launchpad.net/~chromium-team/chromium-browser/+git/snap-from-source/tree/build/args.gn?h=stable#n39).

[Robert P. J. Day (rpjday)]

I made that change, it still failed:

2022-08-18 14:31:54.099 :: Current dir: /root/snaps/snap-from-source/parts/chromium/build/out/Release/
2022-08-18 14:31:54.099 :: Command: python3 /root/snaps/snap-from-source/parts/chromium/build/build/config/linux/pkg-config.py -p /snap/gnome-42-2204/current/usr/bin/pkg-config x11-xcb
2022-08-18 14:31:54.099 :: Returned 1.
2022-08-18 14:31:54.099 :: stderr:
2022-08-18 14:31:54.099 ::
2022-08-18 14:31:54.099 :: Could not run pkg-config.

but that appears to be because this newer gnome does not supply such an executable; there is no "pkg-config" under /snap/gnome-42-2204/current/usr/bin/, as I assume there must have been under gnome-3-38. What about just deleting that line from build/args.gn, and assuming pkg-config is run from the standard package?

[Robert P. J. Day (rpjday)]

Just deleting that line seemed to allow the build to progress further, but now I have a slew of errors; I'll post a snippet here, then must run off but will be back in a bit:

2022-08-18 14:42:14.617 :: In file included from ../../third_party/angle/src/gpu_info_util/SystemInfo_vulkan.cpp:10:
2022-08-18 14:42:14.617 :: In file included from ../../third_party/angle/src/gpu_info_util/SystemInfo_vulkan.h:12:
2022-08-18 14:42:14.617 :: In file included from ../../third_party/angle/src/common/vulkan/vulkan_icd.h:15:
2022-08-18 14:42:14.617 :: In file included from ../../third_party/angle/src/common/vulkan/vk_headers.h:14:
2022-08-18 14:42:14.617 :: In file included from ../../third_party/angle/src/third_party/volk/volk.h:50:
2022-08-18 14:42:14.617 :: In file included from ../../third_party/vulkan-deps/vulkan-headers/src/include/vulkan/vulkan.h:41:
2022-08-18 14:42:14.617 :: In file included from ../../third_party/wayland/src/src/wayland-client.h:40:
2022-08-18 14:42:14.617 :: /usr/include/wayland-client-protocol.h:1038:13: error: use of undeclared identifier 'wl_proxy_marshal_flags'
2022-08-18 14:42:14.618 :: callback = wl_proxy_marshal_flags((struct wl_proxy *) wl_display,
2022-08-18 14:42:14.618 :: ^
2022-08-18 14:42:14.618 :: /usr/include/wayland-client-protocol.h:1062:13: error: use of undeclared identifier 'wl_proxy_marshal_flags'
2022-08-18 14:42:14.618 :: registry = wl_proxy_marshal_flags((struct wl_proxy *) wl_display,
2022-08-18 14:42:14.618 :: ^
2022-08-18 14:42:14.618 :: /usr/include/wayland...

[Nathan Teodosio (nteodosio)]

> but that appears to be because this newer gnome does not supply such an executable; there is no "pkg-config" under /snap/gnome-42-2204/current/usr/bin/, as I assume there must have been under gnome-3-38.

Oh, so this time pkg-config in build-packages could solve it? Probably you will have to remove the pkg_config line from args.gn, though.

[Robert P. J. Day (rpjday)]

That's what I did, but that's also when I got the errors I included in my
previous comment. I'm rebuilding just to make sure those errors are
reproducible.

On Thu, Aug 18, 2022 at 12:45 PM Nathan Teodosio <email address hidden>
wrote:

> > but that appears to be because this newer gnome does not supply such
> an executable; there is no "pkg-config" under
> /snap/gnome-42-2204/current/usr/bin/, as I assume there must have been
> under gnome-3-38.
>
> Oh, so this time pkg-config in build-packages could solve it? Probably
> you will have to remove the pkg_config line from args.gn, though.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1986925
>
> Title:
> [snap] Trying to build chromium snap for core22: pkg-config fails.
>
> Status in chromium-browser package in Ubuntu:
> New
>
> Bug description:
> I checked out the "dev" branch of chromium-browser from launchpad and
> did what seemed necessary to update snapcraft.yaml to build with
> snapcraft 7 for core22. The only change of any significance was to
> change the extension from "gnome-3-38" to the core22-specific "gnome"
> extension. I started the build and it ran for quite some time (in a
> persistent 22.04 LXD container) until:
>
> 2022-08-18 09:11:00.869 :: + OUT=out/Release
>
> 2022-08-18 09:11:00.869 :: + mkdir -p out/Release
>
> 2022-08-18 09:11:00.888 :: + cp /root/snaps/snap-from-source/stage/build/
> args.gn out/Release/
> 2022-08-18 09:11:00.922 :: + '[' amd64 = armhf ']'
>
> 2022-08-18 09:11:00.922 :: + '[' amd64 = armhf ']'
>
> 2022-08-18 09:11:00.922 :: + cd /usr/lib/x86_64-linux-gnu/pkgconfig
>
> 2022-08-18 09:11:00.922 :: + ln -s libdrm.pc libdrm-uninstalled.pc
>
> 2022-08-18 09:11:00.935 :: + cd -
>
> 2022-08-18 09:11:00.935 ::
> /root/snaps/snap-from-source/parts/chromium/build
>
> 2022-08-18 09:11:00.935 :: + out/Release/gn gen out/Release
>
> 2022-08-18 09:11:07.112 :: ERROR at
> //build/config/linux/pkg_config.gni:104:17: Script returned non-zero exit
> code.
>
> 2022-08-18 09:11:07.112 :: pkgresult =
> exec_script(pkg_config_script, args, "value")
> 2022-08-18 09:11:07.113 :: ^----------
>
> 2022-08-18 09:11:07.113 :: Current dir:
> /root/snaps/snap-from-source/parts/chromium/build/out/Release/
> 2022-08-18 09:11:07.113 :: Command: python3
> /root/snaps/snap-from-source/parts/chromium/build/build/config/linux/pkg-config.py
> -p /snap/gnome-3-38-2004/current/usr/bin/pkg-config x11-xcb
>
> 2022-08-18 09:11:07.113 :: Returned 1.
>
> 2022-08-18 09:11:07.113 :: stderr:
>
> 2022-08-18 09:11:07.113 ::
>
> 2022-08-18 09:11:07.113 :: Could not run pkg-config.
>
> 2022-08-18 09:11:07.113 ::
>
> 2022-08-18 09:11:07.113 :: See
> //third_party/swiftshader/src/Vulkan/BUILD.gn:69:5: whence it was called.
> 2022-08-18 09:11:07.113 :: pkg_config("x11-xcb") {
>
> 2022-08-18 09:11:07.113 :: ^----------------------
>
> 2022-08-18 09:11:07.114 :: See //BUILD.gn:529:7: which caused the file
> to be included.
> 2022-08-18 09:11:07.114 ::
> "//third_party/swiftshader/src/Vulkan:swiftshader_libvulkan",
> 2022-08-18 09:1...

[Robert P. J. Day (rpjday)]

Yup, same errors ... lots of "wl "and "marshal" undefined references.
Here's just a small sample:

2022-08-18 17:03:57.646 :: /usr/include/wayland-client-protocol.h:1038:13:
error: use of undeclared identifier 'wl_proxy_marshal_flags'

2022-08-18 17:03:57.646 :: callback =
wl_proxy_marshal_flags((struct wl_proxy *) wl_display,

2022-08-18 17:03:57.646 :: ^

2022-08-18 17:03:57.646 :: /usr/include/wayland-client-protocol.h:1062:13:
error: use of undeclared identifier 'wl_proxy_marshal_flags'

2022-08-18 17:03:57.646 :: registry =
wl_proxy_marshal_flags((struct wl_proxy *) wl_display,

2022-08-18 17:03:57.646 :: ^

2022-08-18 17:03:57.646 :: /usr/include/wayland-client-protocol.h:1175:7:
error: use of undeclared identifier 'wl_proxy_marshal_flags'

2022-08-18 17:03:57.646 :: id = wl_proxy_marshal_flags((struct
wl_proxy *) wl_registry,

2022-08-18 17:03:57.646 :: ^

2022-08-18 17:03:57.646 :: /usr/include/wayland-client-protocol.h:1291:7:
error: use of undeclared identifier 'wl_proxy_marshal_flags'

2022-08-18 17:03:57.646 :: id = wl_proxy_marshal_flags((struct
wl_proxy *) wl_compositor,

2022-08-18 17:03:57.647 :: ^

2022-08-18 17:03:57.647 :: /usr/include/wayland-client-protocol.h:1307:7:
error: use of undeclared identifier 'wl_proxy_marshal_flags'

2022-08-18 17:03:57.647 :: id = wl_proxy_marshal_flags((struct
wl_proxy *) wl_compositor,

2022-08-18 17:03:57.647 :: ^

2022-08-18 17:03:57.647 :: /usr/include/wayland-client-protocol.h:1371:7:
error: use of undeclared identifier 'wl_proxy_marshal_flags'

2022-08-18 17:03:57.647 :: id = wl_proxy_marshal_flags((struct
wl_proxy *) wl_shm_pool,

2022-08-18 17:03:57.647 :: ^

On Thu, Aug 18, 2022 at 1:04 PM Robert Day <email address hidden> wrote:

> That's what I did, but that's also when I got the errors I included in my
> previous comment. I'm rebuilding just to make sure those errors are
> reproducible.
>
> On Thu, Aug 18, 2022 at 12:45 PM Nathan Teodosio <
> <email address hidden>> wrote:
>
>> > but that appears to be because this newer gnome does not supply such
>> an executable; there is no "pkg-config" under
>> /snap/gnome-42-2204/current/usr/bin/, as I assume there must have been
>> under gnome-3-38.
>>
>> Oh, so this time pkg-config in build-packages could solve it? Probably
>> you will have to remove the pkg_config line from args.gn, though.
>>
>> --
>> You received this bug notification because you are subscribed to the bug
>> report.
>> https://bugs.launchpad.net/bugs/1986925
>>
>> Title:
>> [snap] Trying to build chromium snap for core22: pkg-config fails.
>>
>> Status in chromium-browser package in Ubuntu:
>> New
>>
>> Bug description:
>> I checked out the "dev" branch of chromium-browser from launchpad and
>> did what seemed necessary to update snapcraft.yaml to build with
>> snapcraft 7 for core22. The only change of any significance was to
>> change the extension from "gnome-3-38" to the core22-specific "gnome"
>> extension. I started the build and it ran for quite some time (in a
>> persistent 22.04 LXD co...

[Robert P. J. Day (rpjday)]

This appears to describe precisely this issue:

https://github.com/libsdl-org/SDL/pull/5092

On Thu, Aug 18, 2022 at 1:06 PM Robert Day <email address hidden> wrote:

> Yup, same errors ... lots of "wl "and "marshal" undefined references.
> Here's just a small sample:
>
> 2022-08-18 17:03:57.646 :: /usr/include/wayland-client-protocol.h:1038:13:
> error: use of undeclared identifier 'wl_proxy_marshal_flags'
>
>
> 2022-08-18 17:03:57.646 :: callback =
> wl_proxy_marshal_flags((struct wl_proxy *) wl_display,
>
>
> 2022-08-18 17:03:57.646 :: ^
>
>
>
> 2022-08-18 17:03:57.646 :: /usr/include/wayland-client-protocol.h:1062:13:
> error: use of undeclared identifier 'wl_proxy_marshal_flags'
>
>
> 2022-08-18 17:03:57.646 :: registry =
> wl_proxy_marshal_flags((struct wl_proxy *) wl_display,
>
>
> 2022-08-18 17:03:57.646 :: ^
>
>
>
> 2022-08-18 17:03:57.646 :: /usr/include/wayland-client-protocol.h:1175:7:
> error: use of undeclared identifier 'wl_proxy_marshal_flags'
>
>
> 2022-08-18 17:03:57.646 :: id = wl_proxy_marshal_flags((struct
> wl_proxy *) wl_registry,
>
>
> 2022-08-18 17:03:57.646 :: ^
>
>
>
> 2022-08-18 17:03:57.646 :: /usr/include/wayland-client-protocol.h:1291:7:
> error: use of undeclared identifier 'wl_proxy_marshal_flags'
>
>
> 2022-08-18 17:03:57.646 :: id = wl_proxy_marshal_flags((struct
> wl_proxy *) wl_compositor,
>
>
> 2022-08-18 17:03:57.647 :: ^
>
>
>
> 2022-08-18 17:03:57.647 :: /usr/include/wayland-client-protocol.h:1307:7:
> error: use of undeclared identifier 'wl_proxy_marshal_flags'
>
>
> 2022-08-18 17:03:57.647 :: id = wl_proxy_marshal_flags((struct
> wl_proxy *) wl_compositor,
>
>
> 2022-08-18 17:03:57.647 :: ^
>
>
>
> 2022-08-18 17:03:57.647 :: /usr/include/wayland-client-protocol.h:1371:7:
> error: use of undeclared identifier 'wl_proxy_marshal_flags'
>
>
> 2022-08-18 17:03:57.647 :: id = wl_proxy_marshal_flags((struct
> wl_proxy *) wl_shm_pool,
>
>
> 2022-08-18 17:03:57.647 :: ^
>
>
> On Thu, Aug 18, 2022 at 1:04 PM Robert Day <email address hidden>
> wrote:
>
>> That's what I did, but that's also when I got the errors I included in my
>> previous comment. I'm rebuilding just to make sure those errors are
>> reproducible.
>>
>> On Thu, Aug 18, 2022 at 12:45 PM Nathan Teodosio <
>> <email address hidden>> wrote:
>>
>>> > but that appears to be because this newer gnome does not supply such
>>> an executable; there is no "pkg-config" under
>>> /snap/gnome-42-2204/current/usr/bin/, as I assume there must have been
>>> under gnome-3-38.
>>>
>>> Oh, so this time pkg-config in build-packages could solve it? Probably
>>> you will have to remove the pkg_config line from args.gn, though.
>>>
>>> --
>>> You received this bug notification because you are subscribed to the bug
>>> report.
>>> https://bugs.launchpad.net/bugs/1986925
>>>
>>> Title:
>>> [snap] Trying to build chromium snap for core22: pkg-config fails.
>>>
>>> Status in chromium-browser package in Ubuntu:
>>> New
>>>
>>> Bug description:
>>> I checked out the "dev" branch of chromium-browser from launchpad and
>>>...

[Nathan Teodosio (nteodosio)]

What is libwayland-client0 version in your logs? Focal has 1.18.0, but

    wayland-1.21.0/debian/libwayland-client0.symbols: wl_proxy_marshal_flags@Base 1.20.0

[Robert P. J. Day (rpjday)]

A comprehensive grep includes the lines:

parts/launcher/state/build: - libwayland-client0=1.20.0-1
parts/va-drivers/state/build: - libwayland-client0=1.20.0-1
parts/pipewire/state/build: - libwayland-client0=1.20.0-1
parts/chromium-build/state/build: - libwayland-client0=1.20.0-1
parts/manpage/state/build: - libwayland-client0=1.20.0-1

Oh, wait, there we
go: parts/chromium/build/chrome/installer/linux/debian/dist_package_versions.json
appears to be a version manifest that does not include anything for 22.04.
Does that sound like the problem?

P.S. Thanks for your patience with all of this.

On Thu, Aug 18, 2022 at 3:30 PM Nathan Teodosio <email address hidden>
wrote:

> What is libwayland-client0 version in your logs? Focal has 1.18.0, but
>
> wayland-1.21.0/debian/libwayland-client0.symbols:
> wl_proxy_marshal_flags@Base 1.20.0
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1986925
>
> Title:
> [snap] Trying to build chromium snap for core22: pkg-config fails.
>
> Status in chromium-browser package in Ubuntu:
> New
>
> Bug description:
> I checked out the "dev" branch of chromium-browser from launchpad and
> did what seemed necessary to update snapcraft.yaml to build with
> snapcraft 7 for core22. The only change of any significance was to
> change the extension from "gnome-3-38" to the core22-specific "gnome"
> extension. I started the build and it ran for quite some time (in a
> persistent 22.04 LXD container) until:
>
> 2022-08-18 09:11:00.869 :: + OUT=out/Release
>
> 2022-08-18 09:11:00.869 :: + mkdir -p out/Release
>
> 2022-08-18 09:11:00.888 :: + cp /root/snaps/snap-from-source/stage/build/
> args.gn out/Release/
> 2022-08-18 09:11:00.922 :: + '[' amd64 = armhf ']'
>
> 2022-08-18 09:11:00.922 :: + '[' amd64 = armhf ']'
>
> 2022-08-18 09:11:00.922 :: + cd /usr/lib/x86_64-linux-gnu/pkgconfig
>
> 2022-08-18 09:11:00.922 :: + ln -s libdrm.pc libdrm-uninstalled.pc
>
> 2022-08-18 09:11:00.935 :: + cd -
>
> 2022-08-18 09:11:00.935 ::
> /root/snaps/snap-from-source/parts/chromium/build
>
> 2022-08-18 09:11:00.935 :: + out/Release/gn gen out/Release
>
> 2022-08-18 09:11:07.112 :: ERROR at
> //build/config/linux/pkg_config.gni:104:17: Script returned non-zero exit
> code.
>
> 2022-08-18 09:11:07.112 :: pkgresult =
> exec_script(pkg_config_script, args, "value")
> 2022-08-18 09:11:07.113 :: ^----------
>
> 2022-08-18 09:11:07.113 :: Current dir:
> /root/snaps/snap-from-source/parts/chromium/build/out/Release/
> 2022-08-18 09:11:07.113 :: Command: python3
> /root/snaps/snap-from-source/parts/chromium/build/build/config/linux/pkg-config.py
> -p /snap/gnome-3-38-2004/current/usr/bin/pkg-config x11-xcb
>
> 2022-08-18 09:11:07.113 :: Returned 1.
>
> 2022-08-18 09:11:07.113 :: stderr:
>
> 2022-08-18 09:11:07.113 ::
>
> 2022-08-18 09:11:07.113 :: Could not run pkg-config.
>
> 2022-08-18 09:11:07.113 ::
>
> 2022-08-18 09:11:07.113 :: See
> //third_party/swiftshader/src/Vulkan/BUILD.gn:69:5: whence it was called.
> 2022-08-18 09:11:07.113 :: pkg_config("x11-xcb") {
>
> 2022-08...

[Robert P. J. Day (rpjday)]

Actually, another part of my grep search produced the following, which
seems to suggest that an older version of libwayland-client0 is being used:

parts/chromium/build/build/linux/sysroot_scripts/generated_package_lists/bullseye.mips64el:
https://snapshot.debian.org/archive/debian/20220331T153654Z/pool/main/w/wayland/libwayland-client0_1.18.0-2~exp1.1_mips64el.deb
parts/chromium/build/build/linux/sysroot_scripts/generated_package_lists/bullseye.arm64:
https://snapshot.debian.org/archive/debian/20220331T153654Z/pool/main/w/wayland/libwayland-client0_1.18.0-2~exp1.1_arm64.deb
parts/chromium/build/build/linux/sysroot_scripts/generated_package_lists/bullseye.i386:
https://snapshot.debian.org/archive/debian/20220331T153654Z/pool/main/w/wayland/libwayland-client0_1.18.0-2~exp1.1_i386.deb
parts/chromium/build/build/linux/sysroot_scripts/generated_package_lists/bullseye.armel:
https://snapshot.debian.org/archive/debian/20220331T153654Z/pool/main/w/wayland/libwayland-client0_1.18.0-2~exp1.1_armel.deb
parts/chromium/build/build/linux/sysroot_scripts/generated_package_lists/bullseye.mipsel:
https://snapshot.debian.org/archive/debian/20220331T153654Z/pool/main/w/wayland/libwayland-client0_1.18.0-2~exp1.1_mipsel.deb
parts/chromium/build/build/linux/sysroot_scripts/generated_package_lists/bullseye.arm:
https://snapshot.debian.org/archive/debian/20220331T153654Z/pool/main/w/wayland/libwayland-client0_1.18.0-2~exp1.1_armhf.deb
parts/chromium/build/build/linux/sysroot_scripts/generated_package_lists/bullseye.amd64:
https://snapshot.debian.org/archive/debian/20220331T153654Z/pool/main/w/wayland/libwayland-client0_1.18.0-2~exp1.1_amd64.deb

At least that's the way I read it.

rday

On Thu, Aug 18, 2022 at 3:43 PM Robert Day <email address hidden> wrote:

> A comprehensive grep includes the lines:
>
> parts/launcher/state/build: - libwayland-client0=1.20.0-1
> parts/va-drivers/state/build: - libwayland-client0=1.20.0-1
> parts/pipewire/state/build: - libwayland-client0=1.20.0-1
> parts/chromium-build/state/build: - libwayland-client0=1.20.0-1
> parts/manpage/state/build: - libwayland-client0=1.20.0-1
>
> Oh, wait, there we
> go: parts/chromium/build/chrome/installer/linux/debian/dist_package_versions.json
> appears to be a version manifest that does not include anything for 22.04.
> Does that sound like the problem?
>
> P.S. Thanks for your patience with all of this.
>
> On Thu, Aug 18, 2022 at 3:30 PM Nathan Teodosio <
> <email address hidden>> wrote:
>
>> What is libwayland-client0 version in your logs? Focal has 1.18.0, but
>>
>> wayland-1.21.0/debian/libwayland-client0.symbols:
>> wl_proxy_marshal_flags@Base 1.20.0
>>
>> --
>> You received this bug notification because you are subscribed to the bug
>> report.
>> https://bugs.launchpad.net/bugs/1986925
>>
>> Title:
>> [snap] Trying to build chromium snap for core22: pkg-config fails.
>>
>> Status in chromium-browser package in Ubuntu:
>> New
>>
>> Bug description:
>> I checked out the "dev" branch of chromium-browser from launchpad and
>> did what seemed necessary to update snapcraft.yaml to build with
>> snapcraft 7 for core22. The only change of any significance was to
>> chang...

[Robert P. J. Day (rpjday)]

Last comment for the day ... from what little I've seen, it seems like it
might require defining a lengthy list of packages relative to 22.04 to
migrate this snap to 22.04. Or maybe I'm misreading it. In any event, I'd
still like to make this happen.

On Thu, Aug 18, 2022 at 3:56 PM Robert Day <email address hidden> wrote:

> Actually, another part of my grep search produced the following, which
> seems to suggest that an older version of libwayland-client0 is being used:
>
>
> parts/chromium/build/build/linux/sysroot_scripts/generated_package_lists/bullseye.mips64el:
> https://snapshot.debian.org/archive/debian/20220331T153654Z/pool/main/w/wayland/libwayland-client0_1.18.0-2~exp1.1_mips64el.deb
>
> parts/chromium/build/build/linux/sysroot_scripts/generated_package_lists/bullseye.arm64:
> https://snapshot.debian.org/archive/debian/20220331T153654Z/pool/main/w/wayland/libwayland-client0_1.18.0-2~exp1.1_arm64.deb
>
> parts/chromium/build/build/linux/sysroot_scripts/generated_package_lists/bullseye.i386:
> https://snapshot.debian.org/archive/debian/20220331T153654Z/pool/main/w/wayland/libwayland-client0_1.18.0-2~exp1.1_i386.deb
>
> parts/chromium/build/build/linux/sysroot_scripts/generated_package_lists/bullseye.armel:
> https://snapshot.debian.org/archive/debian/20220331T153654Z/pool/main/w/wayland/libwayland-client0_1.18.0-2~exp1.1_armel.deb
>
> parts/chromium/build/build/linux/sysroot_scripts/generated_package_lists/bullseye.mipsel:
> https://snapshot.debian.org/archive/debian/20220331T153654Z/pool/main/w/wayland/libwayland-client0_1.18.0-2~exp1.1_mipsel.deb
>
> parts/chromium/build/build/linux/sysroot_scripts/generated_package_lists/bullseye.arm:
> https://snapshot.debian.org/archive/debian/20220331T153654Z/pool/main/w/wayland/libwayland-client0_1.18.0-2~exp1.1_armhf.deb
>
> parts/chromium/build/build/linux/sysroot_scripts/generated_package_lists/bullseye.amd64:
> https://snapshot.debian.org/archive/debian/20220331T153654Z/pool/main/w/wayland/libwayland-client0_1.18.0-2~exp1.1_amd64.deb
>
> At least that's the way I read it.
>
> rday
>
> On Thu, Aug 18, 2022 at 3:43 PM Robert Day <email address hidden>
> wrote:
>
>> A comprehensive grep includes the lines:
>>
>> parts/launcher/state/build: - libwayland-client0=1.20.0-1
>> parts/va-drivers/state/build: - libwayland-client0=1.20.0-1
>> parts/pipewire/state/build: - libwayland-client0=1.20.0-1
>> parts/chromium-build/state/build: - libwayland-client0=1.20.0-1
>> parts/manpage/state/build: - libwayland-client0=1.20.0-1
>>
>> Oh, wait, there we
>> go: parts/chromium/build/chrome/installer/linux/debian/dist_package_versions.json
>> appears to be a version manifest that does not include anything for 22.04.
>> Does that sound like the problem?
>>
>> P.S. Thanks for your patience with all of this.
>>
>> On Thu, Aug 18, 2022 at 3:30 PM Nathan Teodosio <
>> <email address hidden>> wrote:
>>
>>> What is libwayland-client0 version in your logs? Focal has 1.18.0, but
>>>
>>> wayland-1.21.0/debian/libwayland-client0.symbols:
>>> wl_proxy_marshal_flags@Base 1.20.0
>>>
>>> --
>>> You received this bug notification because you are subscribed to the bug
>>> report.
>>> https://bugs.launchp...

[Nathan Teodosio (nteodosio)]

For a matter of fact, wl_proxy_marshal_flags is declared in wayland-client-core.h, provided by libwayland-dev, which is specified in the build-packages of chromium in snapcraft.yaml. As long as it is version >=1.20, I'd think it should work, but reality shows otherwise.

I'm trying to build the snap too so I can see full logs, but weirdly they are much less verbose than what I'm used to (e.g. https://launchpadlibrarian.net/618908242/buildlog_snap_ubuntu_jammy_amd64_chromium-browser-core22_BUILDING.txt.gz), and I don't want to believe that would be caused by a mere switch to core22.

> P.S. Thanks for your patience with all of this.

No such thing, it's a pleasure :). This is both useful and a great chance to better understand snaps.

[Robert P. J. Day (rpjday)]

My interest in this is that I'm stress testing migrating snaps to core
22/snapcraft 7 as part of the update for the Snapcraft 101 course, and when
I asked my team for an example of a snap that would be challenging to
migrate, one of them immediately suggested chromium, so that's why I'm
working on this. So far, the necessary changes were fairly minimal, until
this issue, which I don't know what to do with.

Perhaps one should create a core 22 branch where I can submit my changes.

In terms of getting more output, with Snapcraft 7, I'm running "snapcraft
--verbosity=trace" for tons of output.

Anyway, this wl_proxy* stuff is the current bottleneck.

On Fri, Aug 19, 2022 at 7:25 AM Nathan Teodosio <email address hidden>
wrote:

> For a matter of fact, wl_proxy_marshal_flags is declared in wayland-
> client-core.h, provided by libwayland-dev, which is specified in the
> build-packages of chromium in snapcraft.yaml. As long as it is version
> >=1.20, I'd think it should work, but reality shows otherwise.
>
> I'm trying to build the snap too so I can see full logs, but weirdly
> they are much less verbose than what I'm used to (e.g.
>
> https://launchpadlibrarian.net/618908242/buildlog_snap_ubuntu_jammy_amd64_chromium-
> browser-core22_BUILDING.txt.gz
> <https://launchpadlibrarian.net/618908242/buildlog_snap_ubuntu_jammy_amd64_chromium-browser-core22_BUILDING.txt.gz>),
> and I don't want to believe that would
> be caused by a mere switch to core22.
>
> > P.S. Thanks for your patience with all of this.
>
> No such thing, it's a pleasure :). This is both useful and a great
> chance to better understand snaps.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1986925
>
> Title:
> [snap] Trying to build chromium snap for core22: pkg-config fails.
>
> Status in chromium-browser package in Ubuntu:
> New
>
> Bug description:
> I checked out the "dev" branch of chromium-browser from launchpad and
> did what seemed necessary to update snapcraft.yaml to build with
> snapcraft 7 for core22. The only change of any significance was to
> change the extension from "gnome-3-38" to the core22-specific "gnome"
> extension. I started the build and it ran for quite some time (in a
> persistent 22.04 LXD container) until:
>
> 2022-08-18 09:11:00.869 :: + OUT=out/Release
>
> 2022-08-18 09:11:00.869 :: + mkdir -p out/Release
>
> 2022-08-18 09:11:00.888 :: + cp /root/snaps/snap-from-source/stage/build/
> args.gn out/Release/
> 2022-08-18 09:11:00.922 :: + '[' amd64 = armhf ']'
>
> 2022-08-18 09:11:00.922 :: + '[' amd64 = armhf ']'
>
> 2022-08-18 09:11:00.922 :: + cd /usr/lib/x86_64-linux-gnu/pkgconfig
>
> 2022-08-18 09:11:00.922 :: + ln -s libdrm.pc libdrm-uninstalled.pc
>
> 2022-08-18 09:11:00.935 :: + cd -
>
> 2022-08-18 09:11:00.935 ::
> /root/snaps/snap-from-source/parts/chromium/build
>
> 2022-08-18 09:11:00.935 :: + out/Release/gn gen out/Release
>
> 2022-08-18 09:11:07.112 :: ERROR at
> //build/config/linux/pkg_config.gni:104:17: Script returned non-zero exit
> code.
>
> 2022-08-18 09:11:07.112 :: pkgresult =
> exec_script(pkg_config_script...

[Nathan Teodosio (nteodosio)]

> Perhaps one should create a core 22 branch where I can submit my changes.

I think that is only possible with a team. See if you can push to https://code.launchpad.net/~chromium-core22/+git/chromium-core22. If yes, just force push your current work to it.

[Robert P. J. Day (rpjday)]

Ok, thanks.

On Fri, Aug 19, 2022 at 8:10 AM Nathan Teodosio <email address hidden>
wrote:

> > Perhaps one should create a core 22 branch where I can submit my
> changes.
>
> I think that is only possible with a team. See if you can push to
> https://code.launchpad.net/~chromium-core22/+git/chromium-core22. If
> yes, just force push your current work to it.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1986925
>
> Title:
> [snap] Trying to build chromium snap for core22: pkg-config fails.
>
> Status in chromium-browser package in Ubuntu:
> New
>
> Bug description:
> I checked out the "dev" branch of chromium-browser from launchpad and
> did what seemed necessary to update snapcraft.yaml to build with
> snapcraft 7 for core22. The only change of any significance was to
> change the extension from "gnome-3-38" to the core22-specific "gnome"
> extension. I started the build and it ran for quite some time (in a
> persistent 22.04 LXD container) until:
>
> 2022-08-18 09:11:00.869 :: + OUT=out/Release
>
> 2022-08-18 09:11:00.869 :: + mkdir -p out/Release
>
> 2022-08-18 09:11:00.888 :: + cp /root/snaps/snap-from-source/stage/build/
> args.gn out/Release/
> 2022-08-18 09:11:00.922 :: + '[' amd64 = armhf ']'
>
> 2022-08-18 09:11:00.922 :: + '[' amd64 = armhf ']'
>
> 2022-08-18 09:11:00.922 :: + cd /usr/lib/x86_64-linux-gnu/pkgconfig
>
> 2022-08-18 09:11:00.922 :: + ln -s libdrm.pc libdrm-uninstalled.pc
>
> 2022-08-18 09:11:00.935 :: + cd -
>
> 2022-08-18 09:11:00.935 ::
> /root/snaps/snap-from-source/parts/chromium/build
>
> 2022-08-18 09:11:00.935 :: + out/Release/gn gen out/Release
>
> 2022-08-18 09:11:07.112 :: ERROR at
> //build/config/linux/pkg_config.gni:104:17: Script returned non-zero exit
> code.
>
> 2022-08-18 09:11:07.112 :: pkgresult =
> exec_script(pkg_config_script, args, "value")
> 2022-08-18 09:11:07.113 :: ^----------
>
> 2022-08-18 09:11:07.113 :: Current dir:
> /root/snaps/snap-from-source/parts/chromium/build/out/Release/
> 2022-08-18 09:11:07.113 :: Command: python3
> /root/snaps/snap-from-source/parts/chromium/build/build/config/linux/pkg-config.py
> -p /snap/gnome-3-38-2004/current/usr/bin/pkg-config x11-xcb
>
> 2022-08-18 09:11:07.113 :: Returned 1.
>
> 2022-08-18 09:11:07.113 :: stderr:
>
> 2022-08-18 09:11:07.113 ::
>
> 2022-08-18 09:11:07.113 :: Could not run pkg-config.
>
> 2022-08-18 09:11:07.113 ::
>
> 2022-08-18 09:11:07.113 :: See
> //third_party/swiftshader/src/Vulkan/BUILD.gn:69:5: whence it was called.
> 2022-08-18 09:11:07.113 :: pkg_config("x11-xcb") {
>
> 2022-08-18 09:11:07.113 :: ^----------------------
>
> 2022-08-18 09:11:07.114 :: See //BUILD.gn:529:7: which caused the file
> to be included.
> 2022-08-18 09:11:07.114 ::
> "//third_party/swiftshader/src/Vulkan:swiftshader_libvulkan",
> 2022-08-18 09:11:07.114 ::
> ^-----------------------------------------------------------
> 2022-08-18 09:11:07.243 'override-build' in part 'chromium' failed with
> code 1.
> Review the scriptlet and make sure it's correct.
>
> I verified t...