Comment 0 for bug 1329090

Hello,

== Bug 1: Wrong blacklisting ==

It seems that the patch 'bzr1719_unblacklist_intel_hd4000.patch' has a typo: the blacklist was not fully removed. The blacklist of the Intel 4000HD video card is no longer needed because this bug has been fixed thanks to the 10.1 version of Mesa.
But this patch wrongly removes the blacklist and then it's possible that you'll need to force the OpenGL backend (with the '-o' option) to use it even if you don't have this Intel 4000HD video card and you choose to use it.

== Bug 2: Menus are not correctly positioned ==

There is also a bug with the menus: It seems that the behaviour of menus with a custom position has changed since using GTK 3.10: https://bugzilla.gnome.org/show_bug.cgi?id=721094
We now have to use the 'natural' size instead of the 'minimum' size:

    - gtk_widget_get_preferred_size (GTK_WIDGET (menu), &requisition, NULL);
    + gtk_widget_get_preferred_size (GTK_WIDGET (menu), NULL, &requisition);

A branch has been linked to this bug report and it fixes these 2 bugs.

[Test Case]

For the first bug: You should be able to reproduce this bug when using Free and Open Source video drivers. Simply launch the dock for the first time from a terminal:

    $ cairo-dock
    (or if it's not the first time: $ cairo-dock -A)

You should see a window to confirm that you want to use the OpenGL backend: click on this "Yes" button. Then you should see on the terminal that you're not using the OpenGL backend: "Running with OpenGL: 0"

For the second bug: simply do a right click on the dock and you should see that the menu is over the dock instead of on top of it. Cairo-Dock's menus should not overlap the dock.

[Regression Potential]

The only possible regression that I see is that this OpenGL backend could maybe be accidentally blocked for some users which have an old, exotic and badly supported video card. If these users enable this OpenGL backend, the dock can look strange but this is why there is a message the first time you launch the dock ;-)

Note that these two patches have been tested and added in our unstable and stable PPAs and in the official Utopic repositories one month ago.