Ubuntu
brother-lpr-drivers-common package

  1. Bug #264509
  2. Comment #1

Comment 1 for bug 264509

Revision history for this message
Saivann Carignan (oxmosys) wrote :

FriedChicken : I reviewed the packages currently in your PPA, this is nice job! However, there is still things to fix before we can upload it :

1. Base your work on new intrepid packages : I recently uploaded a newer package to intrepid. Source packages can be downloaded here : http://packages.ubuntu.com/search?keywords=brother-lpr-drivers&searchon=names&suite=intrepid&section=all

2. Direct changes in the source : brother-lpr-drivers-common now contains /usr/local/Brother/inf/brPrintList. However, you didn't include this change in the .orig.tar.gz tarball, so that means that the .diff.gz contains changes applied outside of debian folder. With common debian packaging, we try to avoid direct modification on the source. The orig.tar.gz file should contains the source, and the .diff.gz should only contains changes in debian folder. If the package must apply changes on the source, this should be done with a patch system inside debian folder. However, in this case, we're the creator of this source package so we can update it at anytime.

What you need to do for this is simply to add brPrintList to the orig.tar.gz tarball, and then rename the tarball so it have a new upstream version (current is 1.0.0-3, so you can use 1.0.0-4). Don't forget to update your debian changelog to have the save upstream version number (since this is a new "upstream" version, the ubuntu version number should get back to "ubuntu1".

3. (LP: #264509) in changelog. Please add this LP syntax to close this bug report when your package will be uploaded.

4. debian/postinst missing in changelog : The package now have debian/postinst to fix permissions, however this change is not mentionned in changelog. Don't forget to write every changes in changelog ;-) .

Once this is done, can you build and test your package, and attach a debdiff for brother-lpr-drivers-laser1 and the complete source package for brother-lpr-drivers-common (including orig.tar.gz, diff.gz, dsc and changes files in one single compressed file)?

Thank you very much for the time you spent to improve the brother packages. If you can't do it for intrepid, don't hesitate to let me doing it for you.