Comment 2 for bug 766017

Revision history for this message
In , Fsvm88 (fsvm88) wrote :

I tried to compile media-video/avidemux-2.5.4-r2, but the compile phase always fails. I have been able to patch the problem successfully. GCC 4.6 is stricter than previous versions and avidemux code triggers some spots where some particular code semantics is not allowed by the standard.

Reproducible: Always

Steps to Reproduce:
1. emerge -1 gcc:4.6
2. use it as default compiler
3. emerge -1 avidemux
Actual Results:
Avidemux fails to compile.

Expected Results:
Avidemux should compile fine.

I'm on ~amd64 but I guess the compile errors should show up on any architecture when using GCC 4.6. The errors arise because GCC 4.6 is stricter than previous versions about code semantics. I tried with and without graphite flags (whole world was recompiled), and all of the available versions in portage. I have tried also the SVN ebuild from multimedia overlay but it still fails in the same spots.
The three attached patches resolve the problems and allow avidemux to compile fine. I've tested the avidemux GUI interface which is the affected part and it works ok.
It should not introduce errors with previous GCC versions since the patch is cosmetic only (I've been unable to test with GCC<4.6).
I guess this should also be filed upstream.
Thanks.