Comment 14 for bug 824708

On 2 July 2012 20:25, Marcin Juszkiewicz <email address hidden> wrote:
> Can someone take a look at aptitude 0.6.1-1ubuntu1 at
> http://marcin.juszkiewicz.com.pl/~hrw/ubuntu/ ?

* Between 0.6.6 and 0.6.8 there has been many changes made upstream to
the files under debian/. Have you given consideration to those
changes?

* Removed debian/05aptitude, yet this is still mentioned in
debian/changelog. Why removed?

diff -Nru aptitude-0.6.6/debian/05aptitude aptitude-0.6.8/debian/05aptitude
--- aptitude-0.6.6/debian/05aptitude 2012-03-28 20:36:07.000000000 +0800
+++ aptitude-0.6.8/debian/05aptitude 1970-01-01 08:00:00.000000000 +0800
@@ -1,3 +0,0 @@
-aptitude::Keep-Unused-Pattern "^linux-image.*$ |
^linux-restricted-modules.*$ | ^linux-ubuntu-modules.*$";
-aptitude::Get-Root-Command "sudo:/usr/bin/sudo";
-

* Unexplained changes to debian/control:

  - Maintainer:

diff -Nru aptitude-0.6.6/debian/control aptitude-0.6.8/debian/control
--- aptitude-0.6.6/debian/control 2012-03-28 20:57:43.000000000 +0800
+++ aptitude-0.6.8/debian/control 2012-07-02 18:58:38.000000000 +0800
@@ -1,30 +1,29 @@
 Source: aptitude
 Section: admin
 Priority: important
-Maintainer: Ubuntu Developers <email address hidden>
-XSBC-Original-Maintainer: Aptitude Development Team
<email address hidden>
+Maintainer: Aptitude Development Team <email address hidden>
 Uploaders: Daniel Burrows <email address hidden>, Daniel Hartwig
<email address hidden>
 DM-Upload-Allowed: yes

  - VCS:

-XS-Debian-Vcs-Git: git://git.debian.org/git/aptitude/aptitude.git
-XS-Debian-Vcs-Browser: http://git.debian.org/?p=aptitude/aptitude.git;a=summary
+Vcs-Git: git://git.debian.org/git/aptitude/aptitude.git
+Vcs-Browser: http://git.debian.org/?p=aptitude/aptitude.git;a=summary
 Standards-Version: 3.9.3
 Homepage: http://aptitude.alioth.debian.org/

* Dropped debian/patches/11_ubuntu_uses_sudo -- ok, this has been
merged upstream.

* Dropped debian/patches/12_point_manpage_to_doc_package -- ok, also
merged upstream.

* debian/patches/14_html2text_preferred:

  - file paths have version number hardcoded:

diff -Nru aptitude-0.6.6/debian/patches/14_html2text_preferred
aptitude-0.6.8/debian/patches/14_html2text_preferred
--- aptitude-0.6.6/debian/patches/14_html2text_preferred 2012-03-28
20:36:07.000000000 +0800
+++ aptitude-0.6.8/debian/patches/14_html2text_preferred 2012-07-02
18:39:24.000000000 +0800
…
---- aptitude.orig/doc/html-to-text
-+++ aptitude/doc/html-to-text
…
+--- aptitude-0.6.8.orig/doc/html-to-text
++++ aptitude-0.6.8/doc/html-to-text

  - upstream introduced $encoding in html-to-text which is not used by
your updates to this patch. Is it ok that your patched version
ignores it and forces encoding to ASCII?

* debian/patches/no-google-mock:

  - File paths also now have version hardcoded.
  - Diff is very large, are the changes reliable?